Bug 1188176

Summary: Missing namespace and prinicipal parameters for managing users in CLI
Product: [Retired] oVirt Reporter: Ondra Machacek <omachace>
Component: ovirt-engine-apiAssignee: Oved Ourfali <oourfali>
Status: CLOSED CURRENTRELEASE QA Contact: Ondra Machacek <omachace>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.5CC: alonbl, bugs, ecohen, gklein, juan.hernandez, lsurette, oourfali, rbalakri, yeylon
Target Milestone: ---   
Target Release: 3.5.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: org.ovirt.engine-root-3.5.1-3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1194271 1194273 (view as bug list) Environment:
Last Closed: 2015-04-29 06:17:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1076964, 1193058, 1194271, 1194273    

Description Ondra Machacek 2015-02-02 09:23:20 UTC 
Description of problem:


Version-Release number of selected component (if applicable):
rhevm-restapi-3.5.0-0.30.el6ev.noarch
rhevm-cli-3.5.0.5-1.el6ev.noarch

How reproducible:
always

Steps to Reproduce:
1. Add ldap domain into engine(ie via engine-manage-domains)
2. add user from this domain to engine. 
shell (connected)]# add user 
correlation_id  domain-id       domain-name     expect          user_name

Actual results:
Missing principal and namespace parameter

Expected results:
principal and namespace parameter are not missing

Additional info:
Comment 1 Juan Hernández 2015-02-02 11:19:13 UTC 
This happens because the "principal" and "namespace" parameters aren't correctly documented in the RSDL metadata. Once the metadata is fixed the Python and Java SDKs will need to be regenerated. The CLI itself won't need any change.
Comment 2 Yair Zaslavsky 2015-02-05 13:57:18 UTC 
Juan, any reason groups:add is not represented in RSDL?
Comment 3 Juan Hernández 2015-02-05 14:14:58 UTC 
(In reply to Yair Zaslavsky from comment #2)
> Juan, any reason groups:add is not represented in RSDL?

It is represented. From "rsdl_metadata.yaml":

- name: /groups|rel=add
  description: add a new group to the system
  request:
    body:
      parameterType: Group
      signatures:
      - mandatoryArguments: {group.name: 'xs:string'}
        description: add a new group to the system
    urlparams: {}
    headers:
      Content-Type: {value: application/xml|json, required: true}
      Correlation-Id: {value: 'any string', required: false}

And from the generated RSDL document:

<link href="groups" rel="add">
  <description>add a new group to the system</description>
  <request>
    <http_method>POST</http_method>
    <headers>
      <header required="true">
        <name>Content-Type</name>
        <value>application/xml|json</value>
      </header>
      <header required="false">
        <name>Correlation-Id</name>
        <value>any string</value>
      </header>
    </headers>
    <body>
      <type>Group</type>
      <parameters_set>
        <description>add a new group to the system</description>
        <parameter required="true" type="xs:string">
          <name>group.name</name>
        </parameter>
      </parameters_set>
    </body>
  </request>
  <response>
    <type>Group</type>
  </response>
</link>
Comment 4 Juan Hernández 2015-02-05 14:21:30 UTC 
Please set a target release.
Comment 5 Ondra Machacek 2015-03-24 12:41:07 UTC 
What is the reason of have this in RHEV tracker and not have sdks there too?
REST will work without this patch anyway(afaik), sdks not.. ?

Also I think this should be ON_QA..
Comment 6 Oved Ourfali 2015-03-24 12:43:13 UTC 
Juan?

btw, I moved it to 3.5.3 because there were concerns about the ability to verify that in the near future.
Comment 7 Juan Hernández 2015-03-24 12:51:57 UTC 
I don't know why it is in the RHEV-M 3.5.1 tracker, I'm removing it.
Comment 8 Oved Ourfali 2015-03-24 12:53:54 UTC 
(In reply to Juan Hernández from comment #7)
> I don't know why it is in the RHEV-M 3.5.1 tracker, I'm removing it.

Do we have a CLI release with this change? If so, can you move it to ON_QA?
Comment 9 Juan Hernández 2015-03-24 13:03:11 UTC 
This isn't a CLI bug, but a engine bug. As ovirt-engine-3.5.2_rc2 is already available for testing and contains the fix we can move to ON_QA. 

[1] http://lists.ovirt.org/pipermail/devel/2015-March/010087.html - oVirt 3.5.2 Second Release Candidate is now available for testing
Comment 10 Ondra Machacek 2015-04-04 19:46:26 UTC 
# add user 
correlation_id  domain-id       domain-name     expect          namespace       principal       user_name
Comment 11 Eyal Edri 2015-04-29 06:17:16 UTC 
ovirt 3.5.2 was GA'd. closing current release.