Bug 1188576
| Summary: | Review Request: nodejs-create-class - A simple approach to create classes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | anish <apatil> |
| Component: | Package Review | Assignee: | Piotr Popieluch <piotr1212> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | anish.developer, apatil, package-review, piotr1212 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-14 13:36:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 956806 | ||
|
Description
anish
2015-02-03 09:52:24 UTC
please add BuildRequires: nodejs-packaging and rewrap the the description to 80 chars. Hi Piotr, Thank you for your comments, please find updated spec and SRPM Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-2.fc21.src.rpm username:anishpatil Hi Anish, Do you know why tests fail? is this a missing %nodejs_symlink_deps ? it fails that it can't find npm(inherits) ps. you should write BuildRequires: nodejs-inherits as BuildRequires: npm(inherits) Hi Piotr, Thank you for your comments, please find new spec and srpm on Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-3.fc21 fedora-review didn't pick up release 3 because of incorrect srpm url, fixed: Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-3.fc21.src.rpm Please add exclusivearch: https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#ExclusiveArch Hi Piotr, Thank you for your review comments, please find uodated files on Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-4.fc21.src.rpm please update to comply with github source guidelines: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github move license to %license https://fedorahosted.org/fpc/ticket/411 Hi Anish, any updates? This seems stalled, closing bug in one week. https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews closing. |