Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-1.fc21.src.rpm Description: Fedora Account System UA simple approach to create classes and it supports mixins, static methods, inheritance and property descriptors username:anishpatil
please add BuildRequires: nodejs-packaging and rewrap the the description to 80 chars.
Hi Piotr, Thank you for your comments, please find updated spec and SRPM Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-2.fc21.src.rpm username:anishpatil
Hi Anish, Do you know why tests fail? is this a missing %nodejs_symlink_deps ? it fails that it can't find npm(inherits) ps. you should write BuildRequires: nodejs-inherits as BuildRequires: npm(inherits)
Hi Piotr, Thank you for your comments, please find new spec and srpm on Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-3.fc21
fedora-review didn't pick up release 3 because of incorrect srpm url, fixed: Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-3.fc21.src.rpm
Please add exclusivearch: https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#ExclusiveArch
Hi Piotr, Thank you for your review comments, please find uodated files on Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-4.fc21.src.rpm
please update to comply with github source guidelines: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github move license to %license https://fedorahosted.org/fpc/ticket/411
Hi Anish, any updates?
This seems stalled, closing bug in one week. https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
closing.