Bug 1189385

Spec URL: https://anishpatil.fedorapeople.org/nodejs-line-reader.spec
SRPM URL: https://anishpatil.fedorapeople.org/nodejs-line-reader-0.2.4-2.fc21.src.rpm
Description: Nodejs line reader is asynchronous line-by-line file reader
Fedora Account System Username:anishpatil

Please move LICENSE from %doc to %license. 
You can omit test/ from %doc, not needed to include the tests as documentation.

looks good for the rest

install section is incorrect:

mkdir -p %{buildroot}%{nodejs_sitelib}/nodejs-line-reader
cp -rp package.json lib/ %{buildroot}%{nodejs_sitelib}/nodejs-line-reader

should be

mkdir -p %{buildroot}%{nodejs_sitelib}/line-reader
cp -rp package.json lib/ %{buildroot}%{nodejs_sitelib}/line-reader



Could you also please add:

# This macro is needed at the start for building on EL6
%{?nodejs_find_provides_and_requires}

at the beginning of the file so we can get this in epel6?

Hi Anish,

Could you please fix mentioned issues so I can approve the review?

I need this package as dependency for another pacakge. No response was given from the submitter for more than a month. This review seems stalled. If no response is given within one week I will close this bug and submit a review-request in my name (for which you can co-maintain if you like).

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews


PS. tests should be run with "mocha", you should change the test section from:
node test/line_reader.js
to:
moch test/line_reader.js
add:
BR npm(mocha)
and enable tests

Hi

Sorry for late response, i have moved recently to different city 
so could not respond on time, i will submit updated review in this weekend

no worries, just need this package myself.

I've updated the spec in the meantime, think this would do:

Spec URL: https://piotrp.fedorapeople.org/nodejs-line-reader.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-line-reader-0.2.4-3.fc22.src.rpm

Hi Piotr,

Thank you very much for your help. 

I have tested above spec file and changes looks fine to me 

rpmlint RPMS/noarch/nodejs-line-reader-0.2.4-3.fc22.noarch.rpm
nodejs-line-reader.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Ok, cool. APPROVED.

Please add me as co-maintainer.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 2 files have unknown license. Detailed
     output of licensecheck in /home/piotr/rpmbuild/1189385-nodejs-line-
     reader/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-line-reader-0.2.4-3.fc24.noarch.rpm
          nodejs-line-reader-0.2.4-3.fc24.src.rpm
nodejs-line-reader.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
nodejs-line-reader.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 1 warnings.



Requires
--------
nodejs-line-reader (rpmlib, GLIBC filtered):
    nodejs(engine)



Provides
--------
nodejs-line-reader:
    nodejs-line-reader
    npm(line-reader)



Source checksums
----------------
http://registry.npmjs.org/line-reader/-/line-reader-0.2.4.tgz :
  CHECKSUM(SHA256) this package     : efb22c7c098e2a5e5c67acd1b39ff1b8375fff9252701d5d6f2affdc40a044f2
  CHECKSUM(SHA256) upstream package : efb22c7c098e2a5e5c67acd1b39ff1b8375fff9252701d5d6f2affdc40a044f2


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1189385
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

New Package SCM Request
=======================
Package Name: nodejs-line-reader
Short Description: Asynchronous line-by-line file reader
Upstream URL: https://github.com/nickewing/line-reader
Owners: anishpatil,piotrp
Branches: f21 f22 f23 el6 epel7

Git done (by process-git-requests).

nodejs-line-reader-0.2.4-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-line-reader-0.2.4-3.el7

nodejs-line-reader-0.2.4-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/nodejs-line-reader-0.2.4-3.fc22

nodejs-line-reader-0.2.4-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-line-reader-0.2.4-3.fc21

nodejs-line-reader-0.2.4-3.el6.1 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/nodejs-line-reader-0.2.4-3.el6.1

nodejs-line-reader-0.2.4-3.fc22 has been pushed to the Fedora 22 stable repository.

nodejs-line-reader-0.2.4-3.el6.1 has been pushed to the Fedora EPEL 6 stable repository.

nodejs-line-reader-0.2.4-3.el7 has been pushed to the Fedora EPEL 7 stable repository.

nodejs-line-reader-0.2.4-3.fc21 has been pushed to the Fedora 21 stable repository.