Spec URL: https://piotrp.fedorapeople.org/elasticdump.spec SRPM URL: https://piotrp.fedorapeople.org/elasticdump-0.13.1-1.fc22.noarch.rpm Description: Import and export tools for elasticsearch Fedora Account System Username: piotrp
Spec URL: https://piotrp.fedorapeople.org/elasticdump.spec SRPM URL: https://piotrp.fedorapeople.org/elasticdump-0.13.1-1.fc22.src.rpm
Update to 0.14.1 Spec URL: https://piotrp.fedorapeople.org/elasticdump.spec SRPM URL: https://piotrp.fedorapeople.org/elasticdump-0.14.1-1.fc22.src.rpm
Update to 0.14.2 Spec URL: https://piotrp.fedorapeople.org/elasticdump.spec SRPM URL: https://piotrp.fedorapeople.org/elasticdump-0.14.2-1.fc22.src.rpm
Update to 0.14.3 Spec URL: https://piotrp.fedorapeople.org/elasticdump.spec SRPM URL: https://piotrp.fedorapeople.org/elasticdump-0.14.3-1.fc22.src.rpm
Issues: 1) The only concern is about naming this package. I see elasticdump.js is a library and elasticdump is a wrapper to use it. Node.js packaging naming guidelines says "The name of a Node.js extension/library package must start with nodejs- then the upstream name or name used in the npm registry." Should this be renamed to nodejs-elasticdump? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 9 files have unknown license. Detailed output of licensecheck in /home/parag/1231564-elasticdump/licensecheck.txt [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: elasticdump-0.14.3-1.fc24.noarch.rpm elasticdump-0.14.3-1.fc24.src.rpm elasticdump.noarch: W: spelling-error Summary(en_US) elasticsearch -> elastic search, elastic-search, elastically elasticdump.noarch: W: spelling-error %description -l en_US elasticsearch -> elastic search, elastic-search, elastically elasticdump.noarch: W: only-non-binary-in-usr-lib elasticdump.noarch: W: dangling-symlink /usr/lib/node_modules/elasticdump/node_modules/JSONStream /usr/lib/node_modules/JSONStream elasticdump.noarch: W: dangling-symlink /usr/lib/node_modules/elasticdump/node_modules/request /usr/lib/node_modules/request elasticdump.noarch: W: dangling-symlink /usr/lib/node_modules/elasticdump/node_modules/line-reader /usr/lib/node_modules/line-reader elasticdump.noarch: W: dangling-symlink /usr/lib/node_modules/elasticdump/node_modules/optimist /usr/lib/node_modules/optimist elasticdump.noarch: W: no-manual-page-for-binary multielasticdump elasticdump.src: W: spelling-error Summary(en_US) elasticsearch -> elastic search, elastic-search, elastically elasticdump.src: W: spelling-error %description -l en_US elasticsearch -> elastic search, elastic-search, elastically 2 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory elasticdump.noarch: W: invalid-url URL: https://github.com/taskrabbit/elasticsearch-dump <urlopen error [Errno -5] No address associated with hostname> elasticdump.noarch: W: only-non-binary-in-usr-lib elasticdump.noarch: W: dangling-symlink /usr/lib/node_modules/elasticdump/node_modules/line-reader /usr/lib/node_modules/line-reader elasticdump.noarch: W: dangling-symlink /usr/lib/node_modules/elasticdump/node_modules/JSONStream /usr/lib/node_modules/JSONStream elasticdump.noarch: W: dangling-symlink /usr/lib/node_modules/elasticdump/node_modules/request /usr/lib/node_modules/request elasticdump.noarch: W: dangling-symlink /usr/lib/node_modules/elasticdump/node_modules/optimist /usr/lib/node_modules/optimist elasticdump.noarch: W: no-manual-page-for-binary multielasticdump 1 packages and 0 specfiles checked; 0 errors, 7 warnings. Requires -------- elasticdump (rpmlib, GLIBC filtered): /usr/bin/env nodejs(engine) npm(JSONStream) npm(line-reader) npm(optimist) npm(request) Provides -------- elasticdump: elasticdump npm(elasticdump) Source checksums ---------------- https://registry.npmjs.org/elasticdump/-/elasticdump-0.14.3.tgz : CHECKSUM(SHA256) this package : 505ace3494354a3f22514319b92d5ec020c5c51f273fc7b52b43ceb559300a9a CHECKSUM(SHA256) upstream package : 505ace3494354a3f22514319b92d5ec020c5c51f273fc7b52b43ceb559300a9a
Thank you for review. elasticdumps intended usage is as a tool (for exporting/importing databases) not as a library. Therefore I think "elasticdump" suits better than "nodejs-elasticdump". In the nodejs guidelines: - Application packages that mainly provide tools (as opposed to libraries) that happen to be written for Node.js must follow the general naming guidelines instead.
(In reply to Piotr Popieluch from comment #6) > Thank you for review. > > elasticdumps intended usage is as a tool (for exporting/importing databases) > not as a library. Therefore I think "elasticdump" suits better than > "nodejs-elasticdump". > > In the nodejs guidelines: > - Application packages that mainly provide tools (as opposed to libraries) > that happen to be written for Node.js must follow the general naming > guidelines instead. umm.. Okay. I thought to give precedence to library naming rule, but I think we can also accept this with above tools rule. APPROVED.
Thank you New Package SCM Request ======================= Package Name: elasticdump Short Description: Import and export tools for elasticsearch Upstream URL: https://github.com/taskrabbit/elasticsearch-dump Owners: piotrp Branches: f21 f22 f23 el6 epel7
Git done (by process-git-requests).
elasticdump-0.14.3-1.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/elasticdump-0.14.3-1.fc23
elasticdump-0.14.3-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/elasticdump-0.14.3-1.fc22
elasticdump-0.14.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/elasticdump-0.14.3-1.el7
elasticdump-0.14.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/elasticdump-0.14.3-1.el6
elasticdump-0.14.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/elasticdump-0.14.3-1.fc21
elasticdump-0.14.3-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
elasticdump-0.14.3-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
elasticdump-0.14.3-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
elasticdump-0.14.3-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
elasticdump-0.14.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
elasticdump-0.14.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.