Bug 1190641

Summary: Apply/Cancel button stay grey when changing cpu threads in processor settings
Product: Red Hat Enterprise Linux 6 Reporter: Siteshwar Vashisht <svashisht>
Component: virt-managerAssignee: Giuseppe Scrivano <gscrivan>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 6.6CC: gscrivan, jherrman, juzhou, mzhan, ngalvin, rbalakri, svashisht, tzheng, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: virt-manager-0.9.0-29.el6 Doc Type: Bug Fix
Doc Text:
Prior to this update, when using the virt-manager GUI to change the number of CPU threads on the guest, the "Apply" and "Cancel" buttons incorrectly remained disabled. With this update, the signal and callback names in virt-manager have been corrected to properly parse changes to the cpu-thread, and the problem no longer occurs.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2015-07-22 07:06:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Use correct signal and callback names to catch cpu-threads property changes none

Description Siteshwar Vashisht 2015-02-09 10:33:04 UTC 
Description of problem:
Apply/Cancel button stay grey when changing number of cpu threads in processor settings

Version-Release number of selected component (if applicable):
virt-manager-0.9.0-28

How reproducible:
Always

Steps to Reproduce:
1. Click on 'Show virtual hardware details' in vm window
2. Go to processor tab, select topology and manually set cpu topology.
3. Change number of threads.

Actual results:
Apply/Cancel button remain disabled.

Expected results:
Apply/Cancel button should be enabled.
Comment 1 Siteshwar Vashisht 2015-02-09 10:35:50 UTC 
Created attachment 989635 [details]
Use correct signal and callback names to catch cpu-threads  property changes
Comment 2 tingting zheng 2015-02-10 09:01:24 UTC 
Tested with:
virt-manager-0.9.0-28.el6.x86_64

Steps:
1. Prepare a guest,Click on 'Show virtual hardware details' in vm window
2. Go to processor tab, select topology and manually set cpu topology.
3. Change number of threads.

Apply/Cancel button is enabled and I can set the above configurations successfully,is there anything else I've missed?
Comment 3 Siteshwar Vashisht 2015-02-10 09:13:17 UTC 
Sorry for not making the steps clear :

Steps to Reproduce:
1. Click on 'Show virtual hardware details' in vm window
2. Go to processor tab, select topology and manually set cpu topology.
3. Click on Apply button, this should disable Apply and Cancel buttons.
3. Change number of threads.

Actual results:
Apply/Cancel button remain disabled.

Expected results:
Apply/Cancel button should be enabled.
Comment 4 tingting zheng 2015-02-10 09:29:12 UTC 
(In reply to Siteshwar Vashisht from comment #3)
> Sorry for not making the steps clear :
> 
> Steps to Reproduce:
> 1. Click on 'Show virtual hardware details' in vm window
> 2. Go to processor tab, select topology and manually set cpu topology.
> 3. Click on Apply button, this should disable Apply and Cancel buttons.
> 3. Change number of threads.
> 
> Actual results:
> Apply/Cancel button remain disabled.
> 
> Expected results:
> Apply/Cancel button should be enabled.

Following your steps I can reproduce it,the bug can also be reproduced on rhel6 not on rhel7.
Comment 8 Xiaodai Wang 2015-02-28 09:05:18 UTC 
I can reproduce this bug with virt-manager-0.9.0-28.

# rpm -qa virt-manager
virt-manager-0.9.0-28.el6.x86_64

steps:
1. Launch virt-manager: #virt-manager
2. Open a guest and click on 'Show virtual hardware details' in vm window
3. Go to processor tab, select topology and manually set cpu topology.
4. Click on Apply button and the Apply and Cancel buttons are disabled.
5. Change number of threads, the Apply and Cancel buttons are still disabled.

Verified this issue with new build: virt-manager-0.9.0-29.el6.x86_64.rpm

Steps:
1. Update virt-manager to the latest version.
#rpm -U virt-manager-0.9.0-29.el6.x86_64.rpm
2. Check the version of virt-manager
#rpm -qa virt-manager
virt-manager-0.9.0-29.el6.x86_64
3. Launch virt-manager: #virt-manager
4. Open a guest and click on 'Show virtual hardware details' in vm window
5. Go to processor tab, select topology and manually set cpu topology.
6. Click on Apply button and the Apply and Cancel buttons are disabled.
7. Change number of threads, the Apply and Cancel buttons are enabled.

This issue is fixed in virt-manager-0.9.0-29.el6.x86_64,I will move the bug to VERIFIED.
Comment 10 errata-xmlrpc 2015-07-22 07:06:53 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1373.html