Bug 1191486

Summary:	daemons abstraction & refactoring
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, kaushal, kparthas, rcyriac
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1223083 (view as bug list)		Environment:
Last Closed:	2015-05-14 17:29:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1223083

Description Atin Mukherjee 2015-02-11 11:41:58 UTC

Description of problem:
Currently, the daemon management code is fragmented and this bug is to address following things:

- Provide an abstract data type that encapsulates what is common among daemons
  that are managed by glusterd.

- 'Port' existing code to make use of the abstract type. This would help in
  making this change self-documented to an extent.

- Prescribe a way to maintain per-feature daemon code separate to glusterd's
  common code.

Comment 1 Anand Avati 2015-02-11 11:42:41 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#18) for review on master by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2015-02-11 11:44:18 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#19) for review on master by Atin Mukherjee (amukherj)

Comment 3 Anand Avati 2015-02-11 12:14:57 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#20) for review on master by Atin Mukherjee (amukherj)

Comment 4 Anand Avati 2015-02-12 11:08:30 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#21) for review on master by Atin Mukherjee (amukherj)

Comment 5 Anand Avati 2015-02-12 12:59:13 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#22) for review on master by Atin Mukherjee (amukherj)

Comment 6 Anand Avati 2015-02-13 07:17:39 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#23) for review on master by Atin Mukherjee (amukherj)

Comment 7 Anand Avati 2015-02-13 10:28:45 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#24) for review on master by Atin Mukherjee (amukherj)

Comment 8 Anand Avati 2015-02-19 09:14:57 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#25) for review on master by Atin Mukherjee (amukherj)

Comment 9 Anand Avati 2015-02-19 09:48:51 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#26) for review on master by Atin Mukherjee (amukherj)

Comment 10 Anand Avati 2015-02-19 10:34:25 UTC

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#27) for review on master by Atin Mukherjee (amukherj)

Comment 11 Anand Avati 2015-02-20 12:04:17 UTC

COMMIT: http://review.gluster.org/9428 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 9d842f965655bf70c643b4541844e83bc4e74190
Author: Atin Mukherjee <amukherj>
Date:   Wed Feb 11 17:13:45 2015 +0530

    glusterd: nfs,shd,quotad,snapd daemons refactoring
    
    This patch ports nfs, shd, quotad & snapd with the approach suggested in
    http://www.gluster.org/pipermail/gluster-devel/2014-December/043180.html
    
    Change-Id: I4ea5b38793f87fc85cc9d2cf873727351dedffd2
    BUG: 1191486
    Signed-off-by: Atin Mukherjee <amukherj>
    Signed-off-by:  Krishnan Parthasarathi <kparthas>
    Reviewed-on: http://review.gluster.org/9428
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Nekkunti <anekkunt>

Comment 12 Anand Avati 2015-02-24 09:55:35 UTC

REVIEW: http://review.gluster.org/9732 (glusterd: add list of services abstraction for daemons) posted (#1) for review on master by Krishnan Parthasarathi (kparthas)

Comment 13 Anand Avati 2015-05-05 13:42:51 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting daemon svc objects as array of objects .) posted (#1) for review on master by Anand Nekkunti (anekkunt)

Comment 14 Anand Avati 2015-05-06 14:03:53 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting daemon svc objects as array of objects .) posted (#3) for review on master by Anand Nekkunti (anekkunt)

Comment 15 Anand Avati 2015-05-07 05:39:02 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#4) for review on master by Anand Nekkunti (anekkunt)

Comment 16 Anand Avati 2015-05-07 09:27:52 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#5) for review on master by Anand Nekkunti (anekkunt)

Comment 17 Anand Avati 2015-05-09 17:27:25 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#7) for review on master by Anand Nekkunti (anekkunt)

Comment 18 Anand Avati 2015-05-11 09:51:56 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#8) for review on master by Anand Nekkunti (anekkunt)

Comment 19 Anand Avati 2015-05-12 10:43:21 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#9) for review on master by Anand Nekkunti (anekkunt)

Comment 20 Anand Avati 2015-05-14 11:15:08 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#10) for review on master by Anand Nekkunti (anekkunt)

Comment 21 Niels de Vos 2015-05-14 17:29:08 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 22 Niels de Vos 2015-05-14 17:35:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 23 Niels de Vos 2015-05-14 17:38:12 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 24 Niels de Vos 2015-05-14 17:45:59 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 25 Anand Avati 2015-05-14 19:12:27 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#11) for review on master by Anand Nekkunti (anekkunt)

Comment 26 Anand Avati 2015-05-29 09:49:32 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#12) for review on master by Anand Nekkunti (anekkunt)

Comment 27 Anand Avati 2015-05-30 04:24:46 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#13) for review on master by Anand Nekkunti (anekkunt)

Comment 28 Anand Avati 2015-06-01 06:16:44 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#14) for review on master by Anand Nekkunti (anekkunt)

Comment 29 Anand Avati 2015-06-15 10:52:52 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#15) for review on master by Anand Nekkunti (anekkunt)

Comment 30 Anand Avati 2015-06-19 14:45:06 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#16) for review on master by Anand Nekkunti (anekkunt)

Comment 31 Anand Avati 2015-06-21 15:07:19 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#17) for review on master by Anand Nekkunti (anekkunt)

Comment 32 Anand Avati 2015-06-30 13:19:09 UTC

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#18) for review on master by Anand Nekkunti (anekkunt)