Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1223083

Summary: daemons abstraction & refactoring
Product: [Community] GlusterFS Reporter: Gaurav Kumar Garg <ggarg>
Component: glusterdAssignee: Satish Mohan <smohan>
Status: CLOSED WONTFIX QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: mainlineCC: amukherj, bugs, kaushal, rcyriac, smohan
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1191486 Environment:
Last Closed: 2017-08-08 15:25:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1191486    
Bug Blocks:    

Description Gaurav Kumar Garg 2015-05-19 18:46:33 UTC
+++ This bug was initially created as a clone of Bug #1191486 +++

Description of problem:
Currently, the daemon management code is fragmented and this bug is to address following things:

- Provide an abstract data type that encapsulates what is common among daemons
  that are managed by glusterd.

- 'Port' existing code to make use of the abstract type. This would help in
  making this change self-documented to an extent.

- Prescribe a way to maintain per-feature daemon code separate to glusterd's
  common code.

the approach suggested in
    http://www.gluster.org/pipermail/gluster-devel/2014-December/043180.html

--- Additional comment from Anand Avati on 2015-02-11 06:42:41 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#18) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-11 06:44:18 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#19) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-11 07:14:57 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#20) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-12 06:08:30 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#21) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-12 07:59:13 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#22) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-13 02:17:39 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#23) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-13 05:28:45 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#24) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-19 04:14:57 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#25) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-19 04:48:51 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#26) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-19 05:34:25 EST ---

REVIEW: http://review.gluster.org/9428 (glusterd: nfs,shd,quotad,snapd daemons refactoring) posted (#27) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-02-20 07:04:17 EST ---

COMMIT: http://review.gluster.org/9428 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 9d842f965655bf70c643b4541844e83bc4e74190
Author: Atin Mukherjee <amukherj>
Date:   Wed Feb 11 17:13:45 2015 +0530

    glusterd: nfs,shd,quotad,snapd daemons refactoring
    
    This patch ports nfs, shd, quotad & snapd with the approach suggested in
    http://www.gluster.org/pipermail/gluster-devel/2014-December/043180.html
    
    Change-Id: I4ea5b38793f87fc85cc9d2cf873727351dedffd2
    BUG: 1191486
    Signed-off-by: Atin Mukherjee <amukherj>
    Signed-off-by:  Krishnan Parthasarathi <kparthas>
    Reviewed-on: http://review.gluster.org/9428
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Nekkunti <anekkunt>

--- Additional comment from Anand Avati on 2015-02-24 04:55:35 EST ---

REVIEW: http://review.gluster.org/9732 (glusterd: add list of services abstraction for daemons) posted (#1) for review on master by Krishnan Parthasarathi (kparthas)

--- Additional comment from Anand Avati on 2015-05-05 09:42:51 EDT ---

REVIEW: http://review.gluster.org/10586 (glusterd : Converting daemon svc objects as array of objects .) posted (#1) for review on master by Anand Nekkunti (anekkunt)

--- Additional comment from Anand Avati on 2015-05-06 10:03:53 EDT ---

REVIEW: http://review.gluster.org/10586 (glusterd : Converting daemon svc objects as array of objects .) posted (#3) for review on master by Anand Nekkunti (anekkunt)

--- Additional comment from Anand Avati on 2015-05-07 01:39:02 EDT ---

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#4) for review on master by Anand Nekkunti (anekkunt)

--- Additional comment from Anand Avati on 2015-05-07 05:27:52 EDT ---

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#5) for review on master by Anand Nekkunti (anekkunt)

--- Additional comment from Anand Avati on 2015-05-09 13:27:25 EDT ---

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#7) for review on master by Anand Nekkunti (anekkunt)

--- Additional comment from Anand Avati on 2015-05-11 05:51:56 EDT ---

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#8) for review on master by Anand Nekkunti (anekkunt)

--- Additional comment from Anand Avati on 2015-05-12 06:43:21 EDT ---

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#9) for review on master by Anand Nekkunti (anekkunt)

--- Additional comment from Anand Avati on 2015-05-14 07:15:08 EDT ---

REVIEW: http://review.gluster.org/10586 (glusterd : Converting all daemon svc objects to array of svc objects .) posted (#10) for review on master by Anand Nekkunti (anekkunt)

Comment 1 Anand Avati 2015-05-19 18:54:45 UTC
REVIEW: http://review.gluster.org/10835 (glusterd: snapd daemon refactoring) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2015-05-20 02:07:36 UTC
REVIEW: http://review.gluster.org/10835 (glusterd: snapd daemon refactoring) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2015-05-30 11:08:08 UTC
REVIEW: http://review.gluster.org/10835 (glusterd: snapd daemon refactoring) posted (#3) for review on master by Niels de Vos (ndevos)

Comment 4 Mike McCune 2016-03-28 22:38:41 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 7 Atin Mukherjee 2017-08-08 15:25:56 UTC
With GlusterD 2.0 around the corner we don't have plan to port the per volume daemon services into the svc framework. Closing this bug.