Bug 1193207

Summary:	Review Request: maven-scr-plugin - Maven tool to ease the development of OSGi components and services
Product:	[Fedora] Fedora	Reporter:	gil cattaneo <puntogil>
Component:	Package Review	Assignee:	Severin Gehwolf <sgehwolf>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jkang, package-review, sgehwolf
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-11 16:53:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description gil cattaneo 2015-02-16 21:08:17 UTC

Spec URL: https://gil.fedorapeople.org/maven-scr-plugin.spec
SRPM URL: https://gil.fedorapeople.org/maven-scr-plugin-1.20.0-1.fc20.src.rpm
Description:
Maven plugin for generating OSGi service descriptors based on annotations.
Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8954568

Comment 1 Severin Gehwolf 2015-06-11 12:49:00 UTC

This fails to build for me with:
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /builddir/build/BUILD/maven-scr-plugin-1.20.0/src/main/java/org/apache/felix/scrplugin/mojo/SCRDescriptorMojo.java:[220,16] cannot find symbol
  symbol:   method setSkipVolatileCheck(boolean)
  location: variable options of type org.apache.felix.scrplugin.Options

Does it depend on felix-scr perhaps (bug 1197037)?

Comment 2 gil cattaneo 2015-06-11 13:30:05 UTC

(In reply to Severin Gehwolf from comment #1)
> This fails to build for me with:
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR]
> /builddir/build/BUILD/maven-scr-plugin-1.20.0/src/main/java/org/apache/felix/
> scrplugin/mojo/SCRDescriptorMojo.java:[220,16] cannot find symbol
>   symbol:   method setSkipVolatileCheck(boolean)
>   location: variable options of type org.apache.felix.scrplugin.Options
> 
> Does it depend on felix-scr perhaps (bug 1197037)?

No, this plugin use felix-scr-generator 1.12.0

Comment 3 gil cattaneo 2015-06-11 13:33:38 UTC

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10018404

Comment 4 Jie Kang 2015-06-11 15:06:54 UTC

Hello. I have been working on packaging this for Fedora as well. Gil, do you mind if I take over as reviewee?

Fedora Account System Username: jkang
Spec URL: https://jkang.fedorapeople.org/maven-scr-plugin.spec
SRPM URL: https://jkang.fedorapeople.org/maven-scr-plugin-1.21.0-1.fc21.src.rpm
Description: Maven plugin for generating OSGi Declarative Services annotations

Comment 5 Severin Gehwolf 2015-06-11 15:24:52 UTC

I'll do the review for this one.

Comment 6 gil cattaneo 2015-06-11 16:15:22 UTC

Please, remove:
BuildRequires:	javapackages-tools
BuildRequires:  java-devel >= 1:1.8.0
Requires:       objectweb-asm
Requires:       felix-osgi-core
Requires:       felix-osgi-compendium

and use http://www.apache.org/dist/felix/maven-scr-plugin-1.21.0-source-release.tar.gz

install with license macro LICENSE NOTICE files for each packages
install with doc macro changelog.txt

can open a new issues?

Comment 7 gil cattaneo 2015-06-11 16:32:40 UTC

Ops, are you in the packager group?
if no see:
https://fedoraproject.org/wiki/Package_Review_Process
i'm not a proven packager i cant help, sorry

Comment 8 Jie Kang 2015-06-11 16:38:07 UTC

Hi,

I opened a new bug: https://bugzilla.redhat.com/show_bug.cgi?id=1230874

I have also made the changes and re-uploaded the spec and srpm. Thanks for your help!

Comment 9 gil cattaneo 2015-06-11 16:53:48 UTC


*** This bug has been marked as a duplicate of bug 1230874 ***