(In reply to gil cattaneo from comment #0)
> Spec URL: https://gil.fedorapeople.org/felix-scr.spec

I get a 404 when trying to access this spec.

(In reply to Severin Gehwolf from comment #1)
> (In reply to gil cattaneo from comment #0)
> > Spec URL: https://gil.fedorapeople.org/felix-scr.spec
> 
> I get a 404 when trying to access this spec.

Yes, I know, I'm sorry. for now I'm not interested in doing so review.
i have other open bugs with major priority.
Thanks!

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10018502

Hello. I have been working on packaging this for Fedora as well. Gil, do you mind if I take over as reviewee?

Fedora Account System Username: jkang
Spec URL: https://jkang.fedorapeople.org/felix-scr.spec
SRPM URL: https://jkang.fedorapeople.org/felix-scr-1.8.2-1.fc21.src.rpm
Description: Apache Felix Service Component Runtime implementation of OSGi Declarative Services Specification

can you open a new one bug?

and please remove unneeded:
BuildRequires:	javapackages-tools
BuildRequires:  java-devel >= 1:1.8.0
Requires:       java-headless >= 1:1.8.0

and use http://www.apache.org/dist/felix/org.apache.felix.scr-1.8.2-source-release.tar.gz

install with license macro LICENSE NOTICE files for each packages
install with doc macro changelog.txt

you must be sure that the system libraries are not copied in the archive JAR

use:
%pom_xpath_remove "pom:plugin[pom:artifactId='maven-bundle-plugin']/pom:configuration/pom:instructions/pom:Private-Package"
%pom_xpath_remove "pom:plugin[pom:artifactId='maven-bundle-plugin']/pom:configuration/pom:instructions/pom:Embed-Dependency"
%pom_xpath_remove "pom:plugin[pom:artifactId='maven-bundle-plugin']/pom:configuration/pom:instructions/pom:Export-Package"
%pom_xpath_inject "pom:plugin[pom:artifactId='maven-bundle-plugin']/pom:configuration/pom:instructions" '
<Export-Package>
    org.apache.felix.scr;version=1.8,
    org.apache.felix.scr.component;version=1.0;
        mandatory:="status"; status="provisional"
</Export-Package>'
%pom_xpath_remove "pom:plugin[pom:artifactId='maven-bundle-plugin']/pom:configuration/pom:instructions/pom:Import-Package"
%pom_xpath_inject "pom:plugin[pom:artifactId='maven-bundle-plugin']/pom:configuration/pom:instructions" '
<Import-Package>
    org.apache.felix.service.command;resolution:=optional,
    org.apache.felix.shell;provide:=true;resolution:=optional,
    org.osgi.framework;version="[1.4,2)",
    org.osgi.service.cm;version="[1.2,2)";resolution:=optional,
    org.osgi.service.log;version="[1.3,2)";resolution:=optional,
    org.osgi.service.metatype;version="[1.1,2)";resolution:=optional,
    org.osgi.service.packageadmin;version="[1.2,2)";resolution:=optional,
    org.osgi.service.component;provide:=true,
    org.apache.felix.scr;provide:=true,
    org.kxml2.io, org.osgi.util.tracker, org.xmlpull.v1
</Import-Package>'

Hi,

I opened a new bug: https://bugzilla.redhat.com/show_bug.cgi?id=1230867

I am also in the process of making the changes to the spec file. Thank you for your help!

(In reply to Jie Kang from comment #10)
> Hi,
> 
> I opened a new bug: https://bugzilla.redhat.com/show_bug.cgi?id=1230867
> 
> I am also in the process of making the changes to the spec file. Thank you
> for your help!

Ops, are you in the packager group?
if no see:
https://fedoraproject.org/wiki/Package_Review_Process
i'm not a proven packager i cant help, sorry

(In reply to gil cattaneo from comment #11)
> (In reply to Jie Kang from comment #10)
> > Hi,
> > 
> > I opened a new bug: https://bugzilla.redhat.com/show_bug.cgi?id=1230867
> > 
> > I am also in the process of making the changes to the spec file. Thank you
> > for your help!
> 
> Ops, are you in the packager group?
> if no see:
> https://fedoraproject.org/wiki/Package_Review_Process

Ah, I am not in the group so I would need to find a sponsor. I think Severin can help here?

> i'm not a proven packager i cant help, sorry

It's okay; Thank you still for help with the spec file. I am new to packaging things so I appreciate it!

*** This bug has been marked as a duplicate of bug 1230867 ***

(In reply to Jie Kang from comment #12)
> (In reply to gil cattaneo from comment #11)
> > (In reply to Jie Kang from comment #10)
> > > Hi,
> > > 
> > > I opened a new bug: https://bugzilla.redhat.com/show_bug.cgi?id=1230867
> > > 
> > > I am also in the process of making the changes to the spec file. Thank you
> > > for your help!
> > 
> > Ops, are you in the packager group?
> > if no see:
> > https://fedoraproject.org/wiki/Package_Review_Process
> 
> Ah, I am not in the group so I would need to find a sponsor. I think Severin
> can help here?
> 
> > i'm not a proven packager i cant help, sorry
> 
> It's okay; Thank you still for help with the spec file. I am new to
> packaging things so I appreciate it!

I don't think one needs to be provenpackager for sponsoring someone[1]. But yes, Jie will need a sponsor. I'll do the review on the new bug and then we go from there.

[1] https://fedoraproject.org/wiki/How_to_sponsor_a_new_contributor