Bug 1193929
| Summary: | GlusterFS can be improved | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Jeff Darcy <jdarcy> | |
| Component: | unclassified | Assignee: | bugs <bugs> | |
| Status: | CLOSED UPSTREAM | QA Contact: | ||
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | bugs, pasik, resultadodeltris, srangana | |
| Target Milestone: | --- | Keywords: | Improvement, Reopened, Tracking, Triaged | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1576814 1629877 1679998 (view as bug list) | Environment: | ||
| Last Closed: | 2025-02-10 03:44:05 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1576814, 1576815, 1576816 | |||
|
Description
Jeff Darcy
2015-02-18 15:06:47 UTC
REVIEW: http://review.gluster.org/14638 (tier: Suppress warning when tiering is disabled) posted (#2) for review on master by Prashanth Pai (ppai) REVIEW: http://review.gluster.org/14638 (tier: Suppress warning when tiering is disabled) posted (#3) for review on master by Prashanth Pai (ppai) REVIEW: http://review.gluster.org/11922 (README: improve readability and add a clickable link) posted (#5) for review on master by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/14638 committed in master by Jeff Darcy (jdarcy) ------ commit 98280290cd4a483f72c8c4d614eb826117383e1d Author: Prashanth Pai <ppai> Date: Mon May 30 11:56:17 2016 +0530 tier: Suppress warning when tiering is disabled Suppress -Wunused-function compile time warnings when tiering is disabled with --disable-tiering. BUG: 1193929 Change-Id: I396e03631606ce60a953ed5e124986ae2c803abd Signed-off-by: Prashanth Pai <ppai> Reviewed-on: http://review.gluster.org/14638 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> Tested-by: Gluster Build System <jenkins.org> COMMIT: http://review.gluster.org/11922 committed in master by Jeff Darcy (jdarcy) ------ commit dbc8dac5c357a28aeba17894f8b02faa2af2a792 Author: Niels de Vos <ndevos> Date: Fri Aug 14 11:13:54 2015 +0200 README: improve readability and add a clickable link It is easier to have a link that can be clicked. Change-Id: Id0f75b3e68ca358c218e7f1f00769545dab0c058 BUG: 1193929 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/11922 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> REVIEW: https://review.gluster.org/16200 (glusterd: Propagate EADDRINUSE correctly to parent process) posted (#6) for review on master by Prashanth Pai (ppai) COMMIT: https://review.gluster.org/16200 committed in master by Atin Mukherjee (amukherj) ------ commit 94afe2ca98a8ed9effb05901fc89d3b7bb6d0d41 Author: Prashanth Pai <ppai> Date: Mon Dec 19 16:28:06 2016 +0530 glusterd: Propagate EADDRINUSE correctly to parent process exit()/_exit(): Only the least significant 8 bits i.e (err & 255) shall be available to the waiting parent process on calling _exit() or exit() with an integer exit status. If this number is negative, the parent process doesn't readily get what it's really looking forward to handle. For example: EADDRINUSE is 98 and if exit status code is set to -98, the waiting parent process shall get 158 (= -98 & 255) as exit status. BUG: 1193929 Change-Id: Idc6b0f40c2332e087e584b4b40cbf0d29168c9cd Signed-off-by: Prashanth Pai <ppai> Reviewed-on: https://review.gluster.org/16200 NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> REVIEW: https://review.gluster.org/17129 (glusterd: Fix removing pmap entry on rpc disconnect) posted (#1) for review on master by Prashanth Pai (ppai) REVIEW: https://review.gluster.org/17129 (glusterd: Fix removing pmap entry on rpc disconnect) posted (#2) for review on master by Prashanth Pai (ppai) COMMIT: https://review.gluster.org/17129 committed in master by Jeff Darcy (jeff.us) ------ commit 081f9febeec61787ebe81850a081beda17de3047 Author: Prashanth Pai <ppai> Date: Thu Apr 27 18:26:02 2017 +0530 glusterd: Fix removing pmap entry on rpc disconnect Problem: The following line of code intended to remove pmap entry for the connection during disconnects: pmap_registry_remove (this, 0, NULL, GF_PMAP_PORT_NONE, xprt); However, no pmap entry will have it's type set to GF_PMAP_PORT_NONE at any point in time. So a call to pmap_registry_search_by_xprt() in pmap_registry_remove() will always fail to find a match. Fix: Optionally ignore pmap entry's type in pmap_registry_search_by_xprt(). BUG: 1193929 Change-Id: I705f101739ab1647ff52a92820d478354407264a Signed-off-by: Prashanth Pai <ppai> Reviewed-on: https://review.gluster.org/17129 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jeff.us> REVIEW: https://review.gluster.org/17659 (Link against missed libraries to resolve symbols) posted (#1) for review on master by Prashanth Pai (ppai) REVIEW: https://review.gluster.org/17659 (Link against missed libraries to resolve symbols) posted (#2) for review on master by Prashanth Pai (ppai) COMMIT: https://review.gluster.org/17659 committed in master by Jeff Darcy (jeff.us) ------ commit 97a08698058962a4ddc783008c92ee94f08740a9 Author: Prashanth Pai <ppai> Date: Fri Jun 30 15:52:53 2017 +0530 Link against missed libraries to resolve symbols When external programs perform a dlopen("..so", RTLD_LAZY|RTLD_LOCAL) on some shared objects like xlators, it can fail with dlerror set to error string "undefined symbol <some-type>". This was observed for the following shared objects: fuse.so, quota.so, quotad.so, server.so, libgfrpc.so and socket.so P.S: This was found while running a go program which fetches the list of xlator options (volume_option_t) from xlator's shared object. BUG: 1193929 Change-Id: I7b958409cf11fb67c2be32a3f85a96fb1260236b Signed-off-by: Prashanth Pai <ppai> Reviewed-on: https://review.gluster.org/17659 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> CentOS-regression: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Jeff Darcy <jeff.us> REVIEW: https://review.gluster.org/17753 (socket: avoid calling GF_CALLOC() in init_openssl_mt()) posted (#1) for review on master by Prashanth Pai (ppai) REVIEW: https://review.gluster.org/17753 (socket: avoid calling GF_CALLOC() in init_openssl_mt()) posted (#2) for review on master by Prashanth Pai (ppai) REVIEW: https://review.gluster.org/17753 (socket: call init_openssl_mt() in init() and add cleanup) posted (#3) for review on master by Prashanth Pai (ppai) REVIEW: https://review.gluster.org/17753 (socket: call init_openssl_mt() in init() and add cleanup) posted (#4) for review on master by Prashanth Pai (ppai) COMMIT: https://review.gluster.org/17753 committed in master by Jeff Darcy (jeff.us) ------ commit 58a15ae04e597d6ab353f00a3ee72260c0b6f802 Author: Prashanth Pai <ppai> Date: Wed Jul 12 12:59:35 2017 +0530 socket: call init_openssl_mt() in init() and add cleanup init_openssl_mt() wasn't explicitly invoked and was run implicitly before dlopen() returned as it was tagged as __attribute__ ((constructor)). This function used to call GF_CALLOC() which wasn't available or initialized when socket.so is dlopen()ed by an external program. The program used to crash with SIGSEGV as follows: 0x00007ffff5efe1ad in __gf_calloc (nmemb=41, size=40, type=158, typestr=0x7ffff63eb3d6 "gf_sock_mt_lock_array") at mem-pool.c:109 0x00007ffff63e6acf in init_openssl_mt () at socket.c:4016 0x00007ffff7de90da in call_init.part () from /lib64/ld-linux-x86-64.so.2 0x00007ffff7de91eb in _dl_init () from /lib64/ld-linux-x86-64.so.2 0x00007ffff7dedde1 in dl_open_worker () from /lib64/ld-linux-x86-64.so.2 0x00007ffff7de8f84 in _dl_catch_error () from /lib64/ld-linux-x86-64.so.2 0x00007ffff7ded339 in _dl_open () from /lib64/ld-linux-x86-64.so.2 This change moves call to init_openssl_mt() from being a constructor function to the init() function and introduces fini_openssl_mt() which cleans up resources (called in destructor). BUG: 1193929 Change-Id: Iab690897ec34e24c33f6b43f8d8d9f8fd75ac607 Signed-off-by: Prashanth Pai <ppai> Reviewed-on: https://review.gluster.org/17753 Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> Reviewed-by: Jeff Darcy <jeff.us> REVIEW: https://review.gluster.org/17848 (rpc: prevent logging null client [Invalid argument]) posted (#1) for review on master by Prashanth Pai (ppai) REVIEW: https://review.gluster.org/17848 (rpc: prevent logging null client [Invalid argument]) posted (#2) for review on master by Prashanth Pai (ppai) REVIEW: https://review.gluster.org/17848 (rpc: prevent logging null client [Invalid argument]) posted (#3) for review on master by Prashanth Pai (ppai) COMMIT: https://review.gluster.org/17848 committed in master by Jeff Darcy (jeff.us) ------ commit 7140858c3816c89d22d81ddfaa1d270db5dfd622 Author: Prashanth Pai <ppai> Date: Fri Jul 21 15:48:23 2017 +0530 rpc: prevent logging null client [Invalid argument] The following log entry is observed during volume operations such as volume create: [2017-07-20 05:13:43.213797] E [client_t.c:321:gf_client_ref] (-->/usr/local/lib/libgfrpc.so.0(rpcsvc_request_create+0x1a4) [0x7f987f66cd20] -->/usr/local/lib/libgfrpc.so.0(rpcsvc_request_init+0xd0) [0x7f987f66ca23] -->/usr/local/lib/libglusterfs.so.0(gf_client_ref+0x56) [0x7f987f91cbd5] ) 0-client_t: null client [Invalid argument] Change-Id: I49ba753e8d1a828bb275b0ccb1a181706774f387 BUG: 1193929 Signed-off-by: Prashanth Pai <ppai> Reviewed-on: https://review.gluster.org/17848 Reviewed-by: Raghavendra G <rgowdapp> Reviewed-by: Amar Tumballi <amarts> Tested-by: Amar Tumballi <amarts> Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> REVIEW: https://review.gluster.org/18535 (worm/read-only: Add sentinel NULL key to options) posted (#1) for review on master by Prashanth Pai (ppai) COMMIT: https://review.gluster.org/18535 committed in master by Prashanth Pai (ppai) ------ commit 4f3c680ed8350496e18de127064be816388dafdd Author: Prashanth Pai <ppai> Date: Tue Oct 17 10:57:13 2017 +0530 worm/read-only: Add sentinel NULL key to options BUG: 1193929 Change-Id: Ibfee382362826556e2e760f9b946c83445d6a08e Signed-off-by: Prashanth Pai <ppai> REVIEW: https://review.gluster.org/19056 (Use RTLD_LOCAL for symbol resolution) posted (#3) for review on master by Prashanth Pai COMMIT: https://review.gluster.org/19056 committed in master by \"Prashanth Pai\" <ppai> with a commit message- Use RTLD_LOCAL for symbol resolution RTLD_LOCAL is the default value for symbol visibility flag of dlopen() in Linux and NetBSD. Using it avoids conflicts during symbol resolution. This also allows us to detect xlators that have not been explicitly linked with libraries that they use. This used to go unnoticed when RTLD_GLOBAL was being used. BUG: 1193929 Change-Id: I50db6ea14ffdee96596060c4d6bf71cd3c432f7b Signed-off-by: Prashanth Pai <ppai> REVIEW: https://review.gluster.org/19339 (libglusterfs: cleanup useless need_lookup) posted (#3) for review on master by Niels de Vos REVIEW: https://review.gluster.org/19517 (log: Change some frequent log entries to DEBUG) posted (#1) for review on master by Prashanth Pai This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report. glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html [2] https://www.gluster.org/pipermail/gluster-users/ Reopening, inadvertently closed. REVIEW: https://review.gluster.org/19824 (doc: Update the admin guide link) posted (#2) for review on master by Varsha Rao COMMIT: https://review.gluster.org/19824 committed in master by "Amar Tumballi" <amarts> with a commit message- doc: Update the admin guide link Update the existing admin guide link as it is incorrect. Change-Id: I05669192623aeac287dfa9002caa0f390ea79499 Updates: bz#1193929 Signed-off-by: Varsha Rao <varao> REVIEW: https://review.gluster.org/19882 (Add CLI option to print XLATORDIR) posted (#1) for review on master by Prashanth Pai COMMIT: https://review.gluster.org/19882 committed in master by "Atin Mukherjee" <amukherj> with a commit message- Add CLI option to print XLATORDIR glusterfs gets the path to xlator dir from a compile time flag named XLATORDIR which gets passed through a -D flag to GCC. This path is used to find and load xlator shared objects. The XLATORDIR path isn't easily accessible to glusterd2. Glusterd2 currently uses the following command (hack) to get value of XLATORDIR: $ strings -d `which glusterfsd` | awk '/glusterfs/*/xlator$/' This change introduces "print-xlatordir" CLI option to expose XLATORDIR. The option is intentionally not documented. Updates: bz#1193929 Change-Id: Ic7247457600f11cd8d68eb3d0ad2526fdfda0b02 Signed-off-by: Prashanth Pai <ppai> REVIEW: https://review.gluster.org/19905 (Make glusterfsd binary print statedump & xlator dir) posted (#1) for review on master by Prashanth Pai COMMIT: https://review.gluster.org/19905 committed in master by "Prashanth Pai" <ppai> with a commit message- Make glusterfsd binary print statedump & xlator dir The glusterd2 needs following options, some of which are provided by gluster CLI today: --print-xlatordir --print-statedumpdir --print-logdir However, the CLI package need not be present on the machine running glusterd2. This change adds the above CLI options to glusterfsd binary which glusterd2 depends on. Reverts 9a1ae47c8d60836ae0628a04a153f28c1085c0e8 Related changes: https://review.gluster.org/#/c/19882/ https://github.com/gluster/glusterd2/pull/663 Updates: bz#1193929 Change-Id: I18c123b0d3350d2bd4f2400783e3b94e402a4e29 Signed-off-by: Prashanth Pai <ppai> REVIEW: https://review.gluster.org/19923 (build: Disallow unresolved symbol references) posted (#1) for review on master by Prashanth Pai REVIEW: https://review.gluster.org/19955 (mount,fuse: make fuse dumping available as mount option) posted (#2) for review on master by Csaba Henk COMMIT: https://review.gluster.org/19955 committed in master by "Amar Tumballi" <amarts> with a commit message- mount,fuse: make fuse dumping available as mount option Updates: bz#1193929 Change-Id: I4dd4d0e607f89650ebb74b893b911b554472826d Signed-off-by: Csaba Henk <csaba> REVIEW: https://review.gluster.org/19976 (features/cloudsync: Remove multiple definition in Makefile.am) posted (#2) for review on master by Anoop C S REVIEW: https://review.gluster.org/19994 (core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np())) posted (#1) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/19994 committed in master by "Kaleb KEITHLEY" <kkeithle> with a commit message- core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np()) And has had it since at least FreeBSD 9.0 Reported-by: Roman Serbski <mefystofel> Change-Id: I52cfde7f2f7a82d0e66465ac392ed7e201e1653b updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> COMMIT: https://review.gluster.org/19976 committed in master by "Kaleb KEITHLEY" <kkeithle> with a commit message- features/cloudsync: Remove multiple definition in Makefile.am CLOUDSYNC_SRC is defined twice in the same Makefile.am which generates the following warning: xlators/features/cloudsync/src/Makefile.am:9: warning: CLOUDSYNC_SRC multiply defined in condition TRUE ... xlators/features/cloudsync/src/Makefile.am:5: ... 'CLOUDSYNC_SRC' previously defined here Therefore removing the duplicate definition. Change-Id: I00c3e2f3d64ad45e4080c2c82766516cd3e2bf63 fixes: bz#1193929 BUG: 1193929 Signed-off-by: Anoop C S <anoopcs> REVIEW: https://review.gluster.org/20002 (core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np())) posted (#1) for review on release-4.1 by Kaleb KEITHLEY REVIEW: https://review.gluster.org/20003 (core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np())) posted (#1) for review on release-4.0 by Kaleb KEITHLEY REVIEW: https://review.gluster.org/20004 (core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np())) posted (#1) for review on release-3.12 by Kaleb KEITHLEY REVISION POSTED: https://review.gluster.org/20002 (core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np())) posted (#2) for review on release-4.1 by Kaleb KEITHLEY REVISION POSTED: https://review.gluster.org/20003 (core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np())) posted (#2) for review on release-4.0 by Kaleb KEITHLEY REVISION POSTED: https://review.gluster.org/20004 (core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np())) posted (#2) for review on release-3.12 by Kaleb KEITHLEY COMMIT: https://review.gluster.org/19923 committed in master by "Amar Tumballi" <amarts> with a commit message- build: Disallow unresolved symbol references In the past, it was often[1] forgotten for xlators to be linked against the symbols they refer to. This often caused glusterd2 to fail while loading xlator's shared object (.so) file. This change adds "--no-undefined" as a linker flag which causes the linker to treat unresolved symbol references as an error and hence fail linking. [1]: https://review.gluster.org/#/c/19912/ https://review.gluster.org/#/c/19664/ https://review.gluster.org/#/c/19056/ https://review.gluster.org/#/c/17659/ https://bugzilla.redhat.com/show_bug.cgi?id=1532238 Bonus: Added cloudsync and utime xlator's generated source files to .gitignore Updates: bz#1193929 Change-Id: I9604a4a87b7313a5fa43bda5fdb37dfa7ef8facd Signed-off-by: Prashanth Pai <ppai> REVIEW: https://review.gluster.org/20048 (api: cleanup headers) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/20073 (api: missing __THROW on pub function decls) posted (#1) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/20073 committed in master by "Amar Tumballi" <amarts> with a commit message- api: missing __THROW on pub function decls missing __THROW on pub function decls needed for C++ Change-Id: Ia0ff09d311741e4cdc8ef171e07bbd56c24b9260 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> REVIEW: https://review.gluster.org/20111 (libgfchangelog: Remove duplicate includedir definition for changelog.h) posted (#1) for review on master by Anoop C S COMMIT: https://review.gluster.org/20111 committed in master by "Amar Tumballi" <amarts> with a commit message- libgfchangelog: Remove duplicate includedir definition for changelog.h includedir for changelog.h is already defined in Makefile.am under libglusterfs/src since it was moved from xlators/features/changelog/lib/src. Therefore removing the duplicate definition. Change-Id: Iaff2e02fca45715820caa35b41efc2f6b656203a updates: bz#1193929 Signed-off-by: Anoop C S <anoopcs> REVIEW: https://review.gluster.org/20173 (MAINTAINERS: remove me from NFS maintainers) posted (#1) for review on master by Niels de Vos COMMIT: https://review.gluster.org/20048 committed in master by "Amar Tumballi" <amarts> with a commit message- api: cleanup headers fix inconsistent use in headers of: struct glfs and glfs_t struct glfs_fd and glfs_fd_t struct glfs_object and glfs_object_t add typedefs to headers for various struct glfs_foos, and use them, e.g.: struct glfs_upcall and glfs_upcall_t fix inconsistent type naming for 'enum glfs_lock_mode_t'. (All other enum decls are 'enum glfs_foo' not 'enum_glfs_foo_t'), and add typedefs for all enums, and use them. style, replace tabs with spaces and follow return value style, i.e.: int pub_glfs_foo() instead of: int pub_glfs_foo() Update copyright dates, substantial new work has been done since 2012 Change-Id: I0a9654486ea132efde7977b655799fb37887b1d5 Updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> COMMIT: https://review.gluster.org/20173 committed in master by "Amar Tumballi" <amarts> with a commit message- MAINTAINERS: remove me from NFS maintainers My role at Red Hat changed a little and I do not have the time to look into gNFS anymore. If needed, I am still around to assist, but the initial contacts should be the active maintainers and peers. Change-Id: I3cbae3c5cbd413abb6f95be238efc685c493c392 Updates: bz#1193929 Signed-off-by: Niels de Vos <ndevos> REVIEW: https://review.gluster.org/20426 (xlators/playground: fix the template files with latest requirements) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20437 (protocol/client: handle the fdctx_destroy properly with different versions) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20446 (stack.h: fix the pass_through logic) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20447 (checkpatch.pl: fix the perl warning) posted (#1) for review on master by Amar Tumballi COMMIT: https://review.gluster.org/20446 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- stack.h: fix the pass_through logic while fixing the coverity issues, we made a minor mistake in the pass through logic in STACK_WIND macro. Also, with this patch, made the code common to reduce possible future errors creeping in due to missing one place update. updates: bz#1193929 Change-Id: I6fcfd156d63b0a7e6208819872e565eacf774150 Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/20437 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- protocol/client: handle the fdctx_destroy properly with different versions while adding the new version of RPC, this part was not handled properly Updates: bz#1193929 Change-Id: If4cc4c2db075221b9ed731bacb7cc035f7007c5b Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/20447 committed in master by "Amar Tumballi" <amarts> with a commit message- checkpatch.pl: fix the perl warning Used to get the below warning: ` Running coding guidelines check ... Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/^(\+.*(?:do|\))){ <-- HERE / at ./build-aux/checkpatch.pl line 3102. ` But as per the recommendation in perl document, we should escape the braces. While this check should be removed from the codebase when we get the 'codingstandard' automated scripts, we can keep the code warning free at least till then. updates: bz#1193929 Change-Id: I236a428174b5d16ca41baa03e96bc7aa26177b5b Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/20472 (server: Rename xlator ID to 'server') posted (#1) for review on master by Prashanth Pai REVIEW: https://review.gluster.org/20474 (Fix compile warnings) posted (#2) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/20483 (Move time string formatting) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20493 (glusterd: log improvements on brick creation validation) posted (#1) for review on master by Atin Mukherjee COMMIT: https://review.gluster.org/20474 committed in master by "Xavi Hernandez" <xhernandez> with a commit message- Fix compile warnings This patch fixes compile warnings that appear with newer compilers. The solution applied is only to remove the warnings, but it doesn't always solve the problem in the best way. It assumes that the problem will never happen, as the previous code assumed. Change-Id: I6e8470d6c2e2dbd3bd7d324b5fd2f92ffdc3d6ec updates: bz#1193929 Signed-off-by: Xavi Hernandez <xhernandez> COMMIT: https://review.gluster.org/20472 committed in master by "Amar Tumballi" <amarts> with a commit message- server: Set ssl-allow option in options table and rename ID This change explicitly adds 'ssl-allow' options to the server xlator's options table so that glusterd2 can see it as a settable option. This change also marks 'auth.allow' and 'auth.reject' options as a settable. Glusterd2 doesn't maintain a separate volume options table. Glusterd2 dynamically loads shared objects of xlators to read their option table and other information. Glusterd2 reads 'xlator_api_t' if available. If that's not available, it falls back to reading just the options table directly. In glusterd2, volume set operations are performed by users on keys of the format <xlator>.<option-name>. Glusterd2 uses xlator name set in 'xlator_api_t.identifier'. If that's not present it will use the shared object's file name as xlator name. Hence, it is important for 'xlator_api_t.identifier' to be set properly, and in this case, the proper value is "server". This name shall be used by users as prefix while setting volume options implemented in server xlator. The name will also be used in volfile. A user in glusterd2 can authorize a client over TLS as follows: $ glustercli volume set <volname> server.ssl-allow <client1-CN>[,<clientN-CN>] gd2 References: https://github.com/gluster/glusterd2/issues/971 https://github.com/gluster/glusterd2/issues/214 https://github.com/gluster/glusterd2/pull/967 Updates: bz#1193929 Change-Id: I59ef58acb8d51917e6365a83be03e79ae7c5ad17 Signed-off-by: Prashanth Pai <ppai> COMMIT: https://review.gluster.org/20493 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterd: log improvements on brick creation validation Added few log entries in glusterd_is_brickpath_available (). Change-Id: I8b758578f9db90d2974f7c79126c50ad3a001d71 Updates: bz#1193929 Signed-off-by: Atin Mukherjee <amukherj> REVIEW: https://review.gluster.org/20503 (tests/geo-rep: increase the timeout) posted (#1) for review on master by Amar Tumballi COMMIT: https://review.gluster.org/20503 committed in master by "Amar Tumballi" <amarts> with a commit message- tests/geo-rep: increase the timeout since some time, geo-rep tests were in the border of 180-190 seconds to complete. As actual test timeout is 200 seconds by default, giving these tests some buffer time to complete properly. updates: bz#1193929 Change-Id: I9f501a02b52585dff7d0473824bdbb229e124278 Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/20512 (glusterd-quota.c: fix coverity warning (BAD_COMPARE)) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20515 (glusterd-store: fix coverity warning) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20522 (All: run codespell on the code and fix issues.) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20515 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterd-store: fix coverity warning The same variable 'len' was used both in the macros and the functions. (Introduced as part of commit 6dc5dfef819cad69d6d4b4c1c305efa74236ad84 ?) Change-Id: If434999d6470067f8a1e501c8e132561e8cd81ef updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20483 committed in master by "Amar Tumballi" <amarts> with a commit message- tier: Move time string formatting There is no need to format the time, unless ret is true. I don't think there's a reason to allocate memory for those struct and char array unless we are formatting either (But I'm not sure what the code convention is - are we ok with 'local' variable declarations?) Only compile-tested. Change-Id: I9feb09871943764bd76bdfc9ac6ca506f329aac1 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20524 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- build/core: location of xattr.h starting with libattr-devel-2.4.48-1 in Fedora 28 <attr/xattr.h> has been removed from the package. On Fedora, RHEL/CentOS, and SUSE, the glibc-headers package has provided a near identical file, <sys/xattr.h>, in all the releases that we care about. On Debian, libc6-dev provides <sys/xattr.h> all the way back to 8/Jessie and presumably all Ubuntu derivatives since then. Note that on Debian the sys headers are installed in /usr/include/$DEB_HOST_GNU_TYPE/sys/... Change-Id: Id07c4b225bdaa6556bd54772604e75b8f346fb60 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> REVIEW: https://review.gluster.org/20533 (gcc warnings: fix the few remaining warnings) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20538 (doc: Add details around xlator classifications) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/20540 (coding-standard: add points on structure padding) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20541 (doc: add details on how the commit msg should be) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20542 (doc: add coding-standard and commit-msg link in README) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20543 (doc: keep just one copy of a coredump analysis) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20545 (glusterd: fix gcc7 warnings) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20548 (contrib/xxhash: update to latest xxHash (0.6.5)) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20522 committed in master by "Amar Tumballi" <amarts> with a commit message- All: run codespell on the code and fix issues. Please review, it's not always just the comments that were fixed. I've had to revert of course all calls to creat() that were changed to create() ... Only compile-tested! Change-Id: I7d02e82d9766e272a7fd9cc68e51901d69e5aab5 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/20562 (georep: fix hard-coded paths in gsyncd.conf.in) posted (#1) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/20562 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- georep: fix hard-coded paths in gsyncd.conf.in This is part of the reason why we use autoconf (i.e. configure). For an ordinary clone+autogen.sh+configure SBIN_DIR is /usr/local/sbin; for an rpm or dpkg build it will be /usr/sbin. I wonder how many more are lurking in our sources? /usr/libexec is one that frequently bites us on Debian and Ubuntu, which don't have /usr/libexec. (But it's all Linux, right?) See https://bugzilla.redhat.com/show_bug.cgi?id=1601532 Reported-by: lohmaier+rhbz Change-Id: I6523894416cc06236ea1f99529efd36e957bd98e updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> REVIEW: https://review.gluster.org/20572 (stack: Reduce stack usage for local variables to store tmpfile names) posted (#1) for review on master by Shyamsundar Ranganathan COMMIT: https://review.gluster.org/20572 committed in master by "Amar Tumballi" <amarts> with a commit message- stack: Reduce stack usage for local variables to store tmpfile names This patch moves stack based PATH_MAX allocations for tmpfile names, to heap allocated names instead. Reducing the impact on stack space used and accruing benefits thereof. Change-Id: I646d9cb091018de6768b3523902788fa2ba14d96 Updates: bz#1193929 Signed-off-by: ShyamsundarR <srangana> REVIEW: https://review.gluster.org/20591 (contrib: Remove gf_mkostemp copied from GLibC) posted (#1) for review on master by Shyamsundar Ranganathan COMMIT: https://review.gluster.org/20543 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- doc: keep just one copy of a coredump analysis Keeping two copies of the files means, one would be out-of-date soon, and users would always be confused about which one is the source of truth. Updates: bz#1193929 Change-Id: I568149732fdb9d282ccd583640eee9b9056963fd Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/20540 committed in master by "Amar Tumballi" <amarts> with a commit message- coding-standard: add points on structure padding This is a recommendation for users, and reviewers can take a point from this. Updates: bz#1193929 Change-Id: Idcd778e42a886fd79b549da4927149a07573a20b Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/20624 (All: remove memset() before sprintf()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20633 (coding-standard: memset before snprintf) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/20700 (glusterd: remove the unused databuf in rebalance structure) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/20702 (bd: remove the translator from build) posted (#1) for review on master by Amar Tumballi COMMIT: https://review.gluster.org/20624 committed in master by "Amar Tumballi" <amarts> with a commit message- All: remove memset() before sprintf() It's not needed. There's a good chance the compiler is smart enough to remove it anyway, but it can't hurt - I hope. Compile-tested only! Change-Id: Id7c054e146ba630227affa591007803f3046416b updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/20744 (glusterd: fix gcc warnings) posted (#1) for review on master by Ravishankar N COMMIT: https://review.gluster.org/20548 committed in master by "Kotresh HR" <khiremat> with a commit message- contrib/xxhash: update to latest xxHash (0.6.5) Update to latest xxHash, which is supposed to faster with small keys. Specifically, updated to 3064d42e7d74b0921bdd1818395d9cb37bb8976a, which is a bit higher than 0.6.5. Compiled hopefully with namespace (XXH_NAMESPACE=GF_), which allows to use XXH() funcs with no fear they'll 'leak' from our library. Only compile tested! xxhsum is modified to display messages which was conflicting with regression tests (TAP harness). So modified the gfid2path_fuse.t and gfid2path_nfs.t to adhere to that. updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I35cea5cc93f338c1023ac2c9bc6d7d13225a967b COMMIT: https://review.gluster.org/20591 committed in master by "Amar Tumballi" <amarts> with a commit message- contrib: Remove gf_mkostemp copied from GLibC gf_mkostemp is borrowed from GLibC a long time back, we now have mkostemp or mkstemp alternatives with all distributions and versions that we care for. As a result removing this from the contrib directory and modifying the one instance that is still using the same. This is part of code cleanup as we cleaned up coverity SECUR_TEMP errors. Updates: bz#1193929 Change-Id: I1ad7863043cdb0845c53748f5a0522e767079130 Signed-off-by: ShyamsundarR <srangana> REVIEW: https://review.gluster.org/20746 (gnfs: fix gcc warnings) posted (#1) for review on master by Ravishankar N REVIEW: https://review.gluster.org/20759 (New flag to glusterfsd binary to print libexec dir) posted (#1) for review on master by Aravinda VK COMMIT: https://review.gluster.org/20538 committed in master by "Amar Tumballi" <amarts> with a commit message- doc: Add details around xlator categories Updates: bz#1193929 Change-Id: I6446bbdd8025f333a3e855032c0c7709bf4ae4cd Signed-off-by: ShyamsundarR <srangana> REVIEW: https://review.gluster.org/20766 (dict.c: align dictionary structures) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20767 (dict.c: do not strlen if not needed.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20768 (libglusterfs/src/dict.c: perform hash calc not under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20769 (libglusterfs/src/dict.{c,h}: Introduce dict_setn, dict_addn, dict_addn and others.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20771 (libguestfs/src/mem-pool.h: switch from calloc() to malloc()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20772 (xlators/nfs/server/src/mount3.c : allocate memory as much as needed.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20776 (xlators/protocol/client/src/client-lk.c : Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20777 (xlators/performance/quick-read/src/quick-read.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20778 (xlators/performance/md-cache/src/md-cache.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20773 (xlators/storage/posix/src/posix-inode-fd-ops.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20779 (xlators/performance/io-cache/src/page.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20774 (xlators/storage/posix/src/posix-helpers.c : Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20775 (xlators/storage/bd/src/bd.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20780 (xlators/nfs/server/src/nfs3-helpers.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20781 (xlators/nfs/server/src/nfs-fops.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20782 (xlators/nfs/server/src/mount3udp_svc.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20785 (xlators/mount/fuse/src/fuse-bridge.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20783 (xlators/nfs/server/src/mount3.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20787 (xlators/mgmt/glusterd/src/glusterd-syncop.h: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20784 (xlators/mount/fuse/src/fuse-helpers.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20788 (xlators/mgmt/glusterd/src/glusterd-snapshot.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20789 (xlators/mgmt/glusterd/src/glusterd-rpc-ops.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20790 (xlators/mgmt/glusterd/src/glusterd-replace-brick.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20791 (xlators/mgmt/glusterd/src/glusterd-op-sm.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20792 (xlators/mgmt/glusterd/src/glusterd-mgmt.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20793 (xlators/meta/src/subvolumes-dir.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20794 (xlators/meta/src/graph-dir.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20795 (xlators/features/trash/src/trash.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20786 (xlators/mgmt/glusterd/src/glusterd-utils.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20796 (xlators/features/shard/src/shard.h: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20797 (xlators/features/shard/src/shard.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20799 (xlators/features/locks/src/common.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20798 (xlators/features/marker/src/marker-quota.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20800 (xlators/features/leases/src/leases-internal.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20802 (xlators/features/cloudsync/src/cloudsync-plugins/src/cloudsyncs3/src/libcloudsyncs3.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20803 (xlators/features/bit-rot/src/bitd/bit-rot.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20804 (xlators/features/bit-rot/src/bitd/bit-rot-scrub.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20805 (bxlators/encryption/crypt/src/metadata.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20806 (xlators/encryption/crypt/src/crypt.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20807 (xlators/cluster/stripe/src/stripe-helpers.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20808 (xlators/cluster/dht/src/tier.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20810 (xlators/cluster/dht/src/dht-helper.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20811 (xlators/cluster/dht/src/dht-common.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20812 (xlators/cluster/afr/src/afr.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20813 (xlators/cluster/afr/src/afr-inode-read.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20814 (tests/bugs/replicate/bug-1250170-fsync.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20815 (tests/basic/gfapi/gfapi-async-calls-test.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20816 (tests/basic/ec/ec-fast-fgetxattr.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20801 (xlators/features/gfid-access/src/gfid-access.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20817 (rpc/xdr/src/glusterfs3.h: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20818 (rpc/rpc-transport/socket/src/socket.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20819 (rpc/rpc-lib/src/rpc-clnt.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20820 (libglusterfs/src/rbthash.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20821 (libglusterfs/src/graph.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20822 (libglusterfs/src/dict.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20823 (libglusterfs/src/common-utils.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20824 (libglusterfs/src/client_t.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20825 (glusterfsd/src/glusterfsd.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20809 (xlators/cluster/dht/src/dht-layout.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20826 (extras/geo-rep/gsync-sync-gfid.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20827 (cli/src/cli-xml-output.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20828 (cli/src/cli-rpc-ops.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20829 (cli/src/cli-cmd-volume.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20830 (cli/src/cli-cmd-system.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20831 (cli/src/cli-cmd-snapshot.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20833 (cli/src/cli-cmd-parser.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20834 (cli/src/cli-cmd-global.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20832 (cli/src/cli-cmd-peer.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20835 (api/src/glfs.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20836 (glusterfsd/src/glusterfsd.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20840 (xlators/mgmt/glusterd/src/glusterd-handler.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20841 (xlators/mgmt/glusterd/src/glusterd-handshake.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20837 (xlators/mgmt/glusterd/src/glusterd-bitrot.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20838 (xlators/mgmt/glusterd/src/glusterd-brick-ops.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20839 (xlators/mgmt/glusterd/src/glusterd-geo-rep.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20842 (xlators/mgmt/glusterd/src/glusterd-log-ops.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20843 (xlators/mgmt/glusterd/src/glusterd-replace-brick.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20844 (xlators/mgmt/glusterd/src/glusterd-rpc-ops.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20845 (xlators/mgmt/glusterd/src/glusterd-snapshot-utils.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20846 (xlators/mgmt/glusterd/src/glusterd-utils.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20847 (xlators/mgmt/glusterd/src/glusterd-volgen.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20848 (xlators/mgmt/glusterd/src/glusterd-volume-ops.c : reduce size or re-scope message variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20849 (libglusterfs/src/common-utils.c: strncpy -> sprintf, remove dead code.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20763 (dict.c: copy-pasta fix (dict -> data)) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20764 (dict.c: ensure hash is done in the right place Outside of locks, whenever is possible, for example.) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20765 (dict.c: fix coverity issue) posted (#2) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20763 committed in master by "Niels de Vos" <ndevos> with a commit message- dict.c: copy-pasta fix (dict -> data) Change-Id: Ifda14a1cc01e0fa99ff20d710eccb43296e22955 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20746 committed in master by "Amar Tumballi" <amarts> with a commit message- gnfs: fix gcc warnings gcc version 8.1.1 20180712 (Red Hat 8.1.1-5) (GCC) on Fedora 28. Sample warnings: 1) nfs3.c:292:54: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 143 and 250 [-Wformat-truncation=] snprintf (buf, sizeof (buf), "(%s) %s : %s", \ ^~~~~~~~~~~~~~ nfs3.c:295:35: gfid); \ ~~~~ 2) nlm4.c:145:54: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 143 and 250 [-Wformat-truncation=] snprintf (buf, sizeof (buf), "(%s) %s : %s", \ ^~~~~~~~~~~~~~ nlm4.c:148:35: gfid); \ ~~~~ acl3.c:128:54: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 143 and 250 [-Wformat-truncation=] snprintf (buf, sizeof (buf), "(%s) %s : %s", \ ^~~~~~~~~~~~~~ acl3.c:131:35: gfid); \ ~~~~ updates: bz#1193929 Change-Id: I760b8176e48f1f4628a1a98afa54a7994bdf13e9 Signed-off-by: Ravishankar N <ravishankar> COMMIT: https://review.gluster.org/20771 committed in master by "Amar Tumballi" <amarts> with a commit message- libguestfs/src/mem-pool.h: switch from calloc() to malloc() If we are going to overwrite that allocated memory, why bother zero'ing it? Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I9c9d2d8d5ab3e706c747feb1920ecd417807f7fd COMMIT: https://review.gluster.org/20849 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/src/common-utils.c: strncpy -> sprintf, remove dead code. strncpy may not be very efficient for sort strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, do a quick calc to see how much we really need and use snprintf() to copy as much. Also, move from CALLOC to MALLOC, as we are writing to this newly allocated memory right away and add terminating null. Lastly, removed some dead code. I did the same optimization as above to it, only to find out no one is using it. Compile-tested only! Change-Id: Ib91b9a73c3d74c511fd067446b1bf6c2e1802687 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20764 committed in master by "Amar Tumballi" <amarts> with a commit message- dict.c: ensure hash is done in the right place. The hash should be done outside of locks, whenever is possible. Change-Id: I4f8f7455702e0489a57105cf79668c7fca90e1c0 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20836 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterfsd/src/glusterfsd.c : reduce size or re-scope message variable The the error and/or message variable was either: - Reduced in size - from 2048 bytes to 64 bytes, for example. or - Changed in scope - defined in a smaller scope. Compile-tested only! Change-Id: I20b9fb3407a74ba96fcbc7f05fcab534ff562c09 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20744 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterd: fix gcc warnings ...and also changed char array initialization to from {0,} to "". gcc version 8.1.1 20180712 (Red Hat 8.1.1-5) (GCC) on Fedora 28. Sample warnings: glusterd-utils.c:7234:41: warning: ‘.hostname’ directive output may be truncated writing 9 bytes into a region of size between 1 and 1024 [-Wformat-truncation=] snprintf (key, sizeof (key), "%s.hostname", base_key); ^~~~~~~~~ glusterd-utils.c:7234:9: note: ‘snprintf’ output between 10 and 1033 bytes into a destination of size 1024 snprintf (key, sizeof (key), "%s.hostname", base_key); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ glusterd-snapshot.c:3090:65: warning: ‘/’ directive output may be truncated writing 1 byte into a region of size between 0 and 4095 [-Wformat-truncation=] snprintf (snap_path, sizeof (snap_path) - 1, "%s/%s", ^ glusterd-snapshot.c:3090:17: note: ‘snprintf’ output between 2 and 4351 bytes into a destination of size 4095 snprintf (snap_path, sizeof (snap_path) - 1, "%s/%s", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ snap_mount_dir, snap_vol->snapshot->snapname); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ glusterd-statedump.c:28:45: warning: ‘%s’ directive output may be truncated writing up to 4095 bytes into a region of size 144 [-Wformat-truncation=] snprintf (subkey, sizeof (subkey), "%s%d", key, index); ^~ ~~~ glusterd-statedump.c:28:9: note: ‘snprintf’ output between 2 and 4107 bytes into a destination of size 144 snprintf (subkey, sizeof (subkey), "%s%d", key, index); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ updates: bz#1193929 Change-Id: Ic721f27b28d1221c124b570e81c55528f5b7f3cd Signed-off-by: Ravishankar N <ravishankar> REVIEW: https://review.gluster.org/20877 (api/src/glfs.c: move to GF_MALLOC() instead of GF_CALLOC()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20878 (cli/src/cli-cmd-parser.c:move to GF_MALLOC() instead of GF_CALLOC() when) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20879 (libglusterfs/src/quotea-common-utils.c:move to GF_MALLOC() instead of GF_CALLOC() when) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20880 (rpc/rpc-lib/src/rpc-clnt-ping.c:move to GF_MALLOC() instead of GF_CALLOC() when) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20882 (xlators/cluster/dht/src/dht-common.c :move to GF_MALLOC() instead of GF_CALLOC() when) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20883 (xlators/cluster/dht/src/tier-common.c:move to GF_MALLOC() instead of GF_CALLOC() when) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20881 (xlators/cluster/afr/src/afr-inode-read.c: move to GF_MALLOC() instead of GF_CALLOC() when) posted (#1) for review on master by Yaniv Kaul REVISION POSTED: https://review.gluster.org/20851 (xlators/storage/bd/src/bd.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#5) for review on master by Yaniv Kaul REVISION POSTED: https://review.gluster.org/20851 (xlators/storage/bd/src/bd.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#5) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20851 (xlators/storage/bd/src/bd.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible) posted (#5) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20877 committed in master by "Niels de Vos" <ndevos> with a commit message- api/src/glfs.c: move to GF_MALLOC() instead of GF_CALLOC() It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! Change-Id: Ieeb86ff5d99176250f57c0a28c215c709b83fc80 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20824 committed in master by "Niels de Vos" <ndevos> with a commit message- libglusterfs/src/client_t.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I58d2604ef684f94ea782fdbb1b1462fc7be53a9e COMMIT: https://review.gluster.org/20822 committed in master by "Niels de Vos" <ndevos> with a commit message- libglusterfs/src/dict.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Iea9098b9ec0a82a866fbc5836514b1b317daefa1 COMMIT: https://review.gluster.org/20820 committed in master by "Niels de Vos" <ndevos> with a commit message- libglusterfs/src/rbthash.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Ied400a500e36373d725f9480c5ebbe0a851f7c40 COMMIT: https://review.gluster.org/20879 committed in master by "Niels de Vos" <ndevos> with a commit message- libglusterfs/src/quota-common-utils.c:move to GF_MALLOC() instead of GF_CALLOC() when It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! Change-Id: Ie2a634d768904636160582189a5f0390668b37bb updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20766 committed in master by "Niels de Vos" <ndevos> with a commit message- dict.c: align dictionary structures Change-Id: Ib7250b3ff11a7ab98b578c0663dc1817624b8df1 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20821 committed in master by "Niels de Vos" <ndevos> with a commit message- libglusterfs/src/graph.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Icd990423a5e6048e76922668aab67422f4bc1867 COMMIT: https://review.gluster.org/20426 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/playground: fix the template files with latest requirements * Make use of xlator_api * Make use of gf_msg() * Make use of mem-pool * Add a sample metrics dump function * Provide an dummy option, which can be initialized, and reconfigured * Add a test case to make sure template xlator is built and used with default fops * Make a change in rpc-coverage to run without lock tests. Updates: bz#1193929 Change-Id: I377dd67b656f440f9bc7c0098e21c0c1934e9096 Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/20823 committed in master by "Niels de Vos" <ndevos> with a commit message- libglusterfs/src/common-utils.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I579f5b405bf410aac5ab0452231124d354f94ed1 REVIEW: https://review.gluster.org/20894 (glfs-fops.c, glfs.c: strncpy() -> sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20895 ({cli-cmd-parser|cli-rpc-ops||cli-xml-output}.c: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20896 ({mount-common|fusermount|mount_darwin|umountd}.c: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20900 (bit-rot xlator: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20897 (extras/geo-rep/gsync-sync-gfid.c: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20898 (multiple files: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20899 (multiple files: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20901 (changelog xlator: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20902 (changetimerecoder xlator: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20903 (xlators: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20904 (NFS server (mount3.c, nfs-inodes.c): strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20905 (multiple xlators: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20906 (multiple xlators: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20908 (multiple xlators (storage/posix): strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20909 (Various files: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20907 (multiple xlators (mgmt): strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20837 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-bitrot.c : reduce size of message variable Size of error message variable reduced from 2048 bytes to 256 bytes. Compile-tested only! Change-Id: Ib536451d9b562f932132b99c4eff21fc4f2775bc updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20838 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-brick-ops.c : reduce size or re-scope message variable The the error and/or message variable was either: - Reduced in size - from 2048 bytes to 64 bytes, for example. or - Changed in scope - defined in a smaller scope. Compile-tested only! Change-Id: Ib74e5f8f4c2978f670d4708e9382e97edf5df0a7 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20839 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-geo-rep.c : reduce size of message variable Size of error message variable reduced from 2048 bytes to 64 bytes. Compile-tested only! Change-Id: I65abd9c4f23a64ac9cda5373aff4119458addbc8 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20840 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-handler.c : reduce size or re-scope message variable The the error and/or message variable was either: - Reduced in size - from 2048 bytes to 64 bytes, for example. or - Changed in scope - defined in a smaller scope. Compile-tested only! Change-Id: Iebb92a56d9d0ca53c80d75866bcb7848e08cf6b2 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20841 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-handshake.c : reduce size or re-scope message variable The the error and/or message variable was either: - Reduced in size - from 2048 bytes to 64 bytes, for example. or - Changed in scope - defined in a smaller scope. Compile-tested only! Change-Id: I9c609415667844ee034b7eb2b67bdbc19d38819d updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20844 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-rpc-ops.c : re-scope message variable The error and/or message variable was changed in scope: defined in a smaller scope. Compile-tested only! Change-Id: I5e46a1992ad35a996aa8ee58da28606ac018ab8e updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/20918 (glfs-fops.c, glfs.c: strncpy() -> sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20919 ({cli-cmd-parser|cli-rpc-ops||cli-xml-output}.c: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20922 (multiple files: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20920 ({mount-common|fusermount|mount_darwin|umountd}.c: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20921 (extras/geo-rep/gsync-sync-gfid.c: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20923 (multiple files: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20924 (bit-rot xlator: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20925 (changelog xlator: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20926 (changetimerecoder xlator: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20930 (multiple xlators: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20927 (xlators: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20928 (NFS server (mount3.c, nfs-inodes.c): strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20929 (multiple xlators: move from strlen() to sizeof()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20931 (multiple xlators (mgmt): strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20932 (multiple xlators (storage/posix): strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20933 (Various files: strncpy()->sprintf(), reduce strlen()'s) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20934 ({dht-rebalance|glusterd-geo-rep|glusterd-utils|nfs|bd}.c: no dict_del before dict_set) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20920 ({mount-common|fusermount|mount_darwin|umountd}.c: strncpy()->sprintf(), reduce strlen()'s) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20923 (multiple files: move from strlen() to sizeof()) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20924 (bit-rot xlator: strncpy()->sprintf(), reduce strlen()'s) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20921 (extras/geo-rep/gsync-sync-gfid.c: move from strlen() to sizeof()) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20925 (changelog xlator: strncpy()->sprintf(), reduce strlen()'s) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20922 (multiple files: move from strlen() to sizeof()) posted (#2) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20878 committed in master by "Amar Tumballi" <amarts> with a commit message- cli/src/cli-cmd-parser.c:move to GF_MALLOC() instead of GF_CALLOC() when It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! Change-Id: I01c67fd535ea4a2b8fa7cb4d89bff52642dc009a updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20880 committed in master by "Amar Tumballi" <amarts> with a commit message- rpc/rpc-lib/src/rpc-clnt-ping.c:move to GF_MALLOC() instead of GF_CALLOC() when It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! Change-Id: Ifb30412ddf1bfa509f52e0454454929b266e5658 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20847 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-volgen.c : reduce size of message variable Size of error message variable reduced from 4096 bytes to 128 bytes. Compile-tested only! Change-Id: I08c87502be791e68ab767ed96657ac89ee77fae0 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20843 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-replace-brick.c : reduce size of message variable Size of error message variable reduced from 2048 bytes to 256 bytes. Compile-tested only! Change-Id: Ifc0f6af2256bcbec77102767ba651d5d55f8c906 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20845 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-snapshot-utils.c : declare err_str as const char declare err_str as const char and intialize it at the time of declaration. Compile-tested only! Change-Id: If07e1130e819ce042905a2d0be650cd7afc2b558 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20848 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-volume-ops.c : reduce size of message variable Size of error message variable reduced from 2048 bytes to 64 bytes or 128 bytes. Compile-tested only! Change-Id: I393ba03969a6e71ccb0ce382d0e0546192897312 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20846 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/mgmt/glusterd/src/glusterd-utils.c : re-scope message variable The the error message variable changed in scope - defined in a smaller scope. Compile-tested only! Change-Id: I16dda11c30099b0e448b8e44a300f153727ce8da updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/20977 (libglusterfs/src/iobuf.c: remove memset(), CALLOC -> MALLOC) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20977 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/src/iobuf.c: remove memset(), CALLOC -> MALLOC I'm not sure I see the need for those memset(), I've removed them. There's at least one easy to convert CALLOC to MALLOC - converted. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Ia019775ad5255190f5d02d948ea27db7f563387d REVIEW: https://review.gluster.org/20985 (shard: NULL pointer dereferencing clang fix) posted (#1) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20989 (libglusterfs/src/dict.c: allocate memory accurately.) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20918 committed in master by "Amar Tumballi" <amarts> with a commit message- glfs-fops.c, glfs.c: strncpy() -> sprintf(), reduce strlen()'s strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Also, save the result of strlen() and re-use it when possible. Compile-tested only! Change-Id: I4ecfb359cf0efaafeab245a8138f526b21613231 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20919 committed in master by "Amar Tumballi" <amarts> with a commit message- {cli-cmd-parser|cli-rpc-ops||cli-xml-output}.c: strncpy()->sprintf(), reduce strlen()'s strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Also: - save the result of strlen() and re-use it when possible. - move from GF_CALLOC() to GF_MALLOC() for the strings. - move from strlen to sizeof() for const strings. Compile-tested only! Change-Id: I3cf49c5401ee100a5db6a4954c3d699ec1814c17 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20920 committed in master by "Amar Tumballi" <amarts> with a commit message- {mount-common|fusermount|mount_darwin|umountd}.c: strncpy()->sprintf(), reduce strlen()'s strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN (sizeof() ) for const strings. Compile-tested only! Change-Id: I369209b36d8356c3fe00d32f8bf56e74cf9963db updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/20988 (dict.c: fix indention) posted (#2) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20921 committed in master by "Amar Tumballi" <amarts> with a commit message- extras/geo-rep/gsync-sync-gfid.c: move from strlen() to sizeof() For const strings, just do compile-time size calc instead of runtime. Compile-tested only! Change-Id: I89470016389a4ecb3bed35a1c9e684f5fae79997 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20922 committed in master by "Amar Tumballi" <amarts> with a commit message- multiple files: move from strlen() to sizeof() {ec-heal|ec-combine|ec-helpers|ec-inode-read}.c For const strings, just do compile time size calc instead of runtime. Compile-tested only! Change-Id: If92ba0a7a20f64b898d01c6e3b6708190ca93e04 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/20995 (contrib/fuse-lib/misc.c: remove unneeded memset()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20996 (libglusterfs/src/{client_t|fd|inode|stack}.c: remove some memset()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20997 (libglusterfs/src/xlator.c: remove unneeded memset()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20998 (xlators/cluster/afr/src/afr-self-heal-common.c: remove unneeded memset()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20999 (xlators/cluster/dht/src/dht-common.c: remove unneeded memset()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21000 (xlators/cluster/ec/src/ec-helpers.c: remove unneeded memset()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21001 (xlators/mgmt/glusterd/src/glusterd-volgen.c: remove some memset()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21002 (xlators/mgmt/glusterd/src/glusterd-geo-rep.c: read() in 4K blocks) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21003 (xlators/storage/posix/src/posix-{gfid-path|inode-fd-ops}.c: remove memset() before sys_*xattr() functions.) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20767 committed in master by "Amar Tumballi" <amarts> with a commit message- dict.c: do not strlen if not needed. Use the output of sprintf(). Also, constify and initialize parameters properly. Only compile-tested! Change-Id: I33870afbe14bc1292fb08115e878d48c00a43bee updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20988 committed in master by "Amar Tumballi" <amarts> with a commit message- dict.c: fix indention updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I3f210ae236f778fd0e8e7a17d01da21f65cb4e4b COMMIT: https://review.gluster.org/20768 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/src/dict.c: perform hash calc not under lock. If possible, perform the key hash calculation not under the dictionary lock. Compile-tested only! Change-Id: I88b6ed4eff6660d8334bc08ca4eebf61960e3ca1 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20769 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/src/dict.{c,h}: Introduce dict_setn, dict_addn, dict_addn and others. They all take as a parameter the key length, instead of strlen() it. In most cases, we know the key length, we just never bothered to save and pass it along. (We most likely sprintf'ed it earlier and the return value could have been used). A more interesting addition is dict_set_nstrn() [horrible name. Ideas are welcome]. It accepts both the string length and the key length and avoids strlen() both. Some of it can be calculated on compile-time, btw. For example: dict_set_str (dict, "key", "all"); Should become: dict_set_nstrn (dict, "key", sizeof ("key"), "all", sizeof ("all")); Compile-tested only! Change-Id: Ic2667f445f6c2e22e279505f5ad435788b4b668c updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/21018 (xlators/cluster/dht/src/dht-common.c: simplify some if statements) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21019 (libglusterfs/src/dict.c: fix to handle key=NULL.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20985 (shard: NULL pointer dereferencing clang fix) posted (#2) for review on master by Shwetha K Acharya COMMIT: https://review.gluster.org/20923 committed in master by "Amar Tumballi" <amarts> with a commit message- multiple files: move from strlen() to sizeof() {glusterfsd|glusterfsd-mgmt|quota-common-utils|xlator|tier|stripe}.c tools/setgfid2path/src/main.c xlators/cluster/afr/src/afr-inode-read.c {glusterfs-acl|glusterfs}.h For const strings, just do compile time size calc instead of runtime. Compile-tested only! Change-Id: I303684b1ff29b05c10126fb1057f507e404ced07 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/21031 (dht-common: NULL pointer dereferencing clang fix) posted (#1) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/21033 (Quota: Fix for clang issues) posted (#1) for review on master by sanoj-unnikrishnan COMMIT: https://review.gluster.org/21003 committed in master by "Amar Tumballi" <amarts> with a commit message- multiple files: remove unndeeded memset() This is a squash of multiple commits: contrib/fuse-lib/misc.c: remove unneeded memset() All flock variables are properly set, no need to memset it. Only compile-tested! Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I8e0512c5a88daadb0e587f545fdb9b32ca8858a2 libglusterfs/src/{client_t|fd|inode|stack}.c: remove some memset() I don't think there's a need for any of them. Only compile-tested! Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I2be9ccc3a5cb5da51a92af73488cdabd1c527f59 libglusterfs/src/xlator.c: remove unneeded memset() All xl->mem_acct members are properly set, no need to memset it. Only compile-tested! Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I7f264cd47e7a06255a3f3943c583de77ae8e3147 xlators/cluster/afr/src/afr-self-heal-common.c: remove unneeded memset() Since we are going over the whole array anyway, initialize it properly, to either 1 or 0. Only compile-tested! Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Ied4210388976b6a7a2e91cc3de334534d6fef201 xlators/cluster/dht/src/dht-common.c: remove unneeded memset() Since we are going over the whole array anyway it is initialized properly. Only compile-tested! Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Idc436d2bd0563b6582908d7cbebf9dbc66a42c9a xlators/cluster/ec/src/ec-helpers.c: remove unneeded memset() Since we are going over the whole array anyway it is initialized properly. Only compile-tested! Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I81bf971f7fcecb4599e807d37f426f55711978fa xlators/mgmt/glusterd/src/glusterd-volgen.c: remove some memset() I don't think there's a need for any of them. Only compile-tested! Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I476ea59ba53546b5153c269692cd5383da81ce2d xlators/mgmt/glusterd/src/glusterd-geo-rep.c: read() in 4K blocks The current 1K seems small. 4K is usually better (in Linux). Also remove a memset() that I don't think is needed between reads. Only compile-tested! Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I5fb7950c92d282948376db14919ad12e589eac2b xlators/storage/posix/src/posix-{gfid-path|inode-fd-ops}.c: remove memset() before sys_*xattr() functions. I don't see a reason to memset the array sent to the functions sys_llistxattr(), sys_lgetxattr(), sys_lgetxattr(), sys_flistxattr(), sys_fgetxattr(). (Note: it's unclear to me why we are calling sys_*txattr() functions with XATTR_VAL_BUF_SIZE-1 size instead of XATTR_VAL_BUF_SIZE ). Only compile-tested! Change-Id: Ief2103b56ba6c71e40ed343a93684eef6b771346 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/21038 (xlators/cluster/afr/src/afr-self-heal-common.c: unify some for loops) posted (#2) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20989 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/src/dict.c: allocate memory accurately. I suspect we've allocated and then set to '\0' an additional byte for no reason: gf_asprintf() allocates enough inc. the terminating null; data->len took that additional byte into account; memcpy() it back took care of that terminating null byte as well. Also, unrelated, implemented str_to_data() via strn_to_data(). Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I32c90e12974f51a0fbc0cfaebf9bd0fd722adc11 REVIEW: https://review.gluster.org/21041 (libglusterfs/src/dict.c: remove memcpy(), gf_asprintf -> asprintf) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21050 (glupy: clean up config and Makefile(.am)) posted (#1) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/21019 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/src/dict.c: fix to handle key=NULL. We don't want to strlen NULL strings. Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Id795998693ba410dbd80df962d48956a9e4164c4 COMMIT: https://review.gluster.org/21018 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/cluster/dht/src/dht-common.c: simplify some if statements Use goto when some vars are not set to simplify long if statements. Please review logic has not changed! Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I45ea2e906d0ccb468af5e1fa65db008edb00d734 COMMIT: https://review.gluster.org/20924 committed in master by "Amar Tumballi" <amarts> with a commit message- bit-rot xlator: strncpy()->sprintf(), reduce strlen()'s xlators/features/bit-rot/src/bitd/bit-rot-scrub-status.c xlators/features/bit-rot/src/stub/bit-rot-stub-helpers.c xlators/features/bit-rot/src/stub/bit-rot-stub.c xlators/features/bit-rot/src/stub/bit-rot-stub.h strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Ensure sprintf() results do not truncate. Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN or sizeof() for const strings. - move ret from int32 to int. Compile-tested only! Change-Id: Ib9b923c45d2d59ac15a105410e8160b252061018 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20927 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators: move from strlen() to sizeof() xlators/features/index/src/index.c xlators/features/shard/src/shard.c xlators/features/upcall/src/upcall-internal.c xlators/mgmt/glusterd/src/glusterd-bitrot.c xlators/mgmt/glusterd/src/glusterd-locks.c xlators/mgmt/glusterd/src/glusterd-mountbroker.c xlators/mgmt/glusterd/src/glusterd-op-sm.c For const strings, just do compile time size calc instead of runtime. Compile-tested only! Change-Id: I995b2b89f14454b3855a4cd0ca90b3f01d5e080f updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20929 committed in master by "Amar Tumballi" <amarts> with a commit message- multiple xlators: move from strlen() to sizeof() xlators/performance/nl-cache/src/nl-cache.c xlators/performance/md-cache/src/md-cache.c xlators/protocol/server/src/authenticate.c xlators/storage/bd/src/bd-helper.c For const strings, just do compile time size calc instead of runtime. Compile-tested only! Change-Id: I9b98940a38d85321a69436a1871930da367b918a updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20925 committed in master by "Amar Tumballi" <amarts> with a commit message- changelog xlator: strncpy()->sprintf(), reduce strlen()'s xlators/features/changelog/lib/src/gf-changelog-journal-handler.c xlators/features/changelog/lib/src/gf-changelog.c xlators/features/changelog/src/changelog-helpers.c xlators/features/changelog/src/changelog-misc.h strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Where possible, ensure there's no truncation of the output. Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN (sizeof() ) for const strings. - switch a strncpy to a memcpy. Compile-tested only! Change-Id: Ia7a52bce0b243613ad910192ec163c93d944e077 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20932 committed in master by "Amar Tumballi" <amarts> with a commit message- multiple xlators (storage/posix): strncpy()->sprintf(), reduce strlen()'s xlators/storage/posix/src/posix-gfid-path.c xlators/storage/posix/src/posix-handle.c xlators/storage/posix/src/posix-helpers.c xlators/storage/posix/src/posix-inode-fd-ops.c xlators/storage/posix/src/posix.h strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN (sizeof() ) for const strings. Compile-tested only! Change-Id: I056939f111a4ec6bc8ebd539ebcaf9eb67da6c95 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20926 committed in master by "Amar Tumballi" <amarts> with a commit message- changetimerecoder xlator: strncpy()->sprintf(), reduce strlen()'s xlators/features/changetimerecorder/src/changetimerecorder.c xlators/features/changetimerecorder/src/ctr-helper.h strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Check for output truncation where applicable. Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN (sizeof() ) for const strings. Compile-tested only! Change-Id: I2dd5629183222da8c9251af43b8b29aacf12a20a updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20928 committed in master by "Amar Tumballi" <amarts> with a commit message- NFS server (mount3.c, nfs-inodes.c): strncpy()->sprintf(), reduce strlen()'s xlators/nfs/server/src/mount3.c xlators/nfs/server/src/nfs-inodes.c strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Compile-tested only! Change-Id: Ibe74ccdb67434e9a10fc1f21c0b4cd5e4b8cb589 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20933 committed in master by "Amar Tumballi" <amarts> with a commit message- Various files: strncpy()->sprintf(), reduce strlen()'s strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Check for truncated output where applicable. Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN (sizeof() ) for const strings. Compile-tested only! Change-Id: I54e80d4f4a80e98d3775e376efe05c51af0b29eb updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/21063 (Some (mgmt) xlators: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn}) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20881 committed in master by "Pranith Kumar Karampuri" <pkarampu> with a commit message- xlators/cluster/afr/src/afr-inode-read.c: move to GF_MALLOC() instead of GF_CALLOC() when It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! Change-Id: Ief156de98769fea852553044a398a309e831754b updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20806 committed in master by "Amar Tumballi" <amarts> with a commit message- Multiple files: calloc -> malloc xlators/storage/posix/src/posix-inode-fd-ops.c: xlators/storage/posix/src/posix-helpers.c: xlators/storage/bd/src/bd.c: xlators/protocol/client/src/client-lk.c: xlators/performance/quick-read/src/quick-read.c: xlators/performance/io-cache/src/page.c xlators/nfs/server/src/nfs3-helpers.c xlators/nfs/server/src/nfs-fops.c xlators/nfs/server/src/mount3udp_svc.c xlators/nfs/server/src/mount3.c xlators/mount/fuse/src/fuse-helpers.c xlators/mount/fuse/src/fuse-bridge.c xlators/mgmt/glusterd/src/glusterd-utils.c xlators/mgmt/glusterd/src/glusterd-syncop.h xlators/mgmt/glusterd/src/glusterd-snapshot.c xlators/mgmt/glusterd/src/glusterd-rpc-ops.c xlators/mgmt/glusterd/src/glusterd-replace-brick.c xlators/mgmt/glusterd/src/glusterd-op-sm.c xlators/mgmt/glusterd/src/glusterd-mgmt.c xlators/meta/src/subvolumes-dir.c xlators/meta/src/graph-dir.c xlators/features/trash/src/trash.c xlators/features/shard/src/shard.h xlators/features/shard/src/shard.c xlators/features/marker/src/marker-quota.c xlators/features/locks/src/common.c xlators/features/leases/src/leases-internal.c xlators/features/gfid-access/src/gfid-access.c xlators/features/cloudsync/src/cloudsync-plugins/src/cloudsyncs3/src/libcloudsyncs3.c xlators/features/bit-rot/src/bitd/bit-rot.c xlators/features/bit-rot/src/bitd/bit-rot-scrub.c bxlators/encryption/crypt/src/metadata.c xlators/encryption/crypt/src/crypt.c xlators/performance/md-cache/src/md-cache.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! .. and allocate memory as much as needed. xlators/nfs/server/src/mount3.c : Don't blindly allocate PATH_MAX, but strlen() the string and allocate appropriately. Also, align error messges. updates: bz#1193929 Original-Author: Yaniv Kaul <ykaul> Signed-off-by: Yaniv Kaul <ykaul> Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Ibda6f33dd180b7f7694f20a12af1e9576fe197f5 COMMIT: https://review.gluster.org/20834 committed in master by "Amar Tumballi" <amarts> with a commit message- multiple files: calloc -> malloc xlators/cluster/stripe/src/stripe-helpers.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible xlators/cluster/dht/src/tier.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible xlators/cluster/dht/src/dht-layout.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible xlators/cluster/dht/src/dht-helper.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible xlators/cluster/dht/src/dht-common.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible xlators/cluster/afr/src/afr.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible xlators/cluster/afr/src/afr-inode-read.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible tests/bugs/replicate/bug-1250170-fsync.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible tests/basic/gfapi/gfapi-async-calls-test.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible tests/basic/ec/ec-fast-fgetxattr.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible rpc/xdr/src/glusterfs3.h: Move to GF_MALLOC() instead of GF_CALLOC() when possible rpc/rpc-transport/socket/src/socket.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible rpc/rpc-lib/src/rpc-clnt.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible extras/geo-rep/gsync-sync-gfid.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible cli/src/cli-xml-output.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible cli/src/cli-rpc-ops.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible cli/src/cli-cmd-volume.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible cli/src/cli-cmd-system.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible cli/src/cli-cmd-snapshot.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible cli/src/cli-cmd-peer.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible cli/src/cli-cmd-global.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! updates: bz#1193929 Original-Author: Yaniv Kaul <ykaul> Signed-off-by: Yaniv Kaul <ykaul> Signed-off-by: Amar Tumballi <amarts> Change-Id: I16274dca4078a1d06ae09a0daf027d734b631ac2 COMMIT: https://review.gluster.org/20934 committed in master by "Amar Tumballi" <amarts> with a commit message- {dht-rebalance|glusterd-geo-rep|glusterd-utils|nfs|bd}.c: no dict_del before dict_set There is no need to remove an item before re-setting it. Compile-tested only! Change-Id: I2869aec9ebf474859127b8b38d284246e6097e84 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/21081 (rfc.sh: use 'git log -n1' instead of 'git show') posted (#1) for review on master by Amar Tumballi COMMIT: https://review.gluster.org/20759 committed in master by "Amar Tumballi" <amarts> with a commit message- New flag to glusterfsd binary to print libexec dir New CLI option for `glusterfsd` binary to get the path of libexec directory. This helps glusterd2 to detect the installed path of `gsyncd` and other binaries. Usage: `glusterfsd --print-libexecdir` Updates: bz#1193929 Change-Id: I8c1a74afd9acec7ee7bd3deabed9d9f20fe3fb5f Signed-off-by: Aravinda VK <avishwan> COMMIT: https://review.gluster.org/20833 committed in master by "Sanju Rakonde" <srakonde> with a commit message- cli/src/cli-cmd-parser.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Ic1531afbf614823628cc8d70bae782d4db7ec033 COMMIT: https://review.gluster.org/20842 committed in master by "Atin Mukherjee" <amukherj> with a commit message- xlators/mgmt/glusterd/src/glusterd-log-ops.c : reduce size or re-scope message variable The the error and/or message variable was either: - Reduced in size - from 2048 bytes to 64 bytes, for example. or - Changed in scope - defined in a smaller scope. Compile-tested only! Change-Id: Ib8617db6c3646954c0225d12b904d668bf0f7046 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/21041 committed in master by "Yaniv Kaul" <ykaul> with a commit message- libglusterfs/src/dict.c: remove memcpy(), gf_asprintf -> asprintf 1. We don't need a temp. string to strotol(), we can use data->data. 2. We don't need the gf_asprintf, when a regular asprintf would do. 3. No need to CALLOC the data, can MALLOC, since we are going to populate most of the fields anyway. 4. Removed is_const member - it was not used. 5. Turned is_static to a gf_boolean_t 6. Turned another get_mem0 to get_mem (in dict_set_lk() func) 7. Remove dict_set_ptr - was exactly the same as dict_set_static_ptr (apart from the 'static' bit) and no one was using it. 8. Removed is_static from the dictionary object. Did not seem to be very useful. Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I7b1f6320867b154be4a94033819407f7e51cf38c COMMIT: https://review.gluster.org/20930 committed in master by "Amar Tumballi" <amarts> with a commit message- multiple xlators: strncpy()->sprintf(), reduce strlen()'s xlators/cluster/afr/src/afr-common.c xlators/cluster/dht/src/dht-common.c xlators/cluster/dht/src/dht-rebalance.c xlators/cluster/stripe/src/stripe-helpers.c strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN (sizeof() ) for const strings. Compile-tested only! Change-Id: Icdf79dd3d9f9ff120e4720ff2b8bd016df575c38 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/20825 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterfsd/src/glusterfsd.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. In some cases, also changed allocation size to be sizeof some struct or type instead of a pointer - easier to read. In some cases, removed redundant strlen() calls by saving the result into a variable. 1. Only done for the straightforward cases. There's room for improvement. 2. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Iaed86fcc909022c5158c3e08a9106b1110b9df0a COMMIT: https://review.gluster.org/20882 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/cluster/dht/src/dht-common.c :move to GF_MALLOC() instead of GF_CALLOC() when It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. Please review carefully, especially for string allocation, with the terminating NULL string (added another byte to ensure it's there). Only compile-tested! Change-Id: Ia5e4f50dfb0c29809c2019fcfd8079507813249e updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/21033 committed in master by "Amar Tumballi" <amarts> with a commit message- Quota: Fix for clang issues Updates: bz#1193929 Change-Id: I549f741fbf97ee3fa2d63edacee5b705ef37c49a Signed-off-by: sanoj-unnikrishnan <sunnikri> REVIEW: https://review.gluster.org/21113 (glusterd-sm: NULL pointer dereferencing clang fix) posted (#1) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/21113 (glusterd-sm: NULL pointer dereferencing clang fix) posted (#2) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/21115 (build: Make building of glupy more obvious) posted (#1) for review on master by Anoop C S REVIEW: https://review.gluster.org/21113 (glusterd-sm: NULL pointer dereferencing clang fix) posted (#3) for review on master by Atin Mukherjee COMMIT: https://review.gluster.org/21113 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd-sm: NULL pointer dereferencing clang fix Problem: new_event could be NULL. Solution: Added a goto statement to address this issue. Updates: bz#1193929 Change-Id: Id3ce28fc53ad2cc8b9fcb63f7774568d31073b9e Signed-off-by: Shwetha K Acharya <sacharya> COMMIT: https://review.gluster.org/20931 committed in master by "Atin Mukherjee" <amukherj> with a commit message- multiple xlators (mgmt): strncpy()->sprintf(), reduce strlen()'s xlators/mgmt/glusterd/src/glusterd-geo-rep.c xlators/mgmt/glusterd/src/glusterd-handshake.c xlators/mgmt/glusterd/src/glusterd-sm.c xlators/mgmt/glusterd/src/glusterd-store.c xlators/mgmt/glusterd/src/glusterd-utils.c xlators/mgmt/glusterd/src/glusterd-volgen.c xlators/mgmt/glusterd/src/glusterd-volume-ops.c xlators/mgmt/glusterd/src/glusterd.c strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Try to ensure output is not truncated. Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN (sizeof() ) for const strings. Compile-tested only! Change-Id: Ib5d001857236f43e41c4a51b5f48e1a33110aaeb updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> COMMIT: https://review.gluster.org/21063 committed in master by "Atin Mukherjee" <amukherj> with a commit message- Some (mgmt) xlators: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn} In a previous patch (https://review.gluster.org/20769) we've added the key length to be passed to dict_* funcs, to remove the need to strlen() it. This patch moves some xlators to use it. - It also adds dict_get_int32n which was missing. - It also reduces the size of some key variables. They were set to 1024b or PATH_MAX, where sometimes 64 bytes were really enough. Please review carefully: 1. That I did not reduce some the size of the key variables too much. 2. That I did not mix up some keys. Compile-tested only! Change-Id: Ic729baf179f40e8d02bc2350491d4bb9b6934266 updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/21124 (extras/hooks: General improvements to S30samba-start.sh) posted (#1) for review on master by Anoop C S COMMIT: https://review.gluster.org/20883 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/cluster/dht/src/tier-common.c:move to GF_MALLOC() instead of GF_CALLOC() when It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! Change-Id: I7d38a7d576f6777976fe86e5351a8d95caddbb9c updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> REVIEW: https://review.gluster.org/21128 (ec-heal: remove a duplicate definition of alloca0) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21130 (posix: fix the duplicate macro definitions) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21131 (DHT/AFR/mgmt xlators: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn}) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/21128 committed in master by "Amar Tumballi" <amarts> with a commit message- ec-heal: remove a duplicate definition of alloca0 the same macro is defined in common-utils.h, which seems to be much better place for the same. Updates: bz#1193929 Change-Id: I409b719c291102136500b955e5827a550142ed96 Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/21130 committed in master by "Amar Tumballi" <amarts> with a commit message- posix: fix the duplicate macro definitions the macro 'PATH_SET_TIMESPEC_OR_TIMEVAL' is defined in posix.h, which seems to be good place for it updates: bz#1193929 Change-Id: I521a2a6efeb26891c24637a5f06b1d90c00b1135 Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/21139 (packaging: glusterfs.spec(.in) cleanup) posted (#1) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/21115 committed in master by "Amar Tumballi" <amarts> with a commit message- build: Make building of glupy more obvious Yet again glupy..!! Core changes: * Provide --disable-glupy(instead of --enable-glupy) since we try to build it by default. * AC_SUBST macro is considered/executed even if it is inside an if condition. As a result GLUPY_SUBDIR was always substituted which in turn would make compilation enter glupy/ translator sources in absence of python{2/3}-devel and fails. Miscellaneous changes: * Remove an explicit echo for printing PYTHON version. * Replace hard coded python version in warning message displayed in absence of python{2/3}-devel. * Redirect pushd and popd output to /dev/null Change-Id: If1ba30a12a8bda5763ef528787fccb2f7946b136 Updates: bz#1193929 Signed-off-by: Anoop C S <anoopcs> REVIEW: https://review.gluster.org/21140 (misc: fix misc. shebangs) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21142 (mgmt xlators: store boolean fields using integer) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/21081 committed in master by "Vijay Bellur" <vbellur> with a commit message- rfc.sh: use 'git log -n1' instead of 'git show' This is required mainly because if we use any format in a documentation, and it has strings which are looking for commit msg format (like fixes: bz...) in document, that too will be considered in checks, even though it is not part of commit msg. By using git log -n1, we would only check the content of commit msg. Updates: bz#1193929 Change-Id: I498590de6d3daa6be7bcbee1f083ef3fa6ecc96f Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/21144 (xlators/mgmt/glusterd/src/glusterd-volgen.c: use dict_ new functions) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/20541 committed in master by "Vijay Bellur" <vbellur> with a commit message- doc: add details on how the commit should be structured Detailing how the commit message should be is very important for imposing some structure, and good practises. Also it helps new developers to do the right things. This is mostly copied from the OpenStack commit message reference, as it was overlapping with most of the things we follow in GlusterFS. Made minor changes to make it suitable for Gluster project. Updates: bz#1193929 Change-Id: I4dcd7ff366edfc6c1727a287f32bcf7270c86b11 Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/21140 committed in master by "Amar Tumballi" <amarts> with a commit message- misc: fix misc. shebangs * One #!/usr/bin/env python and three #!/usr/bin/python were overlooked in all the other python fixups. Ugh. * Two new python files missed the memo about #!/usr/bin/python3. * One #!/usr/bin/env bash. Various distribution packaging policies have strong wording about the use of #!/usr/bin/env ... Note: this patch does not change the use of #!/usr/bin/env bash in the two files extras/{clang-checker.sh,check_goto.pl} as these are not included in any packages. (Although I'm not actually sure why anyone would ever use '/usr/bin/env {sh,bash}' as I'm not aware of any version-specific differences like there are with, e.g., python.) * One #!/usr/bin/bash. On Fedora and CentOS > 6, /bin is a symlink to /usr/bin, so it makes little difference. But Debian & Ubuntu still have separate /bin and /usr/bin; and sh and bash are in /bin, not /usr/bin. (Historically, in BSD and SYSV Unix it was /bin/sh.) Note: Fedora and CentOS package build runs a script that converts all /bin/sh and /bin/bash to /usr/bin/sh and /usr/bin/bash. Change-Id: I9171265829af78dd0cd7622c22b56d22179ff8a3 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> COMMIT: https://review.gluster.org/21142 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt xlators: store boolean fields using integer Surprisingly, there is not set_boolean() as there is a get_boolean() In fact, it is stored as an INT dictionary type. In some occasions it was stored using a string, and this caused errors such as: key gfproxy-server, integer type asked, has string type [Invalid argument] I've fixed what I saw in some logs, I'm sure there are more. The CORRECT fix is to create a boolean set and use it, but this requires a bit more work. I'll see if I can do it later on. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I45fd0c7a0824b2f42b8ce510296c9dfa4f32ad66 REVIEW: https://review.gluster.org/21148 (libglusterfs/src/dict.c : use xxhash64 for hashing.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21152 (doc: make developer-index.md as README) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21155 (build: cleanup xlator link, --no-undefined, libuuid) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21157 (build: cleanup xlator link, --no-undefined, libuuid) posted (#1) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/20542 committed in master by "Vijay Bellur" <vbellur> with a commit message- doc: add coding-standard and commit-msg link in README Having the links in README makes people follow it if they browse through github. Updates: bz#1193929 Change-Id: I580332a41d9b52858aa9796a74a563ff57a60b4b Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/21152 committed in master by "Amar Tumballi" <amarts> with a commit message- doc: make developer-index.md as README This helps to traverse the docs well as README.md is rendered by default in github pages, and would help to provide better indexed document for new users. updates: bz#1193929 Change-Id: I4130dfd16aed924ecab17f96326cedb86892d6a6 Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/21157 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- build: cleanup xlator link, --no-undefined, libuuid While attempting to build a (pre-)5.0 of glusterfs on Ubuntu bionic and cosmic, it became apparent that there are some gremlins hiding in the combination of the xlator export-symbols, the newish addition of -Wl,--no-undefined, and the new switch to libuuid from the old contrib/uuid. Note: even though Fedora 28 (and later) and Ubuntu bionic (and later) have the same nominal version of libtool, the Fedora version appears to do a better job of recursing through dependencies to determine the libraries to link with. Examination of the build logs showed that despite appearing to work on Fedora, not all xlators and shared libs were linked with -Wl, --no-undefined, and -luuid. And in the case of the gnfs xlator, it was not only not linked with -Wl,--no-undefined but alsos not linked with -lgfxdr and -lgfrpc. Added GF_XLATOR_LDFLAGS, similar to GF_XLATOR_DEFAULT_LDFLAGS. GF_XLATOR_DEFAULT_LDFLAGS is for xlators that export/expose the default or common set of symbols. GF_XLATOR_LDFLAGS is for those remaining xlators that export/expose non-default symbols, e.g. dht and glupy. This removes the need in the future to add things like $(UUID_LIBS) to every xlator's Makefile.am. Just add it to GF_XLATOR_LDFLAGS and GF_XLATOR_DEFAULT_LDFLAGS in configure.ac and you're done. This patch was tested on Fedora 28 (build, rpmbuild), Fedora Rawhide/30 (rpmbuild), RHEL8 (rpmbuild), CentOS7 (rpmbuild), Fedora koji --scratch build for f30/rawhide, and a Launchpad build for Ubuntu cosmic/18.10. Change-Id: Ieca104fa5c5d3c094e701c8ca4a73754dd0292b0 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> REVIEW: https://review.gluster.org/21178 (AFR xlator: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn}) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/21124 committed in master by "Amar Tumballi" <amarts> with a commit message- extras/hooks: General improvements to S30samba-start.sh Based on https://review.gluster.org/c/glusterfs/+/19204 from Milan Zink <mzink> Change-Id: I61f62407a62475a74a6cc046c24748a31c66e6cd Updates: bz#1193929 Signed-off-by: Anoop C S <anoopcs> REVIEW: https://review.gluster.org/21183 (gfapi: Cleanup alias file) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/21184 (api: old and new versioned symbols must appear in each section of gfapi.map) posted (#1) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/21148 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/src/dict.c : use xxhash64 for hashing. As part of a larger effort to consolidate hash functions and use a faster, with less collissions, I've moved to use xxhash as the hashing function for the dictionary. Note: I'm using only 32 bits of the hashes, as the hash field is currently a 32 bit variable. There's room (since the struct is not packed) to move to use a 64bit variable. Donno how it'll affect performance. Only compile-tested! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Ie244efd1368234e54dd5957ee1ae5bebd7d9409a COMMIT: https://review.gluster.org/21183 committed in master by "Amar Tumballi" <amarts> with a commit message- gfapi: Cleanup alias file 2 extra symbols were in the alias file, that are not exported this is cleaned up with this patch. Change-Id: I1ab54b9fb6b0d455884fbbfd89820c60bb861e6f Updates: bz#1193929 Signed-off-by: ShyamsundarR <srangana> COMMIT: https://review.gluster.org/21139 committed in master by "Amar Tumballi" <amarts> with a commit message- packaging: glusterfs.spec(.in) cleanup Someone (not me) once alphabetized all the %package, %files, and etc. sections, with a comment to keep them alphabetized. Move cloudsync sections to their correct locations in the spec. Also reorder testing and playground within %files section, keep testing %dirs together. Change-Id: I79e2e7a82d20275fd61d018880bcb5913c8f75f3 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> REVIEW: https://review.gluster.org/21187 (logrotate: utilize the new 'maxsize' option) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21198 (glusterd: Improve logging in gd_mgmt_v3_unlock_timer_cbk) posted (#1) for review on master by Atin Mukherjee COMMIT: https://review.gluster.org/21187 committed in master by "Amar Tumballi" <amarts> with a commit message- logrotate: utilize the new 'maxsize' option Since logrotate 3.8.x version, a new option 'maxsize' is supported, which helps in rotating the logs before the specified time if the size exceeds maxsize limit. This should help in reducing the overflow of gluster logs. Updates: bz#1193929 Change-Id: Id33c34d72f1931e7996893de9338db667e1e900d Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/21227 (glusterd: fix test case failure) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/21198 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: Improve logging in gd_mgmt_v3_unlock_timer_cbk Change-Id: I3335e7df3256d97c2211b64cfcaac9a016723471 Updates: bz#1193929 Signed-off-by: Atin Mukherjee <amukherj> COMMIT: https://review.gluster.org/21227 committed in master by "Atin Mukherjee" <amukherj> with a commit message- tests: fix test case failure tests/bugs/glusterd/bug-1595320.t is failing in downstream. In downstream repo, enabling the brick multiplexing made interactive, so it will throw an prompt for the user input. As no input is provided during the test case execution, the test is failing. Using macro CLI instead of using gluster command, will bypass the interacive commands. so replacing the gluster command with CLI macro will address the issue. Change-Id: I6b39052d8e415a8ed08de7c80a91dadce155146a updates: bz#1193929 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/21238 (doc: add a new contributor 'hints' guide) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21243 (glusterd: reduce length allocated to name) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21246 (georep: fix hard-coded paths in gsyncd.conf.in) posted (#1) for review on release-4.1 by Kaleb KEITHLEY COMMIT: https://review.gluster.org/21243 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: reduce length allocated to name In glusterd_proc_ and glusterd_svc_ structures name is having length of PATH_MAX, allocating NAME_MAX will be sufficient. Change-Id: I637ba00e1a80ca6a1ecc0c2dbf180c4633c1ca5b updates: bz#1193929 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/21248 (Quota related files: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn}) posted (#1) for review on master by Yaniv Kaul REVISION POSTED: https://review.gluster.org/21246 (georep: fix hard-coded paths in gsyncd.conf.in) posted (#2) for review on release-4.1 by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21253 (README: add a section for giving hints on testing) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21259 (geo-rep : fix log message in master.py) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21259 committed in master by "Sunny Kumar" <sunkumar> with a commit message- geo-rep : fix log message in master.py This patch fixes spell mistake in log message. Change-Id: I84779c64aef6698cbc1a60ae1a82533e8a6a6e3d updates: bz#1193929 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21268 (cli: handle negative scenarios) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/21184 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- api: old and new versioned symbols must appear in each section of gfapi.map It's probably not clear in .../doc/developer-guide/gfapi-symbol-versions.md that this is necessary, but it is. Change-Id: I0a8a74e3ecf474c93583f5ebc97507c4277542b0 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> COMMIT: https://review.gluster.org/21248 committed in master by "Amar Tumballi" <amarts> with a commit message- Quota related files: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn} In a previous patch (https://review.gluster.org/20769) we've added the key length to be passed to dict_* funcs, to remove the need to strlen() it. This patch moves some code to use it. Please review carefully. Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: If4f425a9827be7c36ccfbb9761006ae824a818c6 REVIEW: https://review.gluster.org/21268 (cli: handle negative scenarios) posted (#4) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21296 (libglusterfs/dict: Add sizeof()-1 variants of dict functions) posted (#1) for review on master by Pranith Kumar Karampuri COMMIT: https://review.gluster.org/21268 committed in master by "Amar Tumballi" <amarts> with a commit message- cli: handle negative scenarios When control flow reaches negative case code block, we added "goto out" statement without assigning ret to -1. This patch assigns return value to -1, before going to the lable "out". Change-Id: I6db651a3c9ca285ade9ee1ca23d0abe6b36fda3a updates: bz#1193929 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/21313 (dht: volume_options 'options' collision with nfs-ganesha's 'options') posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21327 (stripe: remove from build) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21328 (nufa and switch: remove from build) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21329 (decompounder: remove from the build) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21331 (tiering: remove from the build) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21332 (glupy: remove from the build) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21341 (Reduce execution time of bug-1559004-EMLINK-handling.t) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/21341 (Reduce execution time of bug-1559004-EMLINK-handling.t) posted (#2) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/21313 (dht: volume_options 'options' collision with nfs-ganesha's 'options') posted (#4) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/21355 (packaging: remove RHEL5-isms from glusterfs.spec(.in)) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21360 (glusterd: set integer instead of string) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21368 (tests: correction in tests/bugs/glusterd/optimized-basic-testcases-in-cluster.t) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/21355 committed in master by "Amar Tumballi" <amarts> with a commit message- packaging: remove RHEL5-isms from glusterfs.spec(.in) CentOS5 too It's been a couple of years since we stopped doing anything with RHEL/CentOS 5 Change-Id: I83e78fa84b93fa5baddaf3fab92736d692a9bbca updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> COMMIT: https://review.gluster.org/21361 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/src/logging.c: reduce the use of strings I did not see a good reason to copy the temp strings str1 and str2 into msg string, and just used str1 (sprintf'ed str2 into it first). Hope it makes logging somewhat faster, but I also hope there's more room for improvement for faster logging. Renamed str1 to logline and str2 to msg for better readability. Also, remove dead assignment in _gf_msg() (clang complained). Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I19457d705c0b043937d96a4db35d087bb8e9b35a REVIEW: https://review.gluster.org/21385 (build/packaging/core: add glusterfs.pc(.in)) posted (#1) for review on master by Kaleb KEITHLEY REVISION POSTED: https://review.gluster.org/21385 (build/packaging/core: add glusterfs.pc(.in)) posted (#3) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/21253 committed in master by "Amar Tumballi" <amarts> with a commit message- README: add a section for giving hints on testing Change-Id: I1529494504c38172f56759c0f06231864e32df24 updates: bz#1193929 Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/21395 (libglusterfs: fix log message in options.c) posted (#3) for review on master by Sheetal Pamecha COMMIT: https://review.gluster.org/21395 committed in master by "Sunny Kumar" <sunkumar> with a commit message- libglusterfs: fix log message in options.c This patch fixes https://github.com/gluster/glusterfs/issues/519 Credits: "Fabian Wannenmacher <@wanneut>" Updates: bz#1193929 Change-Id: If8d60c3379093a868ad6ba8c2ad86a4b99d35f2c Signed-off-by: Sheetal Pamecha <sheetal.pamecha08> REVIEW: https://review.gluster.org/21404 (servers-helpers.c: reduce clang warnings on dead initialization.) posted (#1) for review on master by Yaniv Kaul COMMIT: https://review.gluster.org/21296 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/dict: Add sizeof()-1 variants of dict functions One needs to be very careful about giving same key for the key and SLEN(key) arguments in dict_xxxn() functions. Writing macros that would take care of passing the SLEN(key) would help reduce this burden on the developer and reviewer. updates: bz#1193929 Change-Id: I312c479b919826570b47ae2c219c53e2f9b2ddef Signed-off-by: Pranith Kumar K <pkarampu> REVIEW: https://review.gluster.org/21420 (core: libuuid-devel breakage) posted (#1) for review on master by Kaleb KEITHLEY COMMIT: https://review.gluster.org/21420 committed in master by "Amar Tumballi" <amarts> with a commit message- core: libuuid-devel breakage The #include "uuid.h" left over from using .../contrib/uuid is debatably incorrect now that we use the "system header" file /usr/include/uuid/uuid.h from libuuid-devel. Unfortunately this is complicated by things like FreeBSD having its own /usr/include/uuid.h, and the e2fsprogs-libuuid uuid.h in installed - as most third-party packages in FreeBSD are - in /usr/local as /usr/local/include/uuid/uuid.h With a system header file it should at least be #include <uuid.h>, and even better as #include <uuid/uuid.h>, much like the way <sys/types.h> and <net/if.h> are included. Using #include <uuid/uuid.h> guarantees not getting the /usr/include/uuid.h on FreeBSD, but clang/cc knows to find "system" header files like this in /usr/local/include; with or without the -I/... from uuid.pc. Also using #include "uuid.h" leaves the compiler free to find a uuid.h from any -I option it might be passed. (Fortunately we don't have any at this time.) As we now require libuuid-devel or e2fsprogs-libuuid and configure will exit with an error if the uuid.pc file doesn't exist, the HAVE_LIBUUID (including the #elif FreeBSD) tests in compat-uuid.h are redundant. We are guaranteed to have it, so testing for it is a bit silly IMO. It may also break building third party configure scripts if they omit defining it. (Just how hard do we want to make things for third party developers?) Change-Id: I7317f63c806281a5d27de7d3b2208d86965545e1 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> COMMIT: https://review.gluster.org/21401 committed in master by "Amar Tumballi" <amarts> with a commit message- Multiple xlators: perform gettimeofday() not under lock While it may slightly reduce accuracy, I think it's better to acquire the time outside a lock and then memcpy the value while under lock. Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: Ic8fb94a56c4fa2d3b13e59767e13646fb39342ba COMMIT: https://review.gluster.org/21404 committed in master by "Amar Tumballi" <amarts> with a commit message- servers-helpers.c: reduce clang warnings on dead initialization. Assign a value to a parameter on its definition. Removes tens of clang warnings. Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul> Change-Id: I828bacb4033111af6162772a554cc5c6b2820169 REVISION POSTED: https://review.gluster.org/21432 (core: libuuid-devel breakage) posted (#2) for review on release-5 by Kaleb KEITHLEY REVISION POSTED: https://review.gluster.org/21332 (glupy: remove from the build) posted (#2) for review on master by Amar Tumballi REVISION POSTED: https://review.gluster.org/21331 (tiering: remove the translator from build and glusterd) posted (#2) for review on master by Amar Tumballi REVISION POSTED: https://review.gluster.org/20702 (bd: remove from the build) posted (#3) for review on master by Amar Tumballi REVISION POSTED: https://review.gluster.org/21329 (decompounder: remove the translator from build and glusterd) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21470 (xlator: add generic option parsing framework) posted (#1) for review on master by Amar Tumballi COMMIT: https://review.gluster.org/21360 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterd: set integer instead of string dict_get_str_boolean expects a integer, so we need to set all the boolean variables as integers to avoid log messages like below: [2018-09-10 03:55:19.236387] I [dict.c:2838:dict_get_str_boolean] (-->/usr/local/lib/libgfrpc.so.0(rpc_clnt_reconnect+0xc2) [0x7ff7a83d0452] -->/usr/local/lib/glusterfs/4.2dev/rpc-transport/socket.so(+0x65b0) [0x7ff7a06cf5b0] -->/usr/local/lib/libglusterfs.so.0(dict_get_str_boolean+0xcf) [0x7ff7a85fc58f] ) 0-dict: key transport.socket.ignore-enoent, integer type asked, has string type [Invalid argument] This patch addresses all such instances in glusterd. Change-Id: I7e1979fcf381363943f4d09b94c3901c403727da updates: bz#1193929 Signed-off-by: Sanju Rakonde <srakonde> REVISION POSTED: https://review.gluster.org/21368 (tests: correction in tests/bugs/glusterd/optimized-basic-testcases-in-cluster.t) posted (#2) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21502 (build/packaging: el-X (x > 7) isms) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21503 (glusterfsd: Make each multiplexed brick sign in) posted (#1) for review on master by Prashanth Pai REVIEW: https://review.gluster.org/21502 (build/packaging: el-X (x > 7) isms) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21536 (logging: create parent dir if not available) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21470 (xlator: add generic option parsing framework) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21541 (libglusterfs/src/iobuf.c: remove some if statements) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21542 (libglusterfs/src/iobuf.c: take the pool lock once in new pool) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21543 (libglusterfs/src/iobuf.c: where possible, pass the index parameter) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21536 (logging: create parent dir if not available) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21541 (libglusterfs/src/iobuf.c: remove some if statements) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21543 (libglusterfs/src/iobuf.c: where possible, pass the index parameter) posted (#6) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21542 (libglusterfs/src/iobuf.c: take the pool lock once in new pool) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21238 (doc: add a new contributor 'hints' guide) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21567 (tests/interrupt.t: remove 'stripe' volume type) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21567 (tests/interrupt.t: remove 'stripe' volume type) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21571 (cluster/afr: s/uuid_is_null/gf_uuid_is_null) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/21573 (libglusterfs/src/iobuf.c: don't forget to unlock a mutex) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21573 (libglusterfs/src/iobuf.c: don't forget to unlock a mutex) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21571 (cluster/afr: s/uuid_is_null/gf_uuid_is_null) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21581 (libglusterfs/src/iobuf.c: small refactor to re-use code.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21591 (rpc-clnt*: several code changes to reduce conn lock times) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21592 (rpc/rpc-lib/src/rpc-clnt.c: unlock sooner, if we fail to connect.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21597 (cli: avoid unnecessary strtail for geo rep config.) posted (#1) for review on master by Ravishankar N REVIEW: https://review.gluster.org/21599 (core: fix strncpy warnings) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21609 (libglusterfs/src/mem-pool.h: properly align structures) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21613 (core: fix strncpy warnings) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21615 (core: fix strncpy warnings) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21597 (cli: avoid unnecessary strtail for geo rep config.) posted (#2) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21452 (libglusterfs multiple files: remove dead initilization) posted (#11) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21591 (rpc-clnt*: several code changes to reduce conn lock times) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21503 (glusterfsd: Make each multiplexed brick sign in) posted (#4) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21629 (mem-pool.{c|h}: mem-pool small cleanups, const, static & code re-order) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21637 (glusterd/snapshot: copy-paste typo) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21637 (glusterd/snapshot: copy-paste typo) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21592 (rpc/rpc-lib/src/rpc-clnt.c: unlock sooner, if we fail to connect.) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21615 (core: fix strncpy warnings) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21613 (core: fix strncpy warnings) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21657 (libglusterfs/src/mem-types.h: remove unused common enums from mem-types.h) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21663 (libglusterfs/src/common-utils.h: faster mem_0filled() function) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21666 (core: fix strncpy, coverity annotation) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21666 (core: fix strncpy, coverity annotation) posted (#2) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21663 (libglusterfs/src/common-utils.h: faster mem_0filled() function) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21704 (Coverity fix for calling risky function - fscanf) posted (#1) for review on master by Poornima G REVIEW: https://review.gluster.org/21710 (rpc *.h fles: align structs) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21704 (Coverity fix for calling risky function - fscanf) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21714 (xlators/mgmt/glusterd/src/glusterd-volgen.c: use dict_ new functions) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21715 (libglusterfs/src/dict.c : consistent initialization of parameters.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/20633 (coding-standard: memset before string functions similar to sprintf/snprintf etc) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21715 (libglusterfs/src/dict.c : consistent initialization of parameters.) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21727 (mem-pool: minor fix and clarification) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/21728 (core: ctx calls naked malloc()) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21729 (glusterd: volume-ops calls naked malloc) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21727 (mem-pool: minor fix and clarification) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21729 (glusterd: volume-ops calls naked malloc) posted (#2) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21728 (core: ctx calls naked calloc()) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21746 (libglusterfs: Move devel headers under glusterfs directory) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/21754 (Multiple xlator .h files: remove unused private gf_* memory types.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21754 (Multiple xlator .h files: remove unused private gf_* memory types.) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21772 (Multiple fuse related files: several modifications) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21775 (Multiple posix related files: several modifications) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21710 (rpc *.h fles: align structs) posted (#6) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21794 (tests/geo-rep: Mask failure of geo-rep arbiter test) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/21581 (libglusterfs/src/iobuf.c: small refactor to re-use code.) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21714 (xlators/mgmt/glusterd/src/glusterd-volgen.c: use dict_ new functions) posted (#7) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21794 (tests/geo-rep: Mask failure of geo-rep arbiter test) posted (#2) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/21746 (libglusterfs: Move devel headers under glusterfs directory) posted (#6) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21830 (cli* files: several minor fixes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21833 (dict.c/h : hack for int32 - do not convert to string.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21846 (afr: some minor itable related cleanups) posted (#1) for review on master by Ravishankar N REVIEW: https://review.gluster.org/21846 (afr: some minor itable related cleanups) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21775 (Multiple posix related files: several modifications) posted (#8) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21848 (selinux/glusterd : add \"features.selinux\" t glusterd-volume-set.c) posted (#3) for review on master by jiffin tony Thottan REVIEW: https://review.gluster.org/21865 (xlators/cluster/afr/src/afr-self-heal-common.c: remove a variable array.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21867 (xlators/cluster/afr/src/afr-self-heal-common.c: remove a variable array.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21871 (dict.c/h: minor changes) posted (#1) for review on master by Yaniv Kaul REVISION POSTED: https://review.gluster.org/21848 (selinux/glusterd : add \"features.selinux\" to glusterd-volume-set.c) posted (#4) for review on master by jiffin tony Thottan REVIEW: https://review.gluster.org/21178 (AFR xlator: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn}) posted (#19) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/21867 (xlators/cluster/afr/src/afr-self-heal-common.c: remove a variable array.) posted (#3) for review on master by Ravishankar N REVIEW: https://review.gluster.org/21891 (run-tests.sh: add buffer time for retried tests) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21909 (libglusterfs/src/iobuf.c: remove redundant NULL checks) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21920 (fd.c : remove redundant checks) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21923 (inode.c and related files: remove redundant NULL checks) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21929 (Many files: redo include files.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21936 (barrier: replace boolean-switch statement with if/else) posted (#2) for review on master by Niels de Vos REVIEW: https://review.gluster.org/21940 (all: toward better string copies) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21936 (barrier: replace boolean-switch statement with if/else) posted (#3) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21951 (Multiple files: reduce work while under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21956 (configure: fix the duplicate CFLAGS options) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21657 (libglusterfs/src/mem-types.h: remove unused common enums from mem-types.h) posted (#17) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21971 (all: toward better string copies) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21977 (timer-wheel: run the timer function outside of locked region) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21978 (syncop: move CALLOC -> MALLOC) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21982 (extras: Add readdir-ahead to samba group command) posted (#1) for review on master by Anoop C S REVIEW: https://review.gluster.org/21987 (glfs-fops.c: fix the bad string length for snprintf) posted (#1) for review on master by Kinglong Mee REVIEW: https://review.gluster.org/21982 (extras: Add readdir-ahead to samba group command) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21987 (glfs-fops.c: fix the bad string length for snprintf) posted (#2) for review on master by Niels de Vos REVIEW: https://review.gluster.org/21977 (timer-wheel: run the timer function outside of locked region) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22008 (tests: increase the timeout for distribute bug 1117851.t) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22008 (tests: increase the timeout for distribute bug 1117851.t) posted (#2) for review on master by N Balachandran REVIEW: https://review.gluster.org/21956 (configure: fix the duplicate CFLAGS options) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22074 (tests/bug-brick-mux-restart: add extra information) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22074 (tests/bug-brick-mux-restart: add extra information) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22094 (core: make gf_thread_create() easier to use) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22114 (api: bad GFAPI_4.1.6 block) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/21951 (Multiple files: reduce work while under lock.) merged (#14) on master by Amar Tumballi REVIEW: https://review.gluster.org/22114 (api: bad GFAPI_4.1.6 block) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22130 (syncop: remove unnecessary call to gf_backtrace_save()) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22130 (syncop: remove unnecessary call to gf_backtrace_save()) merged (#2) on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/22094 (core: make gf_thread_create() easier to use) merged (#5) on master by Xavi Hernandez REVIEW: https://review.gluster.org/22157 (fuse: correctly handle setxattr values) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22158 (glusterd: Update op-version for release 7) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/22159 (api: Update all future API versions to rel-6) posted (#1) for review on master by Shyamsundar Ranganathan COMMIT: https://review.gluster.org/22158 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- glusterd: Update op-version for release 7 Change-Id: I0f3978d7e603e6e767dc7aa2a23ef35b1f2b43f7 Updates: bz#1193929 Signed-off-by: ShyamsundarR <srangana> REVIEW: https://review.gluster.org/22171 (glusterd: improve logging) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22157 (fuse: correctly handle setxattr values) merged (#6) on master by Amar Tumballi REVIEW: https://review.gluster.org/22159 (api: Update all future API versions to rel-6) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22171 (glusterd: improve logging) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22182 (fuse: reflect the actual default for lru-limit option) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22182 (fuse: reflect the actual default for lru-limit option) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22194 (logging.c: do not strlen() under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22196 (dht-shared.c: minor reduction of work under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22197 (fuse: reflect the actual default for lru-limit option) posted (#1) for review on release-6 by Amar Tumballi REVIEW: https://review.gluster.org/22198 (fuse: reflect the actual default for lru-limit option) posted (#1) for review on release-5 by Amar Tumballi REVIEW: https://review.gluster.org/22199 (auth-cache.c: minor reduction of work under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22200 (md-cache.c: minor reduction of work under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22201 (server.c: use dict_() funcs with key length.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22207 (rfc.sh: fix the missing rebase issue) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22207 (rfc.sh: fix the missing rebase issue) merged (#1) on master by Amar Tumballi REVIEW: https://review.gluster.org/22212 (docs: fix typo in Developer Guide Readme) posted (#4) for review on master by Csaba Henk REVIEW: https://review.gluster.org/22213 (fuse lock interrupt: fix flock_interrupt.t) posted (#3) for review on master by Csaba Henk REVIEW: https://review.gluster.org/22214 (upcall: some modifications to reduce work under lock) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22212 (docs: fix typo in Developer Guide Readme) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/22196 (dht-shared.c: minor reduction of work under lock.) merged (#2) on master by N Balachandran REVIEW: https://review.gluster.org/22222 (leases-internal.c: minor reduction of work under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22200 (md-cache.c: minor reduction of work under lock.) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/22201 (server.c: use dict_() funcs with key length.) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22199 (auth-cache.c: minor reduction of work under lock.) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22233 (glusterd: fix get-state leak) posted (#2) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22214 (upcall: some modifications to reduce work under lock) merged (#3) on master by soumya k REVISION POSTED: https://review.gluster.org/22197 (fuse: reflect the actual default for lru-limit option) posted (#2) for review on release-6 by Amar Tumballi REVISION POSTED: https://review.gluster.org/22198 (fuse: reflect the actual default for lru-limit option) posted (#2) for review on release-5 by Amar Tumballi REVIEW: https://review.gluster.org/22233 (glusterd: fix get-state leak) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22257 (glusterfind: revert shebangs to #!/usr/bin/python3) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/22222 (leases-internal.c: minor reduction of work under lock.) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22257 (glusterfind: revert shebangs to #!/usr/bin/python3) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/22274 (mem-pool.{c|h}: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22275 (glusterfind: revert shebangs to #!/usr/bin/python3) posted (#1) for review on release-6 by Kaleb KEITHLEY REVIEW: https://review.gluster.org/22277 (logging.c: replace get_mem0() with get_mem()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22278 (io-threads.c: Potentially skip a lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22279 (fd.c: try to skip a lock in fd_ref()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22281 (Replace memdup() with gf_memdup()) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/22291 (fd.c : remove redundant checks, CALLOC -> MALLOC) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22292 (inode.c/h: CALLOC->MALLOC) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22293 (stack.h: alignment of structures and met_get0 -> mem_get) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22298 (packaging: s390x has RDMA support) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/22213 (fuse lock interrupt: fix flock_interrupt.t) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/22302 (core: avoid dynamic TLS allocation when possible) posted (#2) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22312 (packaging: remove unnecessary ldconfig in scriptlets) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/22298 (packaging: s390x has RDMA support) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/22312 (packaging: remove unnecessary ldconfig in scriptlets) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22328 (tests/afr: add a test case for replica 4 config) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22329 (logging.c/h: aggressively remove sprintfs()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22365 (mount/fuse: Fix spelling mistake) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22365 (mount/fuse: Fix spelling mistake) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22371 (rpc* : move to use dict_n functions where possible) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22373 (glusterd-locks: misc. changes.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22381 (Multiple files: remove HAVE_BD_XLATOR related code.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22373 (glusterd-locks: misc. changes.) merged (#6) on master by Yaniv Kaul REVISION POSTED: https://review.gluster.org/22381 (Multiple files: remove HAVE_BD_XLATOR related code.) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22384 (server.c: fix Coverity CID 1399758) posted (#1) for review on master by Yaniv Kaul REVISION POSTED: https://review.gluster.org/22384 (server.c: fix Coverity CID 1399758) posted (#2) for review on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/22387 (changelog: remove unused code.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22391 (build: link libgfrpc with MATH_LIB (libm, -lm)) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/22394 (mem-pool: remove dead code.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22406 (cluster/afr: Remove un-used variables related to pump) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22416 ([RFC][WIP] dict: add function to retrieve a key based on its hash.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22406 (cluster/afr: Remove un-used variables related to pump) merged (#2) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22415 ([WIP] graph.c: remove extra gettimeofday() - reuse the graph dob.) posted (#2) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22394 (mem-pool: remove dead code.) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22391 (build: link libgfrpc with MATH_LIB (libm, -lm)) merged (#3) on master by Niels de Vos REVIEW: https://review.gluster.org/22433 (rpc: Remove duplicate code) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22433 (rpc: Remove duplicate code) merged (#1) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22439 (rpclib: slow floating point math and libm) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/22454 ([WIP][RFC]dict.{c|h}: slightly reduce work under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22471 (build: conditional rpcbind for gnfs in glusterd.service) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/22473 ([WIP][RFC]mem-pool: set ptr to 0x0 after free'ed.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22484 (glusterd: remove redundant glusterd_check_volume_exists () calls) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22387 (changelog: remove unused code.) merged (#6) on master by Amar Tumballi REVIEW: https://review.gluster.org/22439 (rpclib: slow floating point math and libm) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22492 (tests: shard read test correction) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22496 (cluster/afr: Invalidate inode on change of split-brain-choice) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22509 (ec: increase line coverage of ec) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22512 ([WIP]glusterd-volgen.c: skip fetching skip-CLIOT in a loop.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22496 (cluster/afr: Invalidate inode on change of split-brain-choice) merged (#3) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22484 (glusterd: remove redundant glusterd_check_volume_exists () calls) merged (#9) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22528 (glusterd: remove glusterd_check_volume_exists() call) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22512 (glusterd-volgen.c: skip fetching skip-CLIOT in a loop.) merged (#6) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22541 ([WIP]glusterd-volgen.c: skip fetching some vol settings in a bricks loop.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22509 (ec: increase line coverage of ec) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22508 (tests: correctly check open fd's when gfid is missing) merged (#3) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22528 (glusterd: remove glusterd_check_volume_exists() call) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22281 (Replace memdup() with gf_memdup()) merged (#3) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22541 (glusterd-volgen.c: skip fetching some vol settings in a bricks loop.) merged (#6) on master by Yaniv Kaul REVIEW: https://review.gluster.org/22415 (graph.c: remove extra gettimeofday() - reuse the graph dob.) merged (#11) on master by Amar Tumballi REVIEW: https://review.gluster.org/22554 (core: handle memory accounting correctly) posted (#2) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22580 (tests: Add changelog snapshot testcase) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/22583 (build-aux/pkg-version: provide option for depth=1) posted (#1) for review on master by Amar Tumballi REVISION POSTED: https://review.gluster.org/22554 (core: handle memory accounting correctly) posted (#4) for review on master by Xavi Hernandez REVISION POSTED: https://review.gluster.org/22583 (build-aux/pkg-version: provide option for depth=1) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22592 ([DNM][RFE] Padding of structures.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22593 ([WIP][RFC]dht-common.h: reorder variables to reduce padding.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22601 ([WIP] options.c,h: minor changes to GF_OPTION_RECONF) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22302 (core: avoid dynamic TLS allocation when possible) merged (#8) on master by Amar Tumballi REVIEW: https://review.gluster.org/22329 (logging.c/h: aggressively remove sprintfs()) merged (#23) on master by Amar Tumballi REVIEW: https://review.gluster.org/22623 (tests: improve and fix some test scripts) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22625 (core: improve timer accuracy) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22626 (storage/posix: fix fresh file detection delay) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22632 (core: reduce some timeouts) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22633 (rpc: implement reconnect back-off strategy) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22642 ([RFE][WIP][DNM]store: store all key-values in one shot) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22626 (storage/posix: fix fresh file detection delay) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22601 (options.c,h: minor changes to GF_OPTION_RECONF) merged (#6) on master by Amar Tumballi REVIEW: https://review.gluster.org/22652 (glusterd-utils.c: reduce work in glusterd_add_volume_to_dict()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22580 (tests: Add changelog snapshot testcase) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/22652 (glusterd-utils.c: reduce work in glusterd_add_volume_to_dict()) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22659 ([WIP]glusterd-utils.c: reduce some work) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22665 (libglusterfs: Fix compilation when --disable-mempool is used) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22274 (mem-pool.{c|h}: minor changes) merged (#18) on master by Amar Tumballi REVIEW: https://review.gluster.org/22665 (libglusterfs: Fix compilation when --disable-mempool is used) merged (#2) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22675 ([WIP]glusterd-utils.c: skip checksum when possible.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22642 (glusterd/store: store all key-values in one shot) merged (#21) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22679 (glusterd: improve logging in __server_getspec()) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22623 (tests: improve and fix some test scripts) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/22659 (glusterd: reduce some work in glusterd-utils.c) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/22700 (libglusterfs: Remove decompunder helper routines from symbol export) posted (#1) for review on master by Anoop C S REVIEW: https://review.gluster.org/22705 (store: minor changes to store functions.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22700 (libglusterfs: Remove decompunder helper routines from symbol export) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22633 (rpc: implement reconnect back-off strategy) merged (#4) on master by Raghavendra G REVIEW: https://review.gluster.org/22696 (rpc: include nfs specific files in build only if gNFS is enabled) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22732 ([WIP][RFC]inode.c/h: small optimizations for inode_ctx_* funcs) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22736 (tests: change usleep() to sleep()) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22736 (tests: change usleep() to sleep()) merged (#1) on master by Sanju Rakonde REVIEW: https://review.gluster.org/22750 (Revert \"rpc: implement reconnect back-off strategy\") posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22754 (tests: Fix spurious failures in ta-write-on-bad-brick.t) posted (#1) for review on master by Pranith Kumar Karampuri REVISION POSTED: https://review.gluster.org/22750 (Revert \"rpc: implement reconnect back-off strategy\") posted (#4) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22755 (tests: Add history api tests) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/22760 (tests: Add changelog api tests) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/22766 ([WIP]dict.c: remove one strlen() done under lock.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22675 (glusterd-utils.c: skip checksum when possible.) merged (#6) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22754 (tests: Fix spurious failures in ta-write-on-bad-brick.t) merged (#2) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22772 ([WIP]glusterd-volgen.c: remove BD xlator from the graph) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22755 (tests: Add history api tests) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/22760 (tests: Add changelog api tests) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22797 (glusterd: remove trivial conditions) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22797 (glusterd: remove trivial conditions) merged (#1) on master by Sanju Rakonde REVIEW: https://review.gluster.org/22800 ([WIP] (multiple files) CALLOC -> MALLOC when serializing a dictionary) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22804 (tests/geo-rep: Fix the comment) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/22804 (tests/geo-rep: Remove a rename test case on EC volume) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/22820 ([WIP][RFC]dict: use fixed 'hash' for keys that are fixed strings.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22827 ([WIP]cli: defer create_frame() (and dict creation) to later stages.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22829 (tests/utils: Fix py2/py3 changelogparser.py compatibility) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/22832 (glusterd: Fix a typo) posted (#1) for review on master by Anoop C S REVIEW: https://review.gluster.org/22835 (tests/subdir-mount: give more time for heal to complete) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22829 (tests/utils: Fix py2/py3 util python scripts) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/22832 (glusterd: Fix typos) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22844 ([WIP]multiple files: another attempt to remove includes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22845 (tests: keep glfsxmp in tests directory) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22847 (tests: added cleanup for lock files) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/22847 (tests: added cleanup for lock files) merged (#1) on master by Sunny Kumar REVIEW: https://review.gluster.org/22845 (tests: keep glfsxmp in tests directory) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22796 (libglusterfs: cleanup iovec functions) merged (#12) on master by Amar Tumballi REVIEW: https://review.gluster.org/22859 ([WIP]glusterd.h: remove unneeded macros or move them to their users.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22870 (tests: Add missing NFS test tag to the testfile) posted (#1) for review on master by Aravinda VK REVIEW: https://review.gluster.org/22844 (multiple files: another attempt to remove includes) merged (#19) on master by Amar Tumballi REVIEW: https://review.gluster.org/22875 (glfs: add syscall.h after header cleanup) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22875 (glfs: add syscall.h after header cleanup) merged (#1) on master by Amar Tumballi REVIEW: https://review.gluster.org/22870 (tests: Add missing NFS test tag to the testfile) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22625 (core: improve timer accuracy) merged (#6) on master by Amar Tumballi REVIEW: https://review.gluster.org/22879 (core: fedora 30 compiler warnings) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22885 (core: fedora 29 compiler warnings) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22879 (core: fedora 30 compiler warnings) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22772 (glusterd-volgen.c: remove BD xlator from the graph) merged (#15) on master by Amar Tumballi REVIEW: https://review.gluster.org/22901 (fix template file after clang-format) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22901 (fix template file after clang-format) merged (#2) on master by Xavi Hernandez REVIEW: https://review.gluster.org/22924 ([WIP]glusterd.h: align structs) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22859 (glusterd.h: remove unneeded macros or move them to their users.) merged (#5) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22957 (rfc.sh: Improve bug identification) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22958 (run-tests.sh: stop test on Ctrl-C) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22958 (run-tests.sh: stop test on Ctrl-C) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22957 (rfc.sh: Improve bug identification) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22975 (core: Remove Wformat-truncation compiler warning for cli) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22978 (glusterd: change the error log to info log) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22979 (glusterd: don't log a warning message for tier-enabled key) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22975 (cli: Remove Wformat-truncation compiler warning) merged (#3) on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22985 ([WIP]dict.c: dict_unserialize() can use dict_addn()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22988 (logging.c: check for skip_logging() in _gf_slog()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22979 (glusterd: don't log a warning message for tier-enabled key) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23004 (glusterd: fix packed member address warning) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22924 (glusterd.h: align structs) merged (#6) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23009 (posix: fix Wformat-overflow warning) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/23004 (glusterd: fix packed member address warning) merged (#3) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23009 (posix: fix Wformat-overflow warning) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22696 (rpc/xdr: include nfs specific files in build only if gNFS is enabled) merged (#7) on master by Amar Tumballi REVIEW: https://review.gluster.org/23027 (rdma: remove packed member address error) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22593 (dht-common.h: reorder variables to reduce padding.) merged (#30) on master by N Balachandran REVIEW: https://review.gluster.org/22827 (cli: defer create_frame() (and dict creation) to later stages.) merged (#12) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22988 (logging.c: check for skip_logging() in _gf_slog(), _gf_smsg()) merged (#8) on master by Amar Tumballi REVIEW: https://review.gluster.org/23084 ([WIP][RFC]dict: use fixed 'hash' for keys that are fixed strings.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/22800 ((multiple files) use dict_allocate_and_serialize() where applicable.) merged (#18) on master by Amar Tumballi REVIEW: https://review.gluster.org/23104 (Improve logging of fusedump creation failure) posted (#1) for review on master by Csaba Henk REVIEW: https://review.gluster.org/23105 (build: stop suppressing \"Entering/Leaving direcory...\" messages) posted (#1) for review on master by Csaba Henk REVIEW: https://review.gluster.org/23109 ([WIP]glusterd-store.c: write voldir once and don't attempt again.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23109 (glusterd: write voldir once in glusterd-store and don't attempt again.) merged (#3) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22985 (dict.c: dict_unserialize() can use dict_addn()) merged (#14) on master by Amar Tumballi REVIEW: https://review.gluster.org/23118 (tests: introduce BRICK_MUX_BAD_TESTS variable) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/23130 ([WIP][RFE] multiple files: reduce minor work under RCU_READ_LOCK) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23083 (Multiple files: get trivial stuff done before lock) merged (#12) on master by Amar Tumballi REVIEW: https://review.gluster.org/23118 (tests: introduce BRICK_MUX_BAD_TESTS variable) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23153 ([WIP]options.h: format OPTION_INIT similar to RECONF_INIT) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23130 (multiple files: reduce minor work under RCU_READ_LOCK) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23156 (index.{c|h}: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23169 ([WIP]client-handshake.c: minor changes and removal of dead code.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23105 (build: stop suppressing \"Entering/Leaving direcory...\" messages) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23178 ([WIP]client_t.c: removal of dead code.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23169 (client-handshake.c: minor changes and removal of dead code.) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23178 (client_t.c: removal of dead code.) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23319 ([WIP][RFC]dht-common.c: remove some strcat and temp buffers) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23324 ([WIP]posix*.c: remove unneeded strlen() calls) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23327 (build: Fix libglusterd Makefile target) posted (#1) for review on master by Anoop C S REVIEW: https://review.gluster.org/23331 (logging.c: check for log level before checking for args.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23327 (build: Fix libglusterd Makefile target) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23335 (glusterd-store.c: remove of dead code) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23356 ([RFC][WIP] multiple files: exec gf_uuid_unparse() when needed.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23335 (glusterd-store.c: remove of dead code) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23324 (posix*.c: remove unneeded strlen() calls) merged (#5) on master by Kotresh HR REVIEW: https://review.gluster.org/23381 (logging.c: check for log level before checking for args.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23401 ([WIP]client xlator: misc. cleanups) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23410 ([WIP]afr-common.c, afr-self-heal.h: calloc/alloca0 -> malloc/alloca) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23412 ([WIP]afr: align structs) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23421 ([WIP]rpc: align structs) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23381 (logging.c: check for log level before checking for args.) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23439 ([WIP]posix-helpers.c: minor changes to posix_fs_health_check) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23452 ([WIP][RFC]posix-helpers.c: do not copy when reading xattr) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23455 ([WIP]inode.c: inode_table_prune() should not re-take the table lock) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23457 ([WIP]afr: replace afr_frame_return() when possible with direct call) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23458 ([WIP]dht: replace dht_frame_return() when possible with direct call) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23410 (afr-common.c, afr-self-heal.h: calloc/alloca0 -> malloc/alloca) merged (#4) on master by Ravishankar N REVIEW: https://review.gluster.org/23410 (afr-common.c, afr-self-heal.h: calloc/alloca0 -> malloc/alloca) merged (#4) on master by Ravishankar N REVIEW: https://review.gluster.org/23410 (afr-common.c, afr-self-heal.h: calloc/alloca0 -> malloc/alloca) merged (#4) on master by Ravishankar N REVIEW: https://review.gluster.org/23466 (extras: add statedumpparse.rb) posted (#1) for review on master by Csaba Henk REVIEW: https://review.gluster.org/23474 (xlators/store: store all key-values at a time) posted (#8) for review on master by Yati Padia REVIEW: https://review.gluster.org/23498 (glusterd: improve logging) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/23500 ([WIP]glusterfsd-mgmt: unify read and write tests) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23503 (glusterd-volgen.c: fix setting the key export-dir) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23498 (glusterd: improve logging) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23507 ([WIP]iobuf.c, h: minor fixes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23505 (tests: add a pending test case) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23505 (tests: add a pending test case) merged (#3) on master by Raghavendra Talur REVIEW: https://review.gluster.org/23511 ([WIP]glusterd-utils.c: attach_brick() - remove dead code) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23513 ([WIP]Multiple files: make root gfid a static variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23520 (cli-*: make some structs static to reduce space consumed.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23457 (afr: replace afr_frame_return() when possible with direct call) merged (#11) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/23525 ([WIP][RFC]dict.{c,h}: remove the lock from the _data struct) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23528 (packaging: Fedora 31+ can't build bd xlator) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/23529 (dict.c: remove redundant checks) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23528 (packaging: remove leftover bd cruft in rpm .spec) merged (#3) on master by Kaleb KEITHLEY REVISION POSTED: https://review.gluster.org/23534 (packaging: remove leftover bd cruft in rpm .spec) posted (#2) for review on release-6 by Kaleb KEITHLEY REVIEW: https://review.gluster.org/23537 ([DNM][RFC][WIP]: Dict - use union to storage vars in native format) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23538 (cloudsync: remove dead code, unused variable) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23452 (posix-helpers.c: do not copy when reading xattr) merged (#9) on master by Amar Tumballi REVIEW: https://review.gluster.org/23511 (glusterd-utils.c: attach_brick() - remove dead code) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23525 (dict.{c,h}: remove the lock from the _data struct) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23401 (client xlator: misc. cleanups) merged (#8) on master by Amar Tumballi REVIEW: https://review.gluster.org/23539 (tests: add tests for bz#1758878) posted (#2) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/23412 (afr: align structs) merged (#4) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/23513 (Multiple files: make root gfid a static variable) merged (#3) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23503 (glusterd-volgen.c: fix setting the key export-dir) merged (#6) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23439 (posix-helpers.c: minor changes to posix_fs_health_check) merged (#7) on master by Amar Tumballi REVIEW: https://review.gluster.org/23539 (tests: add tests for bz#1758878) merged (#3) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23421 (rpc: align structs) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23561 (libglusterfs: remove unused files from repo) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23567 (rpc multiple files: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23569 (posix-entry-ops: do not copy when reading xattr) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23571 ([WIP]posix-helpers.c (and others): minor changes to posix_xattr_fill()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23569 (posix-entry-ops: do not copy when reading xattr) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23573 ([WIP]posix-entry-ops.c/posix.h: improve GFID_NULL_CHECK_AND_GOTO macro) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23576 ([WIP]posix-*: reduce the number of calls to fetch GF_CS_OBJECT_STATUS) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23589 ([WIP]dht-helper.c: remove redundant checks) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23590 (dht-common.h/dht-helper.c: exctract the LOCK() from DHT_UPDATE_TIME) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23604 ([WIP]dict: use the free_pair's key presence or NULL as a sign of use.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23628 (cli-cmd-parser.c: cleanups) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23633 ([WIP]cli-rpc-ops.c: cleanups) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23643 ([WIP][RFC]posix-common.c: simplify init() slightly) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23645 (MAINTAINERS: revised the maintainers list after 2 years) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23647 (posix-entry-ops.c: pass correct key length in posix_skip_non_linkto_unlink()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23648 ([WIP]glusterd-op-sm.c (and others) - improve glusterd_op_stage_set_volume()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23647 (posix-entry-ops.c: pass correct key length in posix_skip_non_linkto_unlink()) merged (#2) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/23651 ([WIP]socket.c: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23653 (api: Fix documentation path in README) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22766 (dict.c: remove one strlen() done under lock.) merged (#28) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/23677 ([WIP]gluster-volgen.c: conditionally do not compile experimental stuff) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23678 (common-utils.c: add gf_strn2boolean() function) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23571 (posix-helpers.c (and others): minor changes to posix_xattr_fill()) merged (#7) on master by Amar Tumballi REVIEW: https://review.gluster.org/23538 (cloudsync: remove dead code, unused variable) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23104 (Improve logging of fusedump creation failure) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23466 (extras: add statedumpparse.rb) merged (#7) on master by Amar Tumballi REVIEW: https://review.gluster.org/23507 (iobuf.c, h: minor fixes) merged (#7) on master by Amar Tumballi REVIEW: https://review.gluster.org/23529 (dict.c: remove redundant checks) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23500 (glusterfsd-mgmt: unify read and write tests) merged (#7) on master by Amar Tumballi REVIEW: https://review.gluster.org/23690 ([WIP]glusterd-volgen.c: improve volgen_graph_set_options_generic()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23694 (dict.c: remove usless memcpy() when unserializing a dictionary.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23645 (MAINTAINERS: revised the maintainers list after 2 years) merged (#4) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23704 (extras: fix the remove subvol name in case of thin-arbiter) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23677 ([WIP]gluster-volgen.c: remove more of JBR and FDL xlators) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23653 (api: Fix documentation path in README) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23709 (Revert \"dict.c: remove redundant checks\") posted (#3) for review on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/23709 (Revert \"dict.c: remove redundant checks\") merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23704 (extras: fix the remote subvol name in case of thin-arbiter) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23714 ([WIP]posix-helpers.c: do not copy when reading xattr) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23690 (glusterd-volgen.c: improve volgen_graph_set_options_generic()) merged (#9) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23561 (libglusterfs: remove unused gfdb specific files from repo) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23721 ([WIP]glusterfsd-mgmt.c: move INFO log outside a LOCK) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23651 (socket.c: minor changes) merged (#8) on master by Amar Tumballi REVIEW: https://review.gluster.org/23721 (glusterfsd-mgmt.c: move INFO log outside a LOCK) merged (#4) on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/23738 (MAINTAINERS: add Xie Changlong as maintainer for gNFS) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23752 ([WIP]store.c/glusterd-store.c: remove sys_stat calls) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23753 ([WIP]store.c remove a sys_stat() call - just open the file) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23755 ([WIP]glusterfsd.c: remove sys_lstat() call) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23756 ([WIP]posix-inode-fd-ops.c: excute sys_fstat() only when needed) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23758 (Maintainers: Remove Nithya as maintainer/peer) posted (#1) for review on master by N Balachandran REVIEW: https://review.gluster.org/23520 (cli-*: make some structs static to reduce space consumed.) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23756 (posix-inode-fd-ops.c: excute sys_fstat() only when needed) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23752 (store.c/glusterd-store.c: remove sys_stat calls) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23755 (glusterfsd.c: remove sys_lstat() call) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23758 (Maintainers: Remove Nithya as maintainer/peer) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23678 (common-utils.c: add gf_strn2boolean() function) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23763 (dht-common.c,dht-selfheal.c: LOCK() only if op_ret) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23765 (MAINTAINERS: Add Nithya to past contributors section) posted (#1) for review on master by Raghavendra G REVIEW: https://review.gluster.org/23765 (MAINTAINERS: Add Nithya to past contributors section) merged (#2) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23773 (MAINTAINERS: add Xie Changlong and Amar Tumballi as peers for gNFS) posted (#1) for review on master by jiffin tony Thottan REVIEW: https://review.gluster.org/23648 (glusterd-op-sm.c (and others) - improve glusterd_op_stage_set_volume()) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23781 ([WIP]posix-metadata.c: try to getxattr in one call.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23782 ([WIP]options.h: format OPTION_INIT similar to RECONF_INIT) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23784 ([WIP] posix*: minor optimizations) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23785 ([WIP]glusterd-store.c: minor refactor to cleanup the code) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23786 ([WIP][DNM] inode changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23787 ([WIP]shard.c|h: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23788 ([WIP]locks: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23789 ([WIP]fuse-*: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23792 ([WIP]afr: move functions to static in afr-common.c) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23797 (contributors: map domain names for CMSS) posted (#1) for review on master by Xie Changlong REVIEW: https://review.gluster.org/23796 (fuse: add missing unlock) posted (#1) for review on master by Xie Changlong REVIEW: https://review.gluster.org/23799 ([RFE][WIP]#ifdef gNFS related code if we are not compiling gNFS) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23800 (xlators/store: store all key-values at a time) posted (#1) for review on master by Yati Padia REVIEW: https://review.gluster.org/23801 (md-cache.c: move cache-swift-metadata to off by default) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23773 (MAINTAINERS: add Xie Changlong and Amar Tumballi as peers for gNFS) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23818 ([WIP]glfs-*: move functions to static, minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23823 ([WIP]posix-helpers/gfid-path.c: do not copy xattr when not needed.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23827 ([WIP]graph.c: move functions to static) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23841 ([WIP]multiple xlators: reduce key length) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23842 (dht-hashfn.c: remove a strlen()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23844 (protocol/client: Fix a log entry) posted (#2) for review on master by Anoop C S REVIEW: https://review.gluster.org/23847 ([WIP]posix: improve posix_{set_gfid2path_xattr|remove_gfid2path_xattr} funcs) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23796 (fuse: add missing unlock) merged (#2) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23797 (contributors: map domain names for CMSS) merged (#2) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23863 ([WIP]call-stub.c: remove redundant validation GF_VALIDATE_OR_GOTO(\"call-stub\", frame, out) is removed. It's not needed, since we are testing via the creation of a stub, in stub_new() that frame is not NULL.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23871 (Multiple xlators: unify the calls to set/get/del INTERNAL_FOP key) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23882 (glusterd -svc & shd cleaning) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23590 (dht-common.h/dht-helper.c: exctract the LOCK() from DHT_UPDATE_TIME) merged (#2) on master by Susant Palai REVIEW: https://review.gluster.org/23892 ([WIP]afr: move functions to static) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23863 (call-stub.c: remove redundant validation) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23799 ([RFC]#ifdef gNFS related code if we are not compiling gNFS) merged (#6) on master by Amar Tumballi REVIEW: https://review.gluster.org/23633 (cli-rpc-ops.c: cleanups) merged (#5) on master by Sanju Rakonde REVIEW: https://review.gluster.org/23753 (store.c: remove a sys_stat() call - just open the file) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23911 (socket: fix typos and drop unused members) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23801 (md-cache.c: move cache-swift-metadata to off by default) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23915 ([WIP]dict.c and others: move count and len to be usigned integers.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23917 ([RFC][WIP]dict.c|h: include the key length in the _data_pair struct) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23922 (posix: fix GF_VALIDATE_OR_GOTO(this->name, this, out)) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/23923 ([WIP]: dict: create specific dict_get/set for 'gfid-req') posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23924 ([WIP] remove some compiler warnings when not compiling gNFS) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23925 (Avoid buffer overwrite due to uuid_utoa() misuse) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23929 (cli, libglusterfs: rely on libpthread static initializers) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23925 (Avoid buffer overwrite due to uuid_utoa() misuse) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23911 (socket: fix typos and drop unused members/options) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23933 (posix-inode-fd-ops.c: fix a compiler warning - real_path may be NULL) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23934 (posix-entry-ops.c: remove some tier related code) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23935 (dht-rebalance.c: remove some tier related code) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23936 (afr: simplify afr_has_quorum()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23943 ([WIP]socket.c/name.c: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23946 (xdr-rpcclnt: remove dead code) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23947 ([WIP]rpc-transport: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23948 (rpcsvc-auth.c: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23950 ([WIP]glusterd-syncop.c: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23934 (posix-entry-ops.c: remove some tier related code) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23933 (posix-inode-fd-ops.c: fix a compiler warning - real_path may be NULL) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23951 ([RFC][WIP]list: create a 'disconnect' (from list) function.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23929 (cli, libglusterfs: rely on libpthread static initializers) merged (#3) on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/23924 (Remove some compiler warnings when not compiling gNFS) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23936 (afr: simplify afr_has_quorum()) merged (#2) on master by Ravishankar N REVIEW: https://review.gluster.org/23956 (cli: duplicate defns of cli_default_conn_timeout and cli_ten_minutes_timeout) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/23957 ([WIP][RFC]socket.c: set min. TLS ver to 1.3, using OpenSSL 1.1 methods) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23958 ([WIP][RFC]socket.c: skip fetch SSL dict items if SSL is not used.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23847 (posix: improve posix_{set_gfid2path_xattr|remove_gfid2path_xattr} funcs) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23961 ([WIP]xdr-generic: remove dead code.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23956 (cli: duplicate defns of cli_default_conn_timeout and cli_ten_minutes_timeout) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23781 (posix-metadata.c: try to getxattr in one call.) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23969 ([WIP]rpcsvc.c: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23972 (dht-rename.c: fix Coverity issues 1397018/7 - strcat into uninitialized value) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23973 ([WIP]dht-rename.c: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23974 (fuse: degrade logging of write failure to fuse device) posted (#1) for review on master by Csaba Henk REVIEW: https://review.gluster.org/23980 (performance/io-threads - reducing methods scope) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23981 (syncop.h: syncop_create_frame() potentially skip uid, gid assignment) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23986 (performance/io-cache - reducing methods scope) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23974 (fuse: degrade logging of write failure to fuse device) merged (#5) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23972 (dht-rename.c: fix Coverity issues 1397018/7 - strcat into uninitialized value) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23989 ([WIP][DNM]glusterd-volgen.c: fix to disable property when gNFS disabled.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23991 (xlators/storage: prefer HAVE_xxx to host C library predefines) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23992 (xlators/storage: remove duplicated includes) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23996 ([WIP]options.h: deprecate deprecated array) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23997 ([WIP]glusterd-pmap: minor changes.) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23999 ([WIP]dictionary: remove the 'extra_free' parameter) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23989 (glusterd-volgen.c: fix to disable property when gNFS disabled.) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23947 (rpc-transport: minor changes) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23943 (socket.c/name.c: minor changes) merged (#6) on master by Amar Tumballi REVIEW: https://review.gluster.org/23604 (dict: use the free_pair's key presence or NULL as a sign of use.) merged (#11) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23991 (xlators/storage: prefer HAVE_xxx to host C library predefines) merged (#2) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23992 (xlators/storage: remove duplicated includes) merged (#3) on master by Xavi Hernandez REVIEW: https://review.gluster.org/24008 (glusterd-handshake.c: minor changes) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/24010 (pkg-version: fix warning due to wrong check.) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/24016 (name.c: fix Coverity issues 1412332/3 - strcat into uninitialized value) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/24017 (server.c: fix Coverity issue 1405844 (memory - illegal access)) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/23841 (multiple xlators: reduce key length) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23842 (dht-hashfn.c: remove a strlen()) merged (#8) on master by Amar Tumballi REVIEW: https://review.gluster.org/23844 (protocol/client: Fix a log entry) merged (#3) on master by Amar Tumballi This bug needs to always stay open. REVIEW: https://review.gluster.org/24026 (performance/md-cache - reducing methods scope) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/24031 ([WIP]Multiple files: remove RDMA support) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/24032 ([RFC][WIP]dict.c (and others): remove extra_stdfree parameter) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/24038 ([WIP]afr-comon.c: move functions to static) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/24040 (afr-open.c: remove redundant afr_fd_ctx_get() from afr_fix_open()) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/24016 (name.c: fix Coverity issues 1412332/3 - strcat into uninitialized value) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/24010 (pkg-version: fix warning due to wrong check.) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23999 (dictionary: remove the 'extra_free' parameter) merged (#8) on master by Xavi Hernandez REVIEW: https://review.gluster.org/23573 (posix-entry-ops.c/posix.h: improve GFID_NULL_CHECK_AND_GOTO macro) merged (#8) on master by Amar Tumballi REVIEW: https://review.gluster.org/24058 (client: remove unused 'this' variable passed to some functions) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/24062 (build: glusterfs-ganesha pkg requires python3-policycoreutils on rhel8) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/24017 (server.c: fix Coverity issue 1405844 (memory - illegal access)) merged (#6) on master by Amar Tumballi REVIEW: https://review.gluster.org/24062 (build: glusterfs-ganesha pkg requires python3-policycoreutils on rhel8) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/24088 (afr: fix warning during compilation) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/24097 (tests: disable hardlink nlink test for RHEL/CentOS8) posted (#1) for review on master by Csaba Henk REVIEW: https://review.gluster.org/24115 (ganesha-ha: updates for pcs-0.10.x (i.e. in Fedora-29 and RHEL-8)) posted (#1) for review on master by Kaleb KEITHLEY REVIEW: https://review.gluster.org/23900 (dht - Reducing methods scope) posted (#10) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23900 (dht - Reducing methods scope) merged (#10) on master by Barak Sason Rofman REVIEW: https://review.gluster.org/24115 (ganesha-ha: updates for pcs-0.10.x (i.e. in Fedora-29 and RHEL-8)) merged (#4) on master by soumya k REVIEW: https://review.gluster.org/24206 (dht - selfheal code cleaning) posted (#1) for review on master by Barak Sason Rofman REVISION POSTED: https://review.gluster.org/24206 (dht - selfheal code cleaning) posted (#2) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/24206 (dht - selfheal code cleaning) posted (#4) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23914 ([WIP] Improvments to sorting algorithm in dht-layout) posted (#10) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/24206 (dht - selfheal code cleaning) merged (#5) on master by Susant Palai This bug is moved to https://github.com/gluster/glusterfs/issues/1000, and will be tracked there from now on. Visit GitHub issues URL for further details REVIEW: https://review.gluster.org/24405 (fuse: degrade logging of write failure to fuse device) posted (#1) for review on release-6 by hari gowtham REVIEW: https://review.gluster.org/24406 (fuse: degrade logging of write failure to fuse device) posted (#1) for review on release-7 by hari gowtham Gluster-Swift Does Not Allow Bulk Operations https://review.gluster.org/24406 https://resultadodeltrisdehoy.com/tris-clasico This product has been discontinued or is no longer tracked in Red Hat Bugzilla. |