Bug 1194479
| Summary: | Click on Request shows error : "undefined method `[]' for nil:NilClass [miq_request/show] " | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Shveta <sshveta> | ||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Shveta <sshveta> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.3.0 | CC: | hkataria, jhardy, lavenel, mfeifer, ngupta, obarenbo, ssainkar, xlecauch | ||||
| Target Milestone: | GA | ||||||
| Target Release: | 5.4.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.4.0.0.11 | Doc Type: | Bug Fix | ||||
| Doc Text: |
In the previous version, UI displayed an undefined method error when clicking on request. Incorrect logic in "if" condition caused the rendering issue. With this release, the if condition has been fixed and there in no longer an error.
|
Story Points: | --- | ||||
| Clone Of: | |||||||
| : | 1199226 (view as bug list) | Environment: | |||||
| Last Closed: | 2015-06-16 12:51:13 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1199226 | ||||||
| Attachments: |
|
||||||
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/a85007e56b4ffe25b17b6bf613af40e22e2d74ef commit a85007e56b4ffe25b17b6bf613af40e22e2d74ef Author: Harpreet Kataria <hkataria> AuthorDate: Fri Feb 20 10:16:33 2015 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Fri Feb 20 10:16:33 2015 -0500 Fixed if condition. - Render x_dialog_buttons only when @edit is present and @edit[:explorer] is not set, no need to render buttons on show screen. https://bugzilla.redhat.com/show_bug.cgi?id=1194479 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) master.20150303194407_57a1769 New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a997f45fb51a596b81d74566d464f5f26c2710ec commit a997f45fb51a596b81d74566d464f5f26c2710ec Author: Harpreet Kataria <hkataria> AuthorDate: Thu Mar 5 14:48:38 2015 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Mar 5 14:49:37 2015 -0500 Fixed if condition. - Render x_dialog_buttons only when @edit is present and @edit[:explorer] is not set, no need to render buttons on show screen. https://bugzilla.redhat.com/show_bug.cgi?id=1194479 https://bugzilla.redhat.com/show_bug.cgi?id=1199226 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Fixed in 5.4.0.0.11.20150309201930_8b6a235 New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/b562f82740a6be55544518f2b19c88a8c511d7eb commit b562f82740a6be55544518f2b19c88a8c511d7eb Author: Harpreet Kataria <hkataria> AuthorDate: Mon Apr 6 10:27:08 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Apr 6 11:51:45 2015 -0400 Only render x_dialog_buttons if @record respond_to buttons. https://bugzilla.redhat.com/show_bug.cgi?id=1199226 https://bugzilla.redhat.com/show_bug.cgi?id=1194479 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c97c529fc64729d9ea91caf20a5737af0d55b1bc commit c97c529fc64729d9ea91caf20a5737af0d55b1bc Author: Harpreet Kataria <hkataria> AuthorDate: Mon Apr 6 11:51:45 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Apr 8 12:25:14 2015 -0400 Only render x_dialog_buttons if @record respond_to buttons. https://bugzilla.redhat.com/show_bug.cgi?id=1199226 https://bugzilla.redhat.com/show_bug.cgi?id=1194479 (cherry picked from commit b562f82) vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=cd634a4c636b5fb585638e94e182938875eb0489 commit cd634a4c636b5fb585638e94e182938875eb0489 Merge: a58463c c97c529 Author: Dan Clarizio <dclarizi> AuthorDate: Wed Apr 8 12:34:36 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Wed Apr 8 12:34:36 2015 -0400 Merge branch 'bz_1199226' into '5.3.z' Only render x_dialog_buttons if @record respond_to buttons. https://bugzilla.redhat.com/show_bug.cgi?id=1199226 https://bugzilla.redhat.com/show_bug.cgi?id=1194479 (cherry picked from commit b562f82) @dclarizio please review. This is a straight cherry-pick. See merge request !30 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commit detected on cfme/5.3.4: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9a48f650c8abfb5734df0c0c8e6fdfa32e38276a commit 9a48f650c8abfb5734df0c0c8e6fdfa32e38276a Author: Harpreet Kataria <hkataria> AuthorDate: Wed Apr 8 12:25:14 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Apr 8 16:04:20 2015 -0400 Only render x_dialog_buttons if @record respond_to buttons. https://bugzilla.redhat.com/show_bug.cgi?id=1199226 https://bugzilla.redhat.com/show_bug.cgi?id=1194479 (cherry picked from commit b562f82) (cherry picked from commit c97c529) vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) *** Bug 1211265 has been marked as a duplicate of this bug. *** Fixed in 5.4.0.0.22.20150420163946_26004d1 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1100.html |
Created attachment 993791 [details] err Description of problem: Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. Create a catalog and service catalog 2. Order Service catalog and go to request page 3. Click on request Actual results: Expected results: Additional info: 5.3.3.2.20150217120931_a465215 In logs -================================= [----] F, [2015-02-19T22:49:32.407251 #2315:70b804] FATAL -- : Error caught: [NoMethodError] undefined method `[]' for nil:NilClass /var/www/miq/vmdb/app/views/shared/dialogs/_dialog_provision.html.haml:18:in `_app_views_shared_dialogs__dialog_provision_html_haml___1123347099179554169_130749340' /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_view/template.rb:145:in `block in render' /opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/notifications.rb:125:in `instrument' /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_view/template.rb:143:in `render' /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_view/renderer/partial_renderer.rb:265:in `render_partial' /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_view/renderer/partial_renderer.rb:238:in `block in render' /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_view/renderer/abstract_renderer.rb:38:in `block in instrument'