Bug 1199226 - Click on Request shows error : "undefined method `[]' for nil:NilClass [miq_request/show] "
Summary: Click on Request shows error : "undefined method `[]' for nil:NilClass [miq_r...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.3.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.3.4
Assignee: Harpreet Kataria
QA Contact: Milan Falešník
URL:
Whiteboard:
: 1201775 1205308 (view as bug list)
Depends On: 1194479
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-05 16:48 UTC by Harpreet Kataria
Modified: 2019-07-11 08:44 UTC (History)
15 users (show)

Fixed In Version: 5.3.4
Doc Type: Bug Fix
Doc Text:
A bad IF condition was causing errors on Service Dialog Requests page. This made it unable to view requests. With this release, the IF condition has been fixed and Service Dialog requests can now be viewed.
Clone Of: 1194479
Environment:
Last Closed: 2015-04-29 13:20:15 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
production-01378693.log (22.50 KB, text/plain)
2015-03-23 09:41 UTC, Felix Dewaleyne
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 1376623 0 None None None Never
Red Hat Product Errata RHBA-2015:0890 0 normal SHIPPED_LIVE cfme (5.3.4) bug fix and enhancement update 2015-04-29 17:18:32 UTC

Comment 1 CFME Bot 2015-03-05 19:50:58 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a997f45fb51a596b81d74566d464f5f26c2710ec

commit a997f45fb51a596b81d74566d464f5f26c2710ec
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Mar 5 14:48:38 2015 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Mar 5 14:49:37 2015 -0500

    Fixed if condition.
    
    - Render x_dialog_buttons only when @edit is present and @edit[:explorer] is not set, no need to render buttons on show screen.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1194479
    https://bugzilla.redhat.com/show_bug.cgi?id=1199226

 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 6 Felix Dewaleyne 2015-03-23 09:41:26 UTC
Created attachment 1005273 [details]
production-01378693.log

the customer from case#01378693 was previously given the change to apply but new errors are being raised (see attached production-01378693.log

this is being raised whenever the "responsible" user clicks on a link from an email notification that any TAG value has ben exceeded. When the "responsible" click on the link, he can access the request but whenever he click on any of the allow/deny buttons an error happens:

o   “Unexpected error encountered”

o   Error text:

o   undefined method `buttons' for #<ServiceTemplateProvisionRequest:0x0000000b63a870> [miq_request/stamp]

If the responsbile instead of using link on the email, goes directly to the web, the petition is not on the list of "pending approval" because is only listed the requests where he is the petitioner himself.
In the other hand, the petitioner can see the request on the web but whenever he click on any of the allow/deny buttons, the above error appears.


this may be a new bug.

Comment 7 Aparna Karve 2015-03-23 23:54:00 UTC
*** Bug 1201775 has been marked as a duplicate of this bug. ***

Comment 8 Felix Dewaleyne 2015-03-24 16:48:16 UTC
see bz#1205308 for the new issue.

Comment 9 CFME Bot 2015-04-07 21:35:51 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/b562f82740a6be55544518f2b19c88a8c511d7eb

commit b562f82740a6be55544518f2b19c88a8c511d7eb
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Apr 6 10:27:08 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Apr 6 11:51:45 2015 -0400

    Only render x_dialog_buttons if @record respond_to buttons.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1199226
    https://bugzilla.redhat.com/show_bug.cgi?id=1194479

 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 10 Harpreet Kataria 2015-04-08 16:33:17 UTC
*** Bug 1205308 has been marked as a duplicate of this bug. ***

Comment 11 CFME Bot 2015-04-08 16:35:56 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c97c529fc64729d9ea91caf20a5737af0d55b1bc

commit c97c529fc64729d9ea91caf20a5737af0d55b1bc
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Apr 6 11:51:45 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Apr 8 12:25:14 2015 -0400

    Only render x_dialog_buttons if @record respond_to buttons.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1199226
    https://bugzilla.redhat.com/show_bug.cgi?id=1194479
    (cherry picked from commit b562f82)

 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 12 CFME Bot 2015-04-08 16:36:04 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=cd634a4c636b5fb585638e94e182938875eb0489

commit cd634a4c636b5fb585638e94e182938875eb0489
Merge: a58463c c97c529
Author:     Dan Clarizio <dclarizi>
AuthorDate: Wed Apr 8 12:34:36 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Wed Apr 8 12:34:36 2015 -0400

    Merge branch 'bz_1199226' into '5.3.z'
    
    Only render x_dialog_buttons if @record respond_to buttons.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1199226
    https://bugzilla.redhat.com/show_bug.cgi?id=1194479
    (cherry picked from commit b562f82)
    
    @dclarizio please review. This is a straight cherry-pick.
    
    See merge request !30

 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 13 CFME Bot 2015-04-08 20:05:21 UTC
New commit detected on cfme/5.3.4:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9a48f650c8abfb5734df0c0c8e6fdfa32e38276a

commit 9a48f650c8abfb5734df0c0c8e6fdfa32e38276a
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Apr 8 12:25:14 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Apr 8 16:04:20 2015 -0400

    Only render x_dialog_buttons if @record respond_to buttons.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1199226
    https://bugzilla.redhat.com/show_bug.cgi?id=1194479
    (cherry picked from commit b562f82)
    (cherry picked from commit c97c529)

 vmdb/app/views/shared/dialogs/_dialog_provision.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 16 Milan Falešník 2015-04-21 15:41:39 UTC
Verified in 5.3.4.2.20150415125246_f5d5c91, the erorr does not appear when entering the request summary page.

Comment 18 errata-xmlrpc 2015-04-29 13:20:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0890.html


Note You need to log in before you can comment on or make changes to this bug.