Bug 1195118

FailedQA in rhevm-3.5.1-0.2.el6ev.noarch (vt14.1).

With newer RHEV-H version available and host in maintenance, Webadmin GUI now shows message "If you wish to upgrade or reinstall the host click here.".

However, the message is all plain text, while the word "here" should be hyperlink which opens Host Install dialog upon clicking. See attached screenshot.

Created attachment 1007367 [details]
screen: plain text message about RHEV-H upgrade

Can this be pushed out to 3.5.3?

I moved it.
Also reduced urgency, as the message appears, just no hyperlink.

Bug 1065739 fix included also the removal of the link from the host general-info sub-tab. As the commit message [1] stated: "Removes the install link and message from the General Sub Tab. " (also see correspondence in the patch).

Since this patch, contradicts the actual fix implemented in Bug 1065739, there are 2 options:

1. Modify the alert of the existing message to be: "There are available updates for the host." (with a relevant icon)

2. Revert the fix of Bug 1065739 who dealt with removing the link from the sub-tab.

IMO, 1 is cleaner. All host life-cycle actions are accessible from the menubar and from the host context menu. The alert can be left for alerting the user without suggesting the actual action. So the link in that case basically replaces other click on the same screen (not much gain from my perspective).

Einav, could you share you view on this issue ?

[1] https://gerrit.ovirt.org/#/c/25523/

although option 1 is cleaner, it would be a bit frustrating to the user to see this message not accompanied with the relevant actions available from the same location. 

although "the link in that case basically replaces other click on the same screen", the link is much more easily discoverable for the user that is reading this message (rather than looking for the relevant action in the top panel or the context menu). 

what I suggest is:

In case there available upgrades, put the following in the "Action Items" section:

"[!] A new version is available. _Upgrade_"

[this ^^^ phrasing is more consistent with the 'Action Item' that appears when the Host is not in maintenance [1]]

In case there are no available upgrades - don't show anything in the "Action Items" section (the user has the "Reinstall" button at the top, if needed): 
The "Action Items" messages - both the one that appears when the Host is not in maintenance [1] and the one that (should) appear when the Host is in Maintenance [2] - pertain only to an upgrade scenario. 

Please don't revert the patch that fixed Bug 1065739, i.e., don't remove the actions from the top-panel/context-menu - I think it is great that the actions will be available from multiple locations, for an increased discoveribility by different users.  

[1] "[!] A new version is available; an upgrade option will appear once the Host is moved to maintenance mode."

[2] "[!] A new version is available. _Upgrade_"

Umm, guys - I know this is closed, but...

When I see a message that says "Click here," I expect that I can really click here and something will happen.  When "Click here" is just clear text, it messes with my mind.  Good thing I found this Bugzilla report!

It's OK if the message is just clear text - that's fine - but at least make it useful.  Tell me to right-click the host and "Upgrade".  But don't tell me to "click here" when "click here" is not functional.  

I should not have to track down a Bugzilla report for a simple interface issue like this.  It just looks sloppy. 

- Greg Scott

(In reply to Greg Scott from comment #10)
> Umm, guys - I know this is closed, but...
> 
> When I see a message that says "Click here," I expect that I can really
> click here and something will happen.  When "Click here" is just clear text,
> it messes with my mind.  Good thing I found this Bugzilla report!
> 

The fix for this bug was done according to comment 8:

"[!] A new version is available. _Upgrade_"

So in case there is an available upgrade for the host, there will be a clickable link named "Upgrade" which triggers the host upgrade dialog.
There shouldn't be any "Click here" text anywhere in that flow.

> It's OK if the message is just clear text - that's fine - but at least make
> it useful.  Tell me to right-click the host and "Upgrade".  But don't tell
> me to "click here" when "click here" is not functional.  
> 
> I should not have to track down a Bugzilla report for a simple interface
> issue like this.  It just looks sloppy. 
> 
> - Greg Scott