Bug 1196748

Summary:	Can't modify a Service Request with a cloned 'approver' role
Product:	Red Hat CloudForms Management Engine	Reporter:	Brian McLaughlin <bmclaugh>
Component:	UI - OPS	Assignee:	Brian McLaughlin <bmclaugh>
Status:	CLOSED ERRATA	QA Contact:	Shveta <sshveta>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	5.3.0	CC:	dajohnso, jdeubel, jhardy, jocarter, jprause, mfeifer, obarenbo, ssainkar, sshveta, xlecauch
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.3.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.3.4.1	Doc Type:	Bug Fix
Doc Text:	Earlier, request approvals were tied to a role name. As a result, when creating a new role by copying "EvmRole-approver" without changes, the new role was unable to see the provisioning request to approve it. Code was updated to allow MiQ request approval by feature rather than the role name. Thereby, approval can now be done by other roles.	Story Points:	---
Clone Of:	1196384	Environment:
Last Closed:	2015-04-29 13:20:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1196384
Bug Blocks:

Comment 1 CFME Bot 2015-02-26 21:55:54 UTC

New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=8b349779222ebcbde1bd445527b9a11678e6df26

commit 8b349779222ebcbde1bd445527b9a11678e6df26
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Wed Feb 25 16:27:55 2015 -0500
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Thu Feb 26 16:53:05 2015 -0500

    Allow MIQ Request approval by feature rather than role name
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1196748

 vmdb/app/controllers/miq_request_controller.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 3 Shveta 2015-04-22 17:48:08 UTC

Cloned approver role can see provisioning requests.
Verified in 5.3.4.2.20150415125246_f5d5c91

Comment 5 errata-xmlrpc 2015-04-29 13:20:02 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0890.html