Bug 1197066

Summary:	Review Request: perl-Test-Run - Extensible and object-oriented test harness for TAP scripts
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test-Run-0.0302-1.fc23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-03 14:04:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1197057
Bug Blocks:	1197126

Description Petr Pisar 2015-02-27 12:50:38 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Test-Run/perl-Test-Run.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test-Run/perl-Test-Run-0.0302-1.fc23.src.rpm
Description:
These Perl modules are an improved test harness based on Test::Harness, but
more modular, extensible and object-oriented.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2015-03-02 17:11:39 UTC

lib/Test/Run/Straps_GplArt.pm appears to be licensed under `GPLv2+ or Artistic'.  Your License tag should reflect that.

No other issues found.

Comment 2 Petr Pisar 2015-03-03 07:33:44 UTC

You are right. Updated package is on the same URL.

Comment 3 Petr Šabata 2015-03-03 09:34:18 UTC

--- a/perl-Test-Run.spec
+++ b/perl-Test-Run.spec
@@ -3,9 +3,9 @@ Version:        0.0302
 Release:        1%{?dist}
 Summary:        Extensible and object-oriented test harness for TAP scripts
 # lib and other code:               MIT
-# lib/Test/Run/Core_GplArt.pm:      GPL+ or Artistic
-# t/lib:                            GPL+ or Artistic
-License:        (GPL+ or Artistic) and MIT
+# lib/Test/Run/Core_GplArt.pm:      GPLv2+ or Artistic
+# t/lib/Test (not installed):       GPL+ or Artistic
+License:        (GPLv2+ or Artistic) and MIT
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Test-Run/
 Source0:        http://www.cpan.org/authors/id/S/SH/SHLOMIF/Test-Run-%{version}.tar.gz



Well, the license of lib/Test/Run/Core_GplArt.pm is still `GPL+ or Artistic'.  It's just lib/Test/Run/Straps_GplArt.pm that uses `GPLv2+ or Artistic'.  The incorrect spec comment aside, even though this is acceptable, you're effectively relicensing the package now.

I think the correct tag should be `(GPL+ or Artistic) and (GPLv2+ or Artistic) and MIT'.

Comment 4 Petr Pisar 2015-03-03 12:05:20 UTC

I mistaken files. Updated packages are on the same address.

Comment 5 Petr Šabata 2015-03-03 12:13:34 UTC

Ack, all good now.  Approving.

Comment 6 Petr Pisar 2015-03-03 12:44:46 UTC

New Package SCM Request
=======================
Package Name: perl-Test-Run
Short Description: Extensible and object-oriented test harness for TAP scripts
Upstream URL: http://search.cpan.org/dist/Test-Run/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2015-03-03 13:20:48 UTC

Git done (by process-git-requests).

Comment 8 Petr Pisar 2015-03-03 14:04:55 UTC

Thank you for the review and the repository.