Bug 1197142

Summary:	Minor improvements and code cleanup for Gluster/NFS
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	nfs	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Tracking, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-08-29 03:53:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Niels de Vos 2015-02-27 15:08:38 UTC

Every now and then minor improvements for Gluster/NFS get suggested. This bug has been opened to allow merging and tracking of small non-bug changes.

Acceptable changes that may get attached to this bug, include:

 - code cleanup
 - improved error checking
 - small logging improvements
 - documentation fixes
 - ...

Comment 1 Anand Avati 2015-02-27 16:53:52 UTC

REVIEW: http://review.gluster.org/9772 (nfs: nfs3_stat_to_fattr3() improvement) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2015-02-28 17:30:07 UTC

COMMIT: http://review.gluster.org/9772 committed in master by Niels de Vos (ndevos) 
------
commit 32dd227726ce60b2e60b8df61ca174d96a1b8b34
Author: Niels de Vos <ndevos>
Date:   Fri Feb 27 15:30:04 2015 +0100

    nfs: nfs3_stat_to_fattr3() improvement
    
    During a review of backorti http://review.gluster.org/9170, Kaleb points
    out:
    
        ick, return-by-value. About 50% slower than passing a pointer to the
        target struct.
    
    Change-Id: I4464e6a4e50d82d446a834892d0308332b7c32d0
    BUG: 1197142
    Reported-by: Kaleb KEITHLEY <kkeithle>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9772
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Amar Tumballi 2018-08-29 03:53:43 UTC

Lot of time since no activity on this bug. We have either fixed it already or it is mostly not critical anymore!

Please re-open the bug if the issue is burning for you, or you want to take the bug to closure with fixes.