Every now and then minor improvements for Gluster/NFS get suggested. This bug has been opened to allow merging and tracking of small non-bug changes. Acceptable changes that may get attached to this bug, include: - code cleanup - improved error checking - small logging improvements - documentation fixes - ...
REVIEW: http://review.gluster.org/9772 (nfs: nfs3_stat_to_fattr3() improvement) posted (#1) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/9772 committed in master by Niels de Vos (ndevos) ------ commit 32dd227726ce60b2e60b8df61ca174d96a1b8b34 Author: Niels de Vos <ndevos> Date: Fri Feb 27 15:30:04 2015 +0100 nfs: nfs3_stat_to_fattr3() improvement During a review of backorti http://review.gluster.org/9170, Kaleb points out: ick, return-by-value. About 50% slower than passing a pointer to the target struct. Change-Id: I4464e6a4e50d82d446a834892d0308332b7c32d0 BUG: 1197142 Reported-by: Kaleb KEITHLEY <kkeithle> Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/9772 Reviewed-by: Kaleb KEITHLEY <kkeithle> Tested-by: Gluster Build System <jenkins.com>
Lot of time since no activity on this bug. We have either fixed it already or it is mostly not critical anymore! Please re-open the bug if the issue is burning for you, or you want to take the bug to closure with fixes.