Bug 1199577

Summary:	mount.glusterfs uses /dev/stderr and fails if the device does not exist
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	scripts	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.6.2	CC:	bugs
Target Milestone:	---	Keywords:	Patch, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-v3.6.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1199545	Environment:
Last Closed:	2016-02-04 15:21:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1199545
Bug Blocks:	1184460

Description Niels de Vos 2015-03-06 16:30:53 UTC

+++ This bug was initially created as a clone of Bug #1199545 +++
+++                                                           +++
+++ Use this bug to post the backport for release-3.6.        +++

Description of problem:

Instead of using standard >&2 implementation, mount.glusterfs writes to /dev/stderr.

This causes the mount to fail on current CentOS 7 systems with the following message:


Mar 06 16:13:44 entrance mount[1886]: /sbin/mount.glusterfs: line 13: /dev/stderr: No such device or address


Version-Release number of selected component (if applicable):

3.6.2

How reproducible:

always




Steps to Reproduce:
1. Add entry to /etc/fstab on CentOS 7 with glusterfs 3.6.2, reboot.
2. systemctl status



Actual results:

var-lib-one-datastores-100.mount - /var/lib/one/datastores/100
   Loaded: loaded (/etc/fstab)
   Active: failed (Result: exit-code) since Fri 2015-03-06 16:13:44 CET; 42s ago
    Where: /var/lib/one/datastores/100
     What: vmhost2-cluster1.place4.ungleich.ch:/cluster1
  Process: 1886 ExecMount=/bin/mount vmhost2-cluster1.place4.ungleich.ch:/cluster1 /var/lib/one/datastores/100 -t glusterfs -o defaults,_netdev,backupvolfile-server=vmhost1-cluster1.place4.ungleich.ch (code=exited, status=1/FAILURE)

Mar 06 16:13:40 entrance systemd[1]: Mounted /var/lib/one/datastores/100.
Mar 06 16:13:44 entrance mount[1886]: /sbin/mount.glusterfs: line 13: /dev/stderr: No such device or address
Mar 06 16:13:44 entrance systemd[1]: var-lib-one-datastores-100.mount mount process exited, code=exited status=1
Mar 06 16:13:44 entrance systemd[1]: Unit var-lib-one-datastores-100.mount entered failed state.
[16:14:27] entrance:~# 



Expected results:

glusterfs volumes mound

Additional info:

Preparing a patch for inclusion at the moment

--- Additional comment from Anand Avati on 2015-03-06 16:29:58 CET ---

REVIEW: http://review.gluster.org/9824 (Replace /dev/stderr with >&2 in mount scripts) posted (#1) for review on master by Nico Schottelius (nico-gluster-users)

--- Additional comment from Niels de Vos on 2015-03-06 17:27:50 CET ---

I'll move this to the master branch, and will clone the bug to get the fix backported to release-3.6.

Comment 1 Niels de Vos 2015-03-06 17:32:23 UTC

Backport of http://review.gluster.org/9824 is needed.

Comment 2 Anand Avati 2015-03-07 13:14:20 UTC

REVIEW: http://review.gluster.org/9826 (Replace /dev/stderr with >&2 in mount scripts) posted (#1) for review on release-3.6 by Niels de Vos (ndevos)

Comment 3 Anand Avati 2015-03-07 15:14:50 UTC

COMMIT: http://review.gluster.org/9826 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit d494bec041d3581d8ed8f987929ab7b3a8cfb1a9
Author: Niels de Vos <ndevos>
Date:   Sat Mar 7 08:10:06 2015 -0500

    Replace /dev/stderr with >&2 in mount scripts
    
    /dev/stderr is not available on boot in CentOS 7 and thus
    mounting anything from /etc/fstab at boot time fails.
    
    Instead of using /dev/stderr, the standard error redirection ">&2" is being used.
    
    Cherry picked from commit adef0c8860f57c8137382d848244009e9a584497:
    > Change-Id: I15d07cd49e6b0392331047edb441925f48047b2b
    > BUG: 1199545
    > Signed-off-by: Nico Schottelius <nico.org>
    > Reviewed-on: http://review.gluster.org/9824
    > Reviewed-by: Niels de Vos <ndevos>
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Raghavendra Talur <rtalur>
    > Reviewed-by: Vijay Bellur <vbellur>
    
    Change-Id: I15d07cd49e6b0392331047edb441925f48047b2b
    BUG: 1199577
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9826
    Reviewed-by: Nico Schottelius <nico-gluster-users>
    Tested-by: Nico Schottelius <nico-gluster-users>
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 4 Kaushal 2016-02-04 15:21:33 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v3.6.3, please open a new bug report.

glusterfs-v3.6.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2015-April/021669.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user