Bug 1200157

Summary:	Review Request: rubygem-nenv - Convenience wrapper for Ruby's ENV
Product:	[Fedora] Fedora	Reporter:	František Dvořák <valtri>
Component:	Package Review	Assignee:	Mamoru TASAKA <mtasaka>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review
Target Milestone:	---	Flags:	mtasaka: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-nenv-0.2.0-2.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-23 16:06:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description František Dvořák 2015-03-09 21:16:06 UTC

Spec URL: http://scientific.zcu.cz/fedora/rubygem-nenv-0.2.0-1/rubygem-nenv.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-nenv-0.2.0-1/rubygem-nenv-0.2.0-1.fc23.src.rpm
Description: Using ENV is like using raw SQL statements in your code. We all know how that ends...
Fedora Account System Username: valtri

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9184705

Comment 1 Mamoru TASAKA 2015-04-03 10:13:20 UTC

Assiging.

I would appreciate it if you would review my review request (bug 1046749)

Comment 2 Mamoru TASAKA 2015-04-03 10:15:50 UTC

(In reply to Mamoru TASAKA from comment #1)
> Assiging.
> 
> I would appreciate it if you would review my review request (bug 1046749)

Oops... it's bug 1208821 .

Comment 3 Mamoru TASAKA 2015-04-07 09:13:09 UTC

Okay, very simple package

* spec file clean
* code contents (licensing) no problem
* can be built (F-23, F-22, F-21)
* rpmlint clean
* can be installed (tried F-21)
* at least the following works

$ ruby <<EOF
require 'nenv'
puts Nenv::VERSION
puts ENV['FOO']
Nenv.foo = 3
puts ENV['FOO']
EOF
0.2.0

3

No problem.
-------------------------------------------------------
    This package (rubygem-nenv) is APPROVED by mtasaka
-------------------------------------------------------

Comment 4 František Dvořák 2015-04-07 12:22:13 UTC

New Package SCM Request
=======================
Package Name: rubygem-nenv
Short Description: Convenience wrapper for Ruby's ENV
Upstream URL: https://github.com/e2/nenv
Owners: valtri
Branches: f21 f22 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2015-04-07 13:34:57 UTC

Git done (by process-git-requests).

Comment 6 Fedora Update System 2015-04-07 19:01:52 UTC

rubygem-nenv-0.2.0-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/rubygem-nenv-0.2.0-2.fc22

Comment 7 Fedora Update System 2015-04-07 19:03:40 UTC

rubygem-nenv-0.2.0-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/rubygem-nenv-0.2.0-2.fc21

Comment 8 Fedora Update System 2015-04-07 19:04:37 UTC

rubygem-nenv-0.2.0-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/rubygem-nenv-0.2.0-2.el7

Comment 9 Fedora Update System 2015-04-08 18:37:23 UTC

rubygem-nenv-0.2.0-2.fc22 has been pushed to the Fedora 22 testing repository.

Comment 10 Fedora Update System 2015-04-23 16:04:56 UTC

rubygem-nenv-0.2.0-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2015-04-23 16:06:56 UTC

rubygem-nenv-0.2.0-2.fc22 has been pushed to the Fedora 22 stable repository.

Comment 12 Fedora Update System 2015-04-23 19:00:25 UTC

rubygem-nenv-0.2.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.