Bug 1201195
| Summary: | autofs: MAPFMT_DEFAULT is not macro in lookup_program.c | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | XuWang <xuw> | ||||||
| Component: | autofs | Assignee: | Ian Kent <ikent> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | XuWang <xuw> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 6.7 | CC: | eguan, ikent | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | autofs-5.0.5-113.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: |
Cause: A programming mistake in the program map lookup module caused an incorrect map format type comparison.
Consequence: The incorrect comparison only affects amd format program maps where it introduces unused macro definitions.
Fix: Correct the programming mistake.
Result: These macros won't be included in the environment of amd format program maps.
|
Story Points: | --- | ||||||
| Clone Of: | |||||||||
| : | 1201582 (view as bug list) | Environment: | |||||||
| Last Closed: | 2015-07-22 06:51:30 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1201582 | ||||||||
| Attachments: |
|
||||||||
(In reply to XuWang from comment #0) > Description of problem: > > View the code of modules/lookup_program.c of autofs, there is a very strange > line showed like 181: > > 181 if (ctxt->mapfmt && strcmp(ctxt->mapfmt, "MAPFMT_DEFAULT")) { > 182 struct parse_context *pctxt = (struct parse_context *) > ctxt->parse->context; > > the MAPFMT_DEFAULT is used as macro in autofs except this line. I think > maybe it's the typo, so raise a bug to track it. > > If not, just set it as "NOT A BUG" status. No, that's a mistake, it needs to be fixed. Thanks for reporting it. Ian Created attachment 1001267 [details]
Patch - fix macro usage in lookup_program.c
Created attachment 1001270 [details]
Test program to show the result of the quoted macro comparison
This test program can be used to show the result of the mistake
in the current code and verify the change works as expected by
comparison and inspection of the autofs source.
view source code, seems good. run autofs test cases on RHEL-6.7-20150304.0 with autofs--5.0.5-113.el6, cover regression/bugzillas/connectathon/stress, no regressions. so I change the status of this bug to be verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-1344.html |
Description of problem: View the code of modules/lookup_program.c of autofs, there is a very strange line showed like 181: 181 if (ctxt->mapfmt && strcmp(ctxt->mapfmt, "MAPFMT_DEFAULT")) { 182 struct parse_context *pctxt = (struct parse_context *) ctxt->parse->context; the MAPFMT_DEFAULT is used as macro in autofs except this line. I think maybe it's the typo, so raise a bug to track it. If not, just set it as "NOT A BUG" status. Version-Release number of selected component (if applicable): autofs-5.0.5-112 How reproducible: always Steps to Reproduce: 1.view the source code of autofs 2. 3. Actual results: use the MAPFMT_DEFAULT as a string, not a macro Expected results: use MAPFMT_DEFAULT as a macro Additional info: