Hide Forgot
Description of problem: View the code of modules/lookup_program.c of autofs, there is a very strange line showed like 181: 181 if (ctxt->mapfmt && strcmp(ctxt->mapfmt, "MAPFMT_DEFAULT")) { 182 struct parse_context *pctxt = (struct parse_context *) ctxt->parse->context; the MAPFMT_DEFAULT is used as macro in autofs except this line. I think maybe it's the typo, so raise a bug to track it. If not, just set it as "NOT A BUG" status. Version-Release number of selected component (if applicable): autofs-5.0.5-112 How reproducible: always Steps to Reproduce: 1.view the source code of autofs 2. 3. Actual results: use the MAPFMT_DEFAULT as a string, not a macro Expected results: use MAPFMT_DEFAULT as a macro Additional info:
(In reply to XuWang from comment #0) > Description of problem: > > View the code of modules/lookup_program.c of autofs, there is a very strange > line showed like 181: > > 181 if (ctxt->mapfmt && strcmp(ctxt->mapfmt, "MAPFMT_DEFAULT")) { > 182 struct parse_context *pctxt = (struct parse_context *) > ctxt->parse->context; > > the MAPFMT_DEFAULT is used as macro in autofs except this line. I think > maybe it's the typo, so raise a bug to track it. > > If not, just set it as "NOT A BUG" status. No, that's a mistake, it needs to be fixed. Thanks for reporting it. Ian
Created attachment 1001267 [details] Patch - fix macro usage in lookup_program.c
Created attachment 1001270 [details] Test program to show the result of the quoted macro comparison This test program can be used to show the result of the mistake in the current code and verify the change works as expected by comparison and inspection of the autofs source.
view source code, seems good. run autofs test cases on RHEL-6.7-20150304.0 with autofs--5.0.5-113.el6, cover regression/bugzillas/connectathon/stress, no regressions. so I change the status of this bug to be verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-1344.html