Bug 1201325

Suggestions:
1) Group tag is optional in Fedora and is only needed if you want this package to be built for EPEL5. See http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag.
You can remove Group tag.

2) from https://pypi.python.org/pypi/oslo.context page, this module looks compatible with python3 also. Therefore, add python3 subpackage.

3) Remove last unnecessary changelog entry

4) in %files
Following is wrong
%doc %{license}
This should be written as
%doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog
%license LICENSE

Then, using following lines you are installing files twice.
%{python2_sitelib}/
%{python2_sitelib}/oslo_context
Change this to just
%{python2_sitelib}/oslo_context

5) Add -doc subpackage like other python-oslo-* packages are providing in Fedora. you can build documentation in %install using

pushd doc
sphinx-build -b html -d build/doctrees   source build/html
popd

just found there is no python-pytz package available but only pytz. Change the dependency.

Hello Parag,

Thanks for the review.
Here is the updated 
SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec
SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-2.fc21.src.rpm

and koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9309575

Please have a look.

Thanks,

Chandan Kumar

Hi Parag,

I have again updated the 
SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec
SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-3.fc21.src.rpm
and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9309651

Please have a look.

Thanks,

Chandan Kumar

Hi Chandan,
   Thanks for the updated package and sorry for confusing you about using sphinx-build in %install. I asked on packaging list and got the confirmation that it should be used in %build. 
   Actually, I got confused by other oslo library packaging. E.g. See 
http://pkgs.fedoraproject.org/cgit/python-oslo-config.git/tree/python-oslo-config.spec
http://pkgs.fedoraproject.org/cgit/python-oslo-messaging.git/tree/python-oslo-messaging.spec

Can you please provide one last update here and I will approve this package. Move the documentation building to %build.

Thanks.

Hello Parag,

Thanks for the review,
Here is my updated 
SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec
SPRM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-4.fc21.src.rpm

and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9318185

Thanks,

Chandan Kumar

Looks good now.

APPROVED.

Hello Parag,

Here is the updated 
SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec
SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-5.fc21.src.rpm

and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9345006

Thanks,

Chandan Kumar

Done review of following package review requests: https://bugzilla.redhat.com/show_bug.cgi?id=1206067
and https://bugzilla.redhat.com/show_bug.cgi?id=1206086

update looks good again :)

Thanks for the reviews.

New Package SCM Request
=======================
Package Name: python-oslo-context
Short Description:  OpenStack Oslo context library
Upstream URL: https://pypi.python.org/pypi/oslo.context
Owners: chandankumar
Branches: f22
InitialCC: apevec

Git done (by process-git-requests).

python-oslo-context-0.2.0-5.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-oslo-context-0.2.0-5.fc22

python-oslo-context-0.2.0-5.fc22 has been pushed to the Fedora 22 testing repository.

python-oslo-context-0.2.0-5.fc22 has been pushed to the Fedora 22 stable repository.