Bug 1201325 - Review Request: python-oslo-context - OpenStack Oslo context library
Summary: Review Request: python-oslo-context - OpenStack Oslo context library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-12 13:52 UTC by Chandan Kumar
Modified: 2015-06-06 00:13 UTC (History)
6 users (show)

Fixed In Version: python-oslo-context-0.2.0-5.fc22
Clone Of:
Environment:
Last Closed: 2015-06-06 00:13:25 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Chandan Kumar 2015-03-12 13:52:31 UTC
Spec URL: https://chandankumar.fedorapeople.org/python-oslo-context.spec
SRPM URL: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-1.fc21.src.rpm
Description: The OpenStack Oslo context library has helpers to maintain
useful information about a request context.
The request context is usually populated in the 
WSGI pipeline and used by various modules such as logging.

Fedora Account System Username: chandankumar

Successful Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9210068

Comment 1 Parag AN(पराग) 2015-03-13 09:27:31 UTC
Suggestions:
1) Group tag is optional in Fedora and is only needed if you want this package to be built for EPEL5. See http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag.
You can remove Group tag.

2) from https://pypi.python.org/pypi/oslo.context page, this module looks compatible with python3 also. Therefore, add python3 subpackage.

3) Remove last unnecessary changelog entry

4) in %files
Following is wrong
%doc %{license}
This should be written as
%doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog
%license LICENSE

Then, using following lines you are installing files twice.
%{python2_sitelib}/
%{python2_sitelib}/oslo_context
Change this to just
%{python2_sitelib}/oslo_context

5) Add -doc subpackage like other python-oslo-* packages are providing in Fedora. you can build documentation in %install using

pushd doc
sphinx-build -b html -d build/doctrees   source build/html
popd

Comment 2 Parag AN(पराग) 2015-03-13 12:24:42 UTC
just found there is no python-pytz package available but only pytz. Change the dependency.

Comment 3 Chandan Kumar 2015-03-24 09:37:30 UTC
Hello Parag,

Thanks for the review.
Here is the updated 
SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec
SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-2.fc21.src.rpm

and koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9309575

Please have a look.

Thanks,

Chandan Kumar

Comment 4 Chandan Kumar 2015-03-24 09:51:21 UTC
Hi Parag,

I have again updated the 
SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec
SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-3.fc21.src.rpm
and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9309651

Please have a look.

Thanks,

Chandan Kumar

Comment 5 Parag AN(पराग) 2015-03-24 13:57:06 UTC
Hi Chandan,
   Thanks for the updated package and sorry for confusing you about using sphinx-build in %install. I asked on packaging list and got the confirmation that it should be used in %build. 
   Actually, I got confused by other oslo library packaging. E.g. See 
http://pkgs.fedoraproject.org/cgit/python-oslo-config.git/tree/python-oslo-config.spec
http://pkgs.fedoraproject.org/cgit/python-oslo-messaging.git/tree/python-oslo-messaging.spec

Can you please provide one last update here and I will approve this package. Move the documentation building to %build.

Thanks.

Comment 6 Chandan Kumar 2015-03-25 06:35:12 UTC
Hello Parag,

Thanks for the review,
Here is my updated 
SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec
SPRM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-4.fc21.src.rpm

and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9318185

Thanks,

Chandan Kumar

Comment 7 Parag AN(पराग) 2015-03-25 15:50:34 UTC
Looks good now.

APPROVED.

Comment 9 Chandan Kumar 2015-03-27 08:24:19 UTC
Done review of following package review requests: https://bugzilla.redhat.com/show_bug.cgi?id=1206067
and https://bugzilla.redhat.com/show_bug.cgi?id=1206086

Comment 10 Parag AN(पराग) 2015-03-27 08:40:23 UTC
update looks good again :)

Thanks for the reviews.

Comment 11 Chandan Kumar 2015-03-27 13:15:59 UTC
New Package SCM Request
=======================
Package Name: python-oslo-context
Short Description:  OpenStack Oslo context library
Upstream URL: https://pypi.python.org/pypi/oslo.context
Owners: chandankumar
Branches: f22
InitialCC: apevec

Comment 12 Gwyn Ciesla 2015-03-27 15:32:48 UTC
Git done (by process-git-requests).

Comment 13 Fedora Update System 2015-03-30 05:16:44 UTC
python-oslo-context-0.2.0-5.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-oslo-context-0.2.0-5.fc22

Comment 14 Fedora Update System 2015-03-31 22:01:25 UTC
python-oslo-context-0.2.0-5.fc22 has been pushed to the Fedora 22 testing repository.

Comment 15 Fedora Update System 2015-06-06 00:13:25 UTC
python-oslo-context-0.2.0-5.fc22 has been pushed to the Fedora 22 stable repository.


Note You need to log in before you can comment on or make changes to this bug.