Bug 1202606

Summary:	libvirt should improve the xml format when define a vm have a empty <cpu/>
Product:	Red Hat Enterprise Linux 7	Reporter:	Luyao Huang <lhuang>
Component:	libvirt	Assignee:	Andrea Bolognani <abologna>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.1	CC:	abologna, dyuan, hliu, honzhang, mzhan, rbalakri
Target Milestone:	rc	Keywords:	Upstream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-1.2.15-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 06:20:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Luyao Huang 2015-03-17 02:43:36 UTC

description of problem:
libvirt should improve the xml format when define a vm have a empty <cpu/>

Version-Release number of selected component (if applicable):
libvirt-1.2.8-16.el7_1.1.x86_64
qemu-kvm-rhev-2.1.2-23.el7_1.1.x86_64

How reproducible:
100%

Steps to Reproduce:
 
1.edit a vm like this:
# virsh edit test3
...
  <cpu>
  </cpu>
...

2.check the xml
# virsh dumpxml test3
...
  <cpu>
  </cpu>
...

Actual results:
libvirt still format a empty <cpu/> and do not show any useful information in it.

Expected results:
if <cpu/> do not contain any special means in it, no need format it in xml, it will waste time to parse it.
if <cpu/> contain some special things, we should show them clearly in the xml.

Additional info:

Comment 1 Andrea Bolognani 2015-04-13 10:29:20 UTC

This has been fixed upstream with the following commit.

commit e4d7ddfdd2220046b8ca9f5e2af3a5d45e962e44
Author: Andrea Bolognani <abologna>
Date:   Fri Apr 10 15:09:59 2015 +0200

    conf: Don't output <cpu> tag if it contains no information.
    
    The tag is already marked as optional in the schema, so no changes
    are needed there.


v1.2.14-107-ge4d7ddf

Comment 3 Luyao Huang 2015-07-07 06:50:26 UTC

Verify this bug with libvirt-1.2.16-1.el7.x86_64:

1 . add a empty cpu element in guest xml:

# virsh edit test4
...
  <cpu>
  </cpu>
...

2. recheck the xml after edit:

# virsh dumpxml test4 |grep "<cpu>"
# echo $?
1

Comment 4 Luyao Huang 2015-07-07 08:14:21 UTC

retest with libvirt-1.2.17-1.el7.x86_64 and get the same result.

Comment 6 errata-xmlrpc 2015-11-19 06:20:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2202.html