RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1202606 - libvirt should improve the xml format when define a vm have a empty <cpu/>
Summary: libvirt should improve the xml format when define a vm have a empty <cpu/>
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.1
Hardware: x86_64
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Andrea Bolognani
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-17 02:43 UTC by Luyao Huang
Modified: 2015-11-19 06:20 UTC (History)
6 users (show)

Fixed In Version: libvirt-1.2.15-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-19 06:20:31 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:2202 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2015-11-19 08:17:58 UTC

Description Luyao Huang 2015-03-17 02:43:36 UTC
description of problem:
libvirt should improve the xml format when define a vm have a empty <cpu/>

Version-Release number of selected component (if applicable):
libvirt-1.2.8-16.el7_1.1.x86_64
qemu-kvm-rhev-2.1.2-23.el7_1.1.x86_64

How reproducible:
100%

Steps to Reproduce:
 
1.edit a vm like this:
# virsh edit test3
...
  <cpu>
  </cpu>
...

2.check the xml
# virsh dumpxml test3
...
  <cpu>
  </cpu>
...

Actual results:
libvirt still format a empty <cpu/> and do not show any useful information in it.

Expected results:
if <cpu/> do not contain any special means in it, no need format it in xml, it will waste time to parse it.
if <cpu/> contain some special things, we should show them clearly in the xml.

Additional info:

Comment 1 Andrea Bolognani 2015-04-13 10:29:20 UTC
This has been fixed upstream with the following commit.

commit e4d7ddfdd2220046b8ca9f5e2af3a5d45e962e44
Author: Andrea Bolognani <abologna>
Date:   Fri Apr 10 15:09:59 2015 +0200

    conf: Don't output <cpu> tag if it contains no information.
    
    The tag is already marked as optional in the schema, so no changes
    are needed there.


v1.2.14-107-ge4d7ddf

Comment 3 Luyao Huang 2015-07-07 06:50:26 UTC
Verify this bug with libvirt-1.2.16-1.el7.x86_64:

1 . add a empty cpu element in guest xml:

# virsh edit test4
...
  <cpu>
  </cpu>
...

2. recheck the xml after edit:

# virsh dumpxml test4 |grep "<cpu>"
# echo $?
1

Comment 4 Luyao Huang 2015-07-07 08:14:21 UTC
retest with libvirt-1.2.17-1.el7.x86_64 and get the same result.

Comment 6 errata-xmlrpc 2015-11-19 06:20:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2202.html


Note You need to log in before you can comment on or make changes to this bug.