Bug 1202887 (signon-ui)

Summary:	Review Request: signon-ui - Online Accounts Sign-on Ui
Product:	[Fedora] Fedora	Reporter:	Daniel Vrátil <dvratil>
Component:	Package Review	Assignee:	Jan Grulich <jgrulich>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jeischma, jgrulich, kevin, package-review, rdieter
Target Milestone:	---	Flags:	jgrulich: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-31 09:57:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1070406, 1202848
Bug Blocks:	656997, 1135564, 1202890

Description Daniel Vrátil 2015-03-17 15:54:37 UTC

Spec URL: https://dvratil.fedorapeople.org/spec/signon-ui.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/signon-ui-0.15-1.fc21.src.rpm
Description: Sign-on UI is the component responsible for handling the user interactions which can happen during the login process of an online account.
It can show password dialogs and dialogs with embedded web pages.
Fedora Account System Username: dvratil

Comment 1 Jan Grulich 2015-03-25 09:22:25 UTC

1) License: GPLv2 and GPLv2 ← doesn't seem to be correct, licensecheck says that almost all files are under GPLv3

2) Typo in "mkdir -p %{buildroot}/%{_sysconfdir}/sigon-ui/webkit-options.d", replace sigon with signon

rpmlint
-------
signon-ui.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo gin
signon-ui.x86_64: W: spelling-error %description -l en_US dialogs -> dialog, dialog s
signon-ui.x86_64: W: no-manual-page-for-binary signon-ui
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Comment 2 Daniel Vrátil 2015-03-25 09:59:06 UTC

The license's a typo, it should've been "GPLv2 and GPLv3"

Spec URL: https://dvratil.fedorapeople.org/spec/signon-ui.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/signon-ui-0.15-1.fc21.src.rpm

* Wed Mar 25 2015 Daniel Vrátil <dvratil> - 0.15-2
- fix license
- fix typo in mkdir arguments
- use %%license

Comment 3 Jan Grulich 2015-03-25 10:15:36 UTC

Looks good now, APPROVED.

Comment 4 Daniel Vrátil 2015-03-25 12:37:26 UTC

New Package SCM Request
=======================
Package Name: signon-ui
Short Description: Online Accounts Sign-on Ui
Upstream URL: https://launchpad.net/signon-ui
Owners: group::kde-sig
Branches: f22
InitialCC:

Comment 5 Kevin Kofler 2015-03-25 13:40:27 UTC

"GPLv2 and GPLv3"? Sure? They're mixing 2 incompatible licenses??? WTF?!

Comment 6 Daniel Vrátil 2015-03-25 14:11:07 UTC

There is one filed copied from Qt, which is licensed under LGPL 2.1 or alternatively under GPLv3. The rest of the project is GPLv3, so I guess GPLv3 is correct, and I was just confused by licensecheck. Fixed the license locally in SPEC.

(http://bazaar.launchpad.net/~online-accounts/signon-ui/trunk/view/head:/src/my-network-proxy-factory.cpp)

Comment 7 Gwyn Ciesla 2015-03-25 14:14:02 UTC

Git done (by process-git-requests).