Spec URL: https://dvratil.fedorapeople.org/spec/signon-ui.spec SRPM URL: https://dvratil.fedorapeople.org/spec/signon-ui-0.15-1.fc21.src.rpm Description: Sign-on UI is the component responsible for handling the user interactions which can happen during the login process of an online account. It can show password dialogs and dialogs with embedded web pages. Fedora Account System Username: dvratil
1) License: GPLv2 and GPLv2 ← doesn't seem to be correct, licensecheck says that almost all files are under GPLv3 2) Typo in "mkdir -p %{buildroot}/%{_sysconfdir}/sigon-ui/webkit-options.d", replace sigon with signon rpmlint ------- signon-ui.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo gin signon-ui.x86_64: W: spelling-error %description -l en_US dialogs -> dialog, dialog s signon-ui.x86_64: W: no-manual-page-for-binary signon-ui 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
The license's a typo, it should've been "GPLv2 and GPLv3" Spec URL: https://dvratil.fedorapeople.org/spec/signon-ui.spec SRPM URL: https://dvratil.fedorapeople.org/spec/signon-ui-0.15-1.fc21.src.rpm * Wed Mar 25 2015 Daniel Vrátil <dvratil> - 0.15-2 - fix license - fix typo in mkdir arguments - use %%license
Looks good now, APPROVED.
New Package SCM Request ======================= Package Name: signon-ui Short Description: Online Accounts Sign-on Ui Upstream URL: https://launchpad.net/signon-ui Owners: group::kde-sig Branches: f22 InitialCC:
"GPLv2 and GPLv3"? Sure? They're mixing 2 incompatible licenses??? WTF?!
There is one filed copied from Qt, which is licensed under LGPL 2.1 or alternatively under GPLv3. The rest of the project is GPLv3, so I guess GPLv3 is correct, and I was just confused by licensecheck. Fixed the license locally in SPEC. (http://bazaar.launchpad.net/~online-accounts/signon-ui/trunk/view/head:/src/my-network-proxy-factory.cpp)
Git done (by process-git-requests).