Bug 1204240

Summary:	the exclude_vcs option seems to be behaving opposite its intended meaning
Product:	[Fedora] Fedora	Reporter:	Roy Bonser <rbonser>
Component:	mock	Assignee:	Miroslav Suchý <msuchy>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jdisnard, mebrown, msimacek, msuchy, praiskup, williams
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	mock-1.2.10-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-01 16:50:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Roy Bonser 2015-03-20 16:39:57 UTC

Description of problem:
I believe the scm configuration option for exclude_vcs is behaving opposite its intended meaning.

Version-Release number of selected component (if applicable):
I have tried this on f21 and epel7
mock-1.2.7-1.el7.noarch
mock-scm-1.2.7-1.el7.noarch
mock-1.2.7-1.fc21.noarch
mock-scm-1.2.7-1.fc21.noarch

How reproducible:
always

Steps to Reproduce:
1. configure mock to clone a repo that has source to be tar'd
2. set write_tar true and leave exclude_vcs unset or set exclude_vcs true
3. mock build rpm

Actual results:
tar contains .git data

Expected results:
the .git data should be excluded

Additional info:
When I set the exclude_vcs option to false the .git data does get excluded from the tarball. 


I believe the issue was introduced in commit https://git.fedorahosted.org/cgit/mock.git/commit/py/mockbuild/scm.py?id=d3afdd18faabbcc3f25e4a883393f102f91476bc

where:
-            if not str(self.exclude_vcs).lower() == "false":
+            if not self.exclude_vcs:

seems to have changed the behavior from if not false to if not true. Removing the word not fixes the behavior for me.

  --Roy

Comment 1 Miroslav Suchý 2015-04-22 11:07:47 UTC

Fixed in:
  * 0a3224d  scm correct the logic of exclude_vcs [RHBZ#1204240]

Comment 2 Fedora Update System 2015-04-29 13:16:35 UTC

mock-1.2.8-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc22

Comment 3 Fedora Update System 2015-04-29 13:16:59 UTC

mock-1.2.8-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc21

Comment 4 Fedora Update System 2015-04-29 13:18:11 UTC

mock-1.2.8-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc20

Comment 5 Fedora Update System 2015-04-29 13:19:01 UTC

mock-1.2.8-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.el7

Comment 6 Fedora Update System 2015-04-29 13:25:25 UTC

mock-1.2.8-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.el6

Comment 7 Fedora Update System 2015-04-29 19:18:44 UTC

Package mock-1.2.8-1.el7:
* should fix your issue,
* was pushed to the Fedora EPEL 7 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing mock-1.2.8-1.el7'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6057/mock-1.2.8-1.el7
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2015-05-01 16:50:48 UTC

mock-1.2.8-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2015-05-02 18:08:27 UTC

mock-1.2.8-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2015-05-12 20:46:41 UTC

mock-1.2.8-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2015-06-04 11:41:41 UTC

mock-1.2.10-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mock-1.2.10-1.el7

Comment 12 Fedora Update System 2015-06-04 11:42:19 UTC

mock-1.2.10-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/mock-1.2.10-1.el6

Comment 13 Fedora Update System 2015-06-20 21:09:44 UTC

mock-1.2.10-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-06-20 21:13:06 UTC

mock-1.2.10-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.