Description of problem: I believe the scm configuration option for exclude_vcs is behaving opposite its intended meaning. Version-Release number of selected component (if applicable): I have tried this on f21 and epel7 mock-1.2.7-1.el7.noarch mock-scm-1.2.7-1.el7.noarch mock-1.2.7-1.fc21.noarch mock-scm-1.2.7-1.fc21.noarch How reproducible: always Steps to Reproduce: 1. configure mock to clone a repo that has source to be tar'd 2. set write_tar true and leave exclude_vcs unset or set exclude_vcs true 3. mock build rpm Actual results: tar contains .git data Expected results: the .git data should be excluded Additional info: When I set the exclude_vcs option to false the .git data does get excluded from the tarball. I believe the issue was introduced in commit https://git.fedorahosted.org/cgit/mock.git/commit/py/mockbuild/scm.py?id=d3afdd18faabbcc3f25e4a883393f102f91476bc where: - if not str(self.exclude_vcs).lower() == "false": + if not self.exclude_vcs: seems to have changed the behavior from if not false to if not true. Removing the word not fixes the behavior for me. --Roy
Fixed in: * 0a3224d scm correct the logic of exclude_vcs [RHBZ#1204240]
mock-1.2.8-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc22
mock-1.2.8-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc21
mock-1.2.8-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc20
mock-1.2.8-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mock-1.2.8-1.el7
mock-1.2.8-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.2.8-1.el6
Package mock-1.2.8-1.el7: * should fix your issue, * was pushed to the Fedora EPEL 7 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing mock-1.2.8-1.el7' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6057/mock-1.2.8-1.el7 then log in and leave karma (feedback).
mock-1.2.8-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.2.8-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.2.8-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.2.10-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mock-1.2.10-1.el7
mock-1.2.10-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.2.10-1.el6
mock-1.2.10-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.2.10-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.