Bug 1205793 (signon-kwallet-extension)
| Summary: | Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeischma, kevin, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
puiterwijk: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-04-07 08:39:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1070406 | ||
| Bug Blocks: | 656997, 1135564 | ||
|
Description
Daniel Vrátil
2015-03-25 15:50:07 UTC
> # Remove the no-soname library, we don't need -devel for a plugin
> rm %{buildroot}/%{_libdir}/signon/extensions/libkeyring-kwallet.so
Uh, isn't the unversioned .so how the plugin is found?
You should really fix the CMakeLists.txt instead to not try to version the plugin to begin with and install the actual plugin as the unversioned .so instead.
Spec URL: https://dvratil.fedorapeople.org/spec/signon-kwallet-extension.spec SRPM URL: https://dvratil.fedorapeople.org/spec/signon-kwallet-extension-15.03.95-2.fc21.src.rpm * Tue Mar 31 2015 Daniel Vrátil <dvratil> - 15.03.95-2 - add upstream patch to drop lib soname naming: ok 1. license: NOT ok, src files appear to be GPLv2+ scriptlets: ok macros: ok %files/ownership: ok (just fixed signon to properly own libdir/extensions) builds/installs ok The only item I found was the licensing, should be: License: GPLv2+ please fix prior to building. APPROVED New Package SCM Request ======================= Package Name: signon-kwallet-extension Short KWallet integration for Sign-on framework Upstream URL: https://projects.kde.org/projects/kde/kdenetwork/signon-kwallet-extension Owners: group::kde-sig Branches: f22 InitialCC: Git done (by process-git-requests). |