Bug 1205793 (signon-kwallet-extension) - Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework
Summary: Review Request: signon-kwallet-extension - KWallet integration for Sign-on fr...
Keywords:
Status: CLOSED RAWHIDE
Alias: signon-kwallet-extension
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: signon, signon-qt5
Blocks: kde-reviews ktp-kf5
TreeView+ depends on / blocked
 
Reported: 2015-03-25 15:50 UTC by Daniel Vrátil
Modified: 2015-11-02 01:38 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-04-07 08:39:31 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
puiterwijk: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Vrátil 2015-03-25 15:50:07 UTC
Spec URL: https://dvratil.fedorapeople.org/spec/signon-kwallet-extension.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/signon-kwallet-extension-15.03.95-1.fc21.src.rpm
Description: KWallet integration for Sign-on framework
Fedora Account System Username: dvratil

Comment 1 Kevin Kofler 2015-03-25 16:41:26 UTC
> # Remove the no-soname library, we don't need -devel for a plugin
> rm %{buildroot}/%{_libdir}/signon/extensions/libkeyring-kwallet.so

Uh, isn't the unversioned .so how the plugin is found?

You should really fix the CMakeLists.txt instead to not try to version the plugin to begin with and install the actual plugin as the unversioned .so instead.

Comment 2 Daniel Vrátil 2015-03-31 09:53:10 UTC
Spec URL: https://dvratil.fedorapeople.org/spec/signon-kwallet-extension.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/signon-kwallet-extension-15.03.95-2.fc21.src.rpm

* Tue Mar 31 2015 Daniel Vrátil <dvratil> - 15.03.95-2
- add upstream patch to drop lib soname

Comment 3 Rex Dieter 2015-04-01 12:13:45 UTC
naming: ok

1.  license: NOT ok, src files appear to be GPLv2+

scriptlets: ok

macros: ok

%files/ownership: ok  (just fixed signon to properly own libdir/extensions)

builds/installs ok


The only item I found was the licensing, should be:
License: GPLv2+
please fix prior to building.


APPROVED

Comment 4 Daniel Vrátil 2015-04-01 12:42:41 UTC
New Package SCM Request
=======================
Package Name: signon-kwallet-extension
Short KWallet integration for Sign-on framework
Upstream URL: https://projects.kde.org/projects/kde/kdenetwork/signon-kwallet-extension
Owners: group::kde-sig
Branches: f22
InitialCC:

Comment 5 Patrick Uiterwijk 2015-04-02 14:28:24 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.