Bug 1206097

Summary:	virt-manager adds subsequent disks as IDE although first one is VirtIO by default
Product:	Red Hat Enterprise Linux 7	Reporter:	Alexander Todorov <atodorov>
Component:	virt-manager	Assignee:	Pavel Hrdina <phrdina>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.1	CC:	abologna, gscrivan, juzhou, mzhan, phrdina, tzheng, xiaodwan
Target Milestone:	rc	Keywords:	Upstream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-manager-1.2.1-5.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 05:24:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alexander Todorov 2015-03-26 10:13:18 UTC

Description of problem:

I've expected that once VirtIO is chosen by default all disks added to the Vm system will use it. Turns out this is not the case.


Version-Release number of selected component (if applicable):

virt-manager-1.1.0-12.el7.noarch

How reproducible:

Always

Steps to Reproduce:
1. Using virt-manager create new VM guest
2. Using HTTP based install the distro is recognized as Linux/Unknown (it's RHEL Atomic Host). Same results if using a RHEL 7 distro, recognized as Linux/RHEL 7.0 by virt-manager.
3. First disk added is VirtIO
4. Customize the configuration by adding additional disks (3 in my case)

Actual results:
virt-manager UI by default uses IDE for bus type. In addition anaconda recognizes the additional disks as IDE ones, not VirtIO ones.

Expected results:
If VirtIO is the default configuration for the first disk I expect this to be the default for any additional ones as well. 


Additional info:

Comment 1 Giuseppe Scrivano 2015-03-26 14:29:05 UTC

commit 0aa200604a843250f6291498929d0d534fc57d4f
Author: Giuseppe Scrivano <gscrivan>
Date:   Thu Mar 26 14:44:24 2015 +0100

    addhardware: default to an existing bus when adding a new disk
    
    When a new disk is added, by default choose a bus that is already used
    by an existing disk, if any.
    
    Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1206097
    
    Signed-off-by: Giuseppe Scrivano <gscrivan>

Comment 2 Xiaodai Wang 2015-07-06 08:14:29 UTC

(In reply to Giuseppe Scrivano from comment #1)
> commit 0aa200604a843250f6291498929d0d534fc57d4f
> Author: Giuseppe Scrivano <gscrivan>
> Date:   Thu Mar 26 14:44:24 2015 +0100
> 
>     addhardware: default to an existing bus when adding a new disk
>     
>     When a new disk is added, by default choose a bus that is already used
>     by an existing disk, if any.
>     
>     Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1206097
>     
>     Signed-off-by: Giuseppe Scrivano <gscrivan>

I tested it with virt-manager-1.2.1-2.el7.noarch, when the first storage is virtio scsi, and add a second storage, the default bus type is IDE but virtio scsi. Is it a bug?

Comment 4 Xiaodai Wang 2015-07-08 08:45:57 UTC

Hi Pavel,

Now it looks like this issue is partially fixed. you can see #Comment 2 for details.

I tested it with virt-manager-1.2.1-2.el7.noarch, when the first storage is virtio scsi, and add a second storage, the default bus type is IDE but virtio scsi.

Could you help confirm it?

Thanks
xiaodwan

Comment 5 Pavel Hrdina 2015-07-20 17:14:35 UTC

Hi Xiaodai,

I'll look at this again. I've cleared the needinfo flag and assigned it to me.

Comment 6 Pavel Hrdina 2015-07-20 17:49:28 UTC

Actually, could you please provide exact steps how to reproduce that issue? I've tried to update existing guest and also update configuration while installing a new guest and in both cases the second disk had a default the same as the existing disk.

Comment 7 Xiaodai Wang 2015-07-21 02:34:34 UTC

(In reply to Pavel Hrdina from comment #6)
> Actually, could you please provide exact steps how to reproduce that issue?
> I've tried to update existing guest and also update configuration while
> installing a new guest and in both cases the second disk had a default the
> same as the existing disk.

For an existing shutdown guest, assume an IDE disk is existing:
1. Launching virt-manager, open the guest's hardware details window.
2. Click Add Hardware to add a new storage, and set the Bus type to "VirtIO SCSI".
3. Select the existing IDE disk and remove it, now only a virtio scsi disk exist.
4. Click Add Hardware to add a new storage

Now check the Default Bus type is "IDE" but "VirtIO SCSI".

Comment 8 Pavel Hrdina 2015-08-05 12:13:41 UTC

Upstream commits:

commit 745fa9fa5e958363cd00f81e62df27b61b531b7e
Author: Pavel Hrdina <phrdina>
Date:   Mon Aug 3 18:52:07 2015 +0200

    scsi-storage: unify SCSI storage code and logic
    
    There is no virtio-scsi or spapr-vscsi bus, but only 'scsi' bus.  There
    are several types of SCSI controllers, but the SCSI storage don't care
    about the SCSI controller and there is also no difference in address
    specification or address type.  Use only 'scsi' bus for all SCSI storages
    to correspond the reality and also the libvirt domain XML.  The only
    difference is in the type of SCSI controller
    
    Signed-off-by: Pavel Hrdina <phrdina>

commit db9d851c967d29973bfeac786aacbd0b68275148
Author: Pavel Hrdina <phrdina>
Date:   Mon Aug 3 18:52:06 2015 +0200

    Revert "create: customize: Hide bus=virtio-scsi"
    
    This reverts commit cca34185c01971e9433c162abf0eee1525322516.
    
    Signed-off-by: Pavel Hrdina <phrdina>

Comment 11 fwu 2015-08-12 06:28:27 UTC

I can reproduce this bug on package:
virt-manager-1.1.0-12.el7.noarch

Steps are the same as Comment 0.

And reproduce this bug partially as described in Comment 2 with package:
virt-manager-1.2.0-4.el7.noarch

Steps are the same as Comment 7.

Then try to verify with new build:
virt-manager-1.2.1-5.el7.noarch

Steps:
1. Launching virt-manager, prepare a guest with no storage device.
2. Click Add Hardware to add a new storage, and set the bus type to "VirtIO".
3. Click Add Hardware to add a new storage without changing the given bus type and check the bus type of the storage.
4. Delete all exist storage device of guest. Repeat Step 2 with "SATA", "SCSI", "IDE", "SD" bus type.

Results:
After step 3, the default bus type of newly added storage device is consistent with the first device.

According to the result above in the latest version of virt-manager, move this bug from ON_QA to VERIFIED.

Comment 12 Pavel Hrdina 2015-11-03 15:35:42 UTC

*** Bug 1261416 has been marked as a duplicate of this bug. ***

Comment 14 errata-xmlrpc 2015-11-19 05:24:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2206.html