Bug 1206672
| Summary: | UI: Orchestration Templates - Copy should use Add screen layout | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Dan Clarizio <dclarizi> | ||||
| Component: | UI - OPS | Assignee: | Milan Zázrivec <mzazrivec> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Nandini Chandra <nachandr> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.4.0 | CC: | dclarizi, hkataria, jhardy, mpovolny, nachandr, obarenbo | ||||
| Target Milestone: | GA | ||||||
| Target Release: | 5.4.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-06-16 12:55:51 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
I have no problem with the design as outlined above, but there's one problem with this -- if we allow user to submit unmodified template, our application will return the template content md5 error. In another words, enabling the save button only if some change has been made was a bit intentional. My question here is -- are we OK with the consequence of the Add/Cancel design as described in the first paragraph? New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/8729b552b4a66def579772253546d1323ca200f7 commit 8729b552b4a66def579772253546d1323ca200f7 Author: Milan Zazrivec <mzazrivec> AuthorDate: Tue Apr 7 12:43:42 2015 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Thu Apr 9 08:14:27 2015 +0200 Revamp of orchestration template copying We want to use Add / Cancel buttons in the OT copy form rather than Save / Reset / Cancel. https://bugzilla.redhat.com/show_bug.cgi?id=1206672 vmdb/app/controllers/catalog_controller.rb | 40 +++++++++++------------- vmdb/app/views/catalog/_ot_copy.html.haml | 1 + vmdb/spec/controllers/catalog_controller_spec.rb | 18 +++++++---- 3 files changed, 32 insertions(+), 27 deletions(-) Verified in 5.4.0.0.24 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1100.html |
Created attachment 1007409 [details] OT Copy showing edit screen Description of problem: When copying an OT, the screen presented is currently an edit screen, with Save/Reset/Cancel buttons and Save/Reset are not enabled until a field is changed. Version-Release number of selected component (if applicable): 5.4.0 How reproducible: Copy an OT Expected results: Copy should present and add screen, with Add/Cancel buttons enabled, like other product areas.