Bug 1206672 - UI: Orchestration Templates - Copy should use Add screen layout
Summary: UI: Orchestration Templates - Copy should use Add screen layout
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.4.0
Assignee: Milan Zázrivec
QA Contact: Nandini Chandra
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-27 17:46 UTC by Dan Clarizio
Modified: 2015-06-16 12:55 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-16 12:55:51 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
OT Copy showing edit screen (24.96 KB, image/png)
2015-03-27 17:46 UTC, Dan Clarizio
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1100 0 normal SHIPPED_LIVE CFME 5.4.0 bug fixes, and enhancement update 2015-06-16 16:28:42 UTC

Description Dan Clarizio 2015-03-27 17:46:53 UTC
Created attachment 1007409 [details]
OT Copy showing edit screen

Description of problem:
When copying an OT, the screen presented is currently an edit screen, with Save/Reset/Cancel buttons and Save/Reset are not enabled until a field is changed.

Version-Release number of selected component (if applicable):
5.4.0

How reproducible:
Copy an OT

Expected results:
Copy should present and add screen, with Add/Cancel buttons enabled, like other product areas.

Comment 2 Milan Zázrivec 2015-03-30 14:52:32 UTC
I have no problem with the design as outlined above, but there's one problem
with this -- if we allow user to submit unmodified template, our application
will return the template content md5 error.

In another words, enabling the save button only if some change has been
made was a bit intentional.

My question here is -- are we OK with the consequence of the Add/Cancel
design as described in the first paragraph?

Comment 4 Milan Zázrivec 2015-04-07 12:38:49 UTC
https://github.com/ManageIQ/manageiq/pull/2536

Comment 5 CFME Bot 2015-04-21 14:16:13 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/8729b552b4a66def579772253546d1323ca200f7

commit 8729b552b4a66def579772253546d1323ca200f7
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Tue Apr 7 12:43:42 2015 +0200
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Thu Apr 9 08:14:27 2015 +0200

    Revamp of orchestration template copying
    
    We want to use Add / Cancel buttons in the OT copy form
    rather than Save / Reset / Cancel.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1206672

 vmdb/app/controllers/catalog_controller.rb       | 40 +++++++++++-------------
 vmdb/app/views/catalog/_ot_copy.html.haml        |  1 +
 vmdb/spec/controllers/catalog_controller_spec.rb | 18 +++++++----
 3 files changed, 32 insertions(+), 27 deletions(-)

Comment 7 Nandini Chandra 2015-05-01 19:49:16 UTC
Verified in 5.4.0.0.24

Comment 9 errata-xmlrpc 2015-06-16 12:55:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html


Note You need to log in before you can comment on or make changes to this bug.