Bug 1207591 (andrewsville/php-token-reflection)
| Summary: | Review Request: php-andrewsville-php-token-reflection - Library emulating the PHP internal reflection | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-andrewsville-php-token-reflection-1.4.0-2.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-06-04 20:13:10 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1205346 | ||||||||
| Attachments: |
|
||||||||
|
Description
Remi Collet
2015-03-31 09:19:59 UTC
Please include mksrc.sh as a source so it gets included in the srpm :) (In reply to Shawn Iwinski from comment #1) > Please include mksrc.sh as a source so it gets included in the srpm :) Damn, sorry. https://github.com/remicollet/remirepo/commit/31a4c11bdacbbeebe489f90cf60dfd0ad029a4df Spec: https://raw.githubusercontent.com/remicollet/remirepo/31a4c11bdacbbeebe489f90cf60dfd0ad029a4df/php/php-andrewsville-php-token-reflection/php-andrewsville-php-token-reflection.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-andrewsville-php-token-reflection-1.4.0-2.remi.src.rpm Created attachment 1028214 [details]
fedora-review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1207591
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Created attachment 1028215 [details]
phpcompatinfo.log
phpCompatInfo version 3.7.3
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, remove EPEL 5 bits after initial import.
No blockers.
===== APPROVED =====
Thanks for the review ! New Package SCM Request ======================= Package Name: php-andrewsville-php-token-reflection Short Description: Library emulating the PHP internal reflection Upstream URL: https://github.com/andrewsville/php-token-reflection Owners: remi Branches: f21 f22 epel7 InitialCC: Git done (by process-git-requests). php-andrewsville-php-token-reflection-1.4.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-andrewsville-php-token-reflection-1.4.0-2.fc21 php-andrewsville-php-token-reflection-1.4.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-andrewsville-php-token-reflection-1.4.0-2.el7 php-andrewsville-php-token-reflection-1.4.0-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-andrewsville-php-token-reflection-1.4.0-2.fc22 php-andrewsville-php-token-reflection-1.4.0-2.fc22 has been pushed to the Fedora 22 testing repository. php-andrewsville-php-token-reflection-1.4.0-2.fc22 has been pushed to the Fedora 22 stable repository. php-andrewsville-php-token-reflection-1.4.0-2.fc21 has been pushed to the Fedora 21 stable repository. php-andrewsville-php-token-reflection-1.4.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |