Bug 1205346 (bartlett/umlwriter) - Review Request: php-bartlett-umlwriter - Create UML class diagrams from your PHP source
Summary: Review Request: php-bartlett-umlwriter - Create UML class diagrams from your ...
Alias: bartlett/umlwriter
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
Depends On: andrewsville/php-token-reflection
TreeView+ depends on / blocked
Reported: 2015-03-24 18:10 UTC by Remi Collet
Modified: 2015-06-10 19:17 UTC (History)
2 users (show)

Fixed In Version: php-bartlett-umlwriter-1.0.0-2.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2015-06-04 20:10:25 UTC
Type: ---
shawn: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
fedora-review.txt (8.07 KB, text/plain)
2015-05-21 19:20 UTC, Shawn Iwinski
no flags Details
phpcompatinfo.log (6.82 KB, text/plain)
2015-05-21 19:21 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2015-03-24 18:10:19 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/7203eb3b8a9d87446b3a8003fc600309c8506178/php/bartlett/php-bartlett-umlwriter/php-bartlett-umlwriter.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-bartlett-umlwriter-1.0.0-0.1.RC1.remi.src.rpm
This tool wil generate UML class diagrams with all class,
interface and trait definitions in your PHP project.

* reverse-engine interchangeable (currently support Bartlett\Reflect
  and Andrewsville\TokenReflection)
* UML syntax processor interchangeable (currently support Graphviz
  and PlantUML)
* generates a class and its direct dependencies
* generates a namespace with all objects
* generates a full package with all namespaces and objects

Fedora Account System Username: remi


New optional dependency of phpreflect 3.0.0
As usually, I will clean EL-5 stuff after import.

Comment 4 Shawn Iwinski 2015-05-21 14:26:50 UTC
Bootstrap with_tests logic is reversed and fedora-review fails because of test php-composer(bartlett/php-reflect) >= 3.0 dependency

Comment 5 Remi Collet 2015-05-21 14:45:44 UTC
@Shawn sorry.

I think (in the specfile) is ok.
But uploaded srpm file have bootstrap = 0 (used for my build)

I just re-upload the .src.rpm in sync with latest .spec

Comment 6 Shawn Iwinski 2015-05-21 19:20:36 UTC
Created attachment 1028372 [details]

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1205346
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby

Comment 7 Shawn Iwinski 2015-05-21 19:21:25 UTC
Created attachment 1028373 [details]

phpCompatInfo version 3.7.3

Comment 8 Shawn Iwinski 2015-05-21 19:22:59 UTC
[x]: Requires correct, justified where necessary.

     For completeness, from phpcompatinfo:
         Requires: php-spl

     Composer "bartlett/php-reflect": "3.0.*@dev" equates to
     >= 3.0.0 and <  3.1.0 but requires are:
         Requires: php-composer(bartlett/php-reflect) >= 3.0
         Requires: php-composer(bartlett/php-reflect) <  4
     I'm sure it will be fine based on semantic versioning rules but just a note.

No blockers.

===== APPROVED =====

Comment 9 Remi Collet 2015-05-22 04:49:25 UTC
About dep, works with 3.1.0 which is compatible with 3.0.x
Reported upstream as https://github.com/llaville/umlwriter/issues/3
But this is only in requires-dev, no version in suggest.

Comment 10 Remi Collet 2015-05-22 04:50:49 UTC
Thanks for the review

New Package SCM Request
Package Name: php-bartlett-umlwriter
Short Description: Create UML class diagrams from your PHP source
Upstream URL: https://github.com/llaville/umlwriter
Owners: remi
Branches: f21 f22 epel7

Comment 11 Gwyn Ciesla 2015-05-22 12:48:35 UTC
Git done (by process-git-requests).

Comment 12 Fedora Update System 2015-05-22 17:47:40 UTC
php-bartlett-umlwriter-1.0.0-2.el7 has been submitted as an update for Fedora EPEL 7.

Comment 13 Fedora Update System 2015-05-22 17:47:46 UTC
php-bartlett-umlwriter-1.0.0-2.fc22 has been submitted as an update for Fedora 22.

Comment 14 Fedora Update System 2015-05-22 17:47:53 UTC
php-bartlett-umlwriter-1.0.0-2.fc21 has been submitted as an update for Fedora 21.

Comment 15 Fedora Update System 2015-05-26 03:28:26 UTC
php-bartlett-umlwriter-1.0.0-2.fc22 has been pushed to the Fedora 22 testing repository.

Comment 16 Fedora Update System 2015-06-04 20:10:25 UTC
php-bartlett-umlwriter-1.0.0-2.fc22 has been pushed to the Fedora 22 stable repository.

Comment 17 Fedora Update System 2015-06-04 20:15:29 UTC
php-bartlett-umlwriter-1.0.0-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 18 Fedora Update System 2015-06-10 19:17:52 UTC
php-bartlett-umlwriter-1.0.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.

Note You need to log in before you can comment on or make changes to this bug.