Bug 1208833

Updated files, without doc sub-package, newest version of Nilus font:

https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-aegyptus-fonts/gdouros-aegyptus-fonts.spec

https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-aegyptus-fonts/gdouros-aegyptus-fonts-5.03-2.fc21.src.rpm

Review:

+ mock build is successful for F23 (x86_64)

+ rpmlint on generated rpms gave output
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
 
+ Source verified with upstream as (sha256sum)
srpm Source0: 64eeb840084a512779e2f0ad08e8d670346c3bafe5d81bddac8ba8c69376d527
upstream Source0 : 64eeb840084a512779e2f0ad08e8d670346c3bafe5d81bddac8ba8c69376d527
srpm Source3 : 927600d70b45568b2f23e677a3e7a6a29f948bc10134b33305cde9639e845604
upstream Source3 : 927600d70b45568b2f23e677a3e7a6a29f948bc10134b33305cde9639e845604

+ License is "Public Domain" as per given on upstream website "Fonts and documents in this site are not pieces of property or merchandise items; they carry no trademark, copyright, license or other market tags; they are free for any use". So no license text is included in font file or any text file

+ follows fonts packaging guidelines.

+ fontconfig file is present at priority 65.

+ Appdata metainfo file is present.


Suggestions:
1) Please package per family only and corresponding fontconfig file for that font. Drop Nilus* and Gardiner* files, references from spec file. You may want to submit them as separate packages. 

Provide new updated srpm which contains only aegyptus fonts.

Let's follow the same guideline here.
I propose to follow https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages with following changes

%global checkout 20150430

Release:        0.2.%{checkout}%{?dist}

also add changelog that uses 5.03-0.2.20150430

(In reply to Parag AN(पराग) from comment #2)
> 1) Please package per family only and corresponding fontconfig file for that
> font. Drop Nilus* and Gardiner* files, references from spec file. You may
> want to submit them as separate packages.

Is there a way to let users know that they might be interested in the other two (not yet created) packages, that works regardless of whether they install packages from the terminal or with a graphical package manager?

(In reply to Alexander Ploumistos from comment #4)
> Is there a way to let users know that they might be interested in the other
> two (not yet created) packages, that works regardless of whether they
> install packages from the terminal or with a graphical package manager?

I asked Richard Hughes about that and he suggested that I create a meta-font that references 3 packages. I'll look into that right after I have updated all of the spec files and srpms.

Updated files:

https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-aegyptus-fonts/gdouros-aegyptus-fonts.spec

https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-aegyptus-fonts/gdouros-aegyptus-fonts-5.03-0.2.20150430.fc21.src.rpm

(In reply to Alexander Ploumistos from comment #4)
> (In reply to Parag AN(पराग) from comment #2)
> > 1) Please package per family only and corresponding fontconfig file for that
> > font. Drop Nilus* and Gardiner* files, references from spec file. You may
> > want to submit them as separate packages.
> 
> Is there a way to let users know that they might be interested in the other
> two (not yet created) packages, that works regardless of whether they
> install packages from the terminal or with a graphical package manager?

Only I think on this is to modify %description and add a line where you can say other fonts provided by this font developer are <pkg1>, <pkg2>

But this is really not needed as one can search fonts and their package summary will appear when they do like this
dnf search gdourus

Or you can write a blog and feed it to planet.fedoraproject.org and also google can then show your blog entry in google search.

(In reply to Alexander Ploumistos from comment #5)
> (In reply to Alexander Ploumistos from comment #4)
> > Is there a way to let users know that they might be interested in the other
> > two (not yet created) packages, that works regardless of whether they
> > install packages from the terminal or with a graphical package manager?
> 
> I asked Richard Hughes about that and he suggested that I create a meta-font
> that references 3 packages. I'll look into that right after I have updated
> all of the spec files and srpms.

We package per family fonts. See https://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming page. So all other fonts need to be packaged as separate fonts and they will provide their own metainfo file. Just check all those 3 fonts have no common family name all are different.

(In reply to Parag AN(पराग) from comment #8)
> We package per family fonts. See
> https://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming page. So all
> other fonts need to be packaged as separate fonts and they will provide
> their own metainfo file. Just check all those 3 fonts have no common family
> name all are different.

The thing is that upstream does not follow typographic conventions, so even though these fonts *should* be in the same family, they are not. You have seen the structure of his web page; there is some sort of grouping that sometimes makes sense, others not so much.
On the other hand, he ships Alexander and several others in the TextFonts package, so at some point we could have gdouros-textfonts-alexander-fonts and such.

The updated srpm in comment#6 looks good now.

Package APPROVED.

You want to submit here package change request to own this package. See https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages

Do I need to specify the branches in my request, or is the following sufficient?

Package Change Request
======================
Package Name: gdouros-aegyptus-fonts
Owners: alexpl
InitialCC: fonts-sig


(not setting the cvs flag yet on purpose)

Yes add again CVS request with all the branches where you want to be owner.

Package Change Request
======================
Package Name: gdouros-aegyptus-fonts
Branches: f20 f21 f22 master
Owners: alexpl
InitialCC: fonts-sig

Complete.

gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22

Package gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-7627/gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22
then log in and leave karma (feedback).

gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.