Bug 1208833 - Re-Review Request: gdouros-aegyptus-fonts - A font for Egyptian hieroglyphs
Summary: Re-Review Request: gdouros-aegyptus-fonts - A font for Egyptian hieroglyphs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-03 11:04 UTC by Alexander Ploumistos
Modified: 2015-05-10 23:46 UTC (History)
3 users (show)

Fixed In Version: gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22
Clone Of:
Environment:
Last Closed: 2015-05-10 23:46:42 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 530190 0 medium CLOSED Review Request: gdouros-aegyptus-fonts - A font for Egyptian hieroglyphs 2021-02-22 00:41:40 UTC

Internal Links: 530190

Description Alexander Ploumistos 2015-04-03 11:04:41 UTC
Spec URL:
https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-aegyptus-fonts/gdouros-aegyptus-fonts.spec

SRPM URL:
https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-aegyptus-fonts/gdouros-aegyptus-fonts-5.03-1.fc21.src.rpm

Description:
This packages provides 3 fonts:
-Aegyptus, an Extended List of 7062 Egyptian Hieroglyphs, in regular and bold
font weights.
-Nilus, which covers Coptic, Meroitic, Hieratic Alphabet and Transliteration
Characters.
-Gardiner, extracted from Aegyptus Bold, which covers the Gardiner set of 1071
Egyptian Hieroglyphs, supported by The Unicode Standard since version 5.2 in
the SMP block 13000 - 1342F.

There is no standard for Egyptian Hieroglyphs or Meroitic, so they are
allocated in the Supplementary Private Use Plane 15. The fonts also cover Basic
Latin and some Punctuation and other Symbols.

They were created by George Douros, mainly based on the book Hieroglyphica,
PIREI I², 2000 and the work of Alan Gardiner.


Fedora Account System Username: alexpl


Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=9402749


The font is already in fedora, but the current maintainer has been non-responsive for quite some time, so this is the last step of the relevant policy - a takeover request.

I have cleaned up the spec files from deprecated commands, added AppStream metadata and I have included sample files provided by upstream in a separate doc package. Following a brief discussion on devel ML and after having contacted upstream for clarifications, I have decided not to include the hinted fonts in the source package.

At some point, upstream decided to split the Aegyptus font into three: Aegyptus, Gardiner and Nilus. Given that all their glyphs are contained in the font package that we already have as gdouros-aegyptus-fonts and that they are complimentary to each other, I took the liberty to package them all together.

Comment 2 Parag AN(पराग) 2015-04-30 06:15:26 UTC
Review:

+ mock build is successful for F23 (x86_64)

+ rpmlint on generated rpms gave output
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
 
+ Source verified with upstream as (sha256sum)
srpm Source0: 64eeb840084a512779e2f0ad08e8d670346c3bafe5d81bddac8ba8c69376d527
upstream Source0 : 64eeb840084a512779e2f0ad08e8d670346c3bafe5d81bddac8ba8c69376d527
srpm Source3 : 927600d70b45568b2f23e677a3e7a6a29f948bc10134b33305cde9639e845604
upstream Source3 : 927600d70b45568b2f23e677a3e7a6a29f948bc10134b33305cde9639e845604

+ License is "Public Domain" as per given on upstream website "Fonts and documents in this site are not pieces of property or merchandise items; they carry no trademark, copyright, license or other market tags; they are free for any use". So no license text is included in font file or any text file

+ follows fonts packaging guidelines.

+ fontconfig file is present at priority 65.

+ Appdata metainfo file is present.


Suggestions:
1) Please package per family only and corresponding fontconfig file for that font. Drop Nilus* and Gardiner* files, references from spec file. You may want to submit them as separate packages. 

Provide new updated srpm which contains only aegyptus fonts.

Comment 3 Parag AN(पराग) 2015-04-30 08:29:01 UTC
Let's follow the same guideline here.
I propose to follow https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages with following changes

%global checkout 20150430

Release:        0.2.%{checkout}%{?dist}

also add changelog that uses 5.03-0.2.20150430

Comment 4 Alexander Ploumistos 2015-04-30 10:54:45 UTC
(In reply to Parag AN(पराग) from comment #2)
> 1) Please package per family only and corresponding fontconfig file for that
> font. Drop Nilus* and Gardiner* files, references from spec file. You may
> want to submit them as separate packages.

Is there a way to let users know that they might be interested in the other two (not yet created) packages, that works regardless of whether they install packages from the terminal or with a graphical package manager?

Comment 5 Alexander Ploumistos 2015-04-30 12:12:17 UTC
(In reply to Alexander Ploumistos from comment #4)
> Is there a way to let users know that they might be interested in the other
> two (not yet created) packages, that works regardless of whether they
> install packages from the terminal or with a graphical package manager?

I asked Richard Hughes about that and he suggested that I create a meta-font that references 3 packages. I'll look into that right after I have updated all of the spec files and srpms.

Comment 7 Parag AN(पराग) 2015-04-30 14:20:47 UTC
(In reply to Alexander Ploumistos from comment #4)
> (In reply to Parag AN(पराग) from comment #2)
> > 1) Please package per family only and corresponding fontconfig file for that
> > font. Drop Nilus* and Gardiner* files, references from spec file. You may
> > want to submit them as separate packages.
> 
> Is there a way to let users know that they might be interested in the other
> two (not yet created) packages, that works regardless of whether they
> install packages from the terminal or with a graphical package manager?

Only I think on this is to modify %description and add a line where you can say other fonts provided by this font developer are <pkg1>, <pkg2>

But this is really not needed as one can search fonts and their package summary will appear when they do like this
dnf search gdourus

Or you can write a blog and feed it to planet.fedoraproject.org and also google can then show your blog entry in google search.

Comment 8 Parag AN(पराग) 2015-05-01 04:53:29 UTC
(In reply to Alexander Ploumistos from comment #5)
> (In reply to Alexander Ploumistos from comment #4)
> > Is there a way to let users know that they might be interested in the other
> > two (not yet created) packages, that works regardless of whether they
> > install packages from the terminal or with a graphical package manager?
> 
> I asked Richard Hughes about that and he suggested that I create a meta-font
> that references 3 packages. I'll look into that right after I have updated
> all of the spec files and srpms.

We package per family fonts. See https://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming page. So all other fonts need to be packaged as separate fonts and they will provide their own metainfo file. Just check all those 3 fonts have no common family name all are different.

Comment 9 Alexander Ploumistos 2015-05-01 11:52:09 UTC
(In reply to Parag AN(पराग) from comment #8)
> We package per family fonts. See
> https://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming page. So all
> other fonts need to be packaged as separate fonts and they will provide
> their own metainfo file. Just check all those 3 fonts have no common family
> name all are different.

The thing is that upstream does not follow typographic conventions, so even though these fonts *should* be in the same family, they are not. You have seen the structure of his web page; there is some sort of grouping that sometimes makes sense, others not so much.
On the other hand, he ships Alexander and several others in the TextFonts package, so at some point we could have gdouros-textfonts-alexander-fonts and such.

Comment 10 Parag AN(पराग) 2015-05-02 06:24:26 UTC
The updated srpm in comment#6 looks good now.

Package APPROVED.

You want to submit here package change request to own this package. See https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages

Comment 11 Alexander Ploumistos 2015-05-02 10:47:37 UTC
Do I need to specify the branches in my request, or is the following sufficient?

Package Change Request
======================
Package Name: gdouros-aegyptus-fonts
Owners: alexpl
InitialCC: fonts-sig


(not setting the cvs flag yet on purpose)

Comment 12 Parag Nemade 2015-05-02 11:04:44 UTC
Yes add again CVS request with all the branches where you want to be owner.

Comment 13 Alexander Ploumistos 2015-05-02 11:22:17 UTC
Package Change Request
======================
Package Name: gdouros-aegyptus-fonts
Branches: f20 f21 f22 master
Owners: alexpl
InitialCC: fonts-sig

Comment 14 Gwyn Ciesla 2015-05-03 21:50:52 UTC
Complete.

Comment 15 Fedora Update System 2015-05-04 10:56:52 UTC
gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22

Comment 16 Fedora Update System 2015-05-08 07:30:27 UTC
Package gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-7627/gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22
then log in and leave karma (feedback).

Comment 17 Fedora Update System 2015-05-10 23:46:42 UTC
gdouros-aegyptus-fonts-5.03-0.2.20150430.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.