Bug 1209205

Dropping BR on python3-mox - not running test for python 3 package.

Needed to build protobuf package.

I can tek this review.

Ping?

Brendan - Are you going to do this?  It's blocking a number of builds at this point?  Thanks.

This seems to be a trivial review. I'll take over.

I'd suggest using
   %global _docdir_fmt %{name}
and sharing the doc and license files between the two subpackages. One less directory is always nice.

Version seems to be missing from changelog entry.

Some issues are pointed out by rpmlint below.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated". 18 files have unknown license.
     Detailed output of licensecheck in /var/tmp/1209205-python-google-
     apputils/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python2.7/site-
     packages/google(protobuf-python)
Seems OK to co-own this directory between packages from google namespace.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3
     -google-apputils
[x]: Package functions as described.
import works :)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-google-apputils-0.4.2-1.fc23.noarch.rpm
          python3-google-apputils-0.4.2-1.fc23.noarch.rpm
          python-google-apputils-0.4.2-1.fc23.src.rpm
python-google-apputils.noarch: W: spelling-error %description -l en_US startup -> start up, start-up, upstart
python-google-apputils.noarch: W: spelling-error %description -l en_US gflags -> flags, gulags, g flags
python-google-apputils.noarch: W: spelling-error %description -l en_US pdb -> pd, db, pub
python-google-apputils.noarch: W: spelling-error %description -l en_US datetime -> date time, date-time, daytime
python-google-apputils.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
All false.

python-google-apputils.noarch: W: no-version-in-last-changelog
Should be added.

python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/datelib.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/stopwatch.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/humanize.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/appcommands.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/run_script_module.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/file_util.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/setup_command.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/basetest.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/shellutil.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/app.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/resources.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/debug.py 0644L /usr/bin/env
python-google-apputils.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/google/apputils/__init__.py 0644L /usr/bin/env

This *should* be changed to %{__python2}, and to %{__python3} for the python3- subpackage. Especially for the python3- subpackage, because '/usr/bin/env python' can be understood to be python2, which is misleading.


python3-google-apputils.noarch: W: spelling-error %description -l en_US startup -> start up, start-up, upstart
python3-google-apputils.noarch: W: spelling-error %description -l en_US gflags -> flags, gulags, g flags
python3-google-apputils.noarch: W: spelling-error %description -l en_US pdb -> pd, db, pub
python3-google-apputils.noarch: W: spelling-error %description -l en_US datetime -> date time, date-time, daytime
python3-google-apputils.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
python3-google-apputils.noarch: W: no-version-in-last-changelog
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/appcommands.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/resources.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/stopwatch.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/run_script_module.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/__init__.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/basetest.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/humanize.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/setup_command.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/debug.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/app.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/shellutil.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/file_util.py 0644L /usr/bin/env
python3-google-apputils.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/google/apputils/datelib.py 0644L /usr/bin/env
python-google-apputils.src: W: spelling-error %description -l en_US startup -> start up, start-up, upstart
python-google-apputils.src: W: spelling-error %description -l en_US gflags -> flags, gulags, g flags
python-google-apputils.src: W: spelling-error %description -l en_US pdb -> pd, db, pub
python-google-apputils.src: W: spelling-error %description -l en_US datetime -> date time, date-time, daytime
python-google-apputils.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
python-google-apputils.src: W: no-version-in-last-changelog

python-google-apputils.src:111: W: macro-in-comment %{__python3}
Would be nice to correct.

3 packages and 0 specfiles checked; 26 errors, 19 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
python-google-apputils (rpmlib, GLIBC filtered):
    python(abi)
    python-dateutil
    python-gflags
    pytz

python3-google-apputils (rpmlib, GLIBC filtered):
    python(abi)
    python3-dateutil
    python3-gflags
    python3-pytz



Provides
--------
python-google-apputils:
    python-google-apputils

python3-google-apputils:
    python3-google-apputils



Source checksums
----------------
https://pypi.python.org/packages/source/g/google-apputils/google-apputils-0.4.2.tar.gz :
  CHECKSUM(SHA256) this package     : 47959d0651c32102c10ad919b8a0ffe0ae85f44b8457ddcf2bdc0358fb03dc29
  CHECKSUM(SHA256) upstream package : 47959d0651c32102c10ad919b8a0ffe0ae85f44b8457ddcf2bdc0358fb03dc29


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1209205
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Thanks

Spec URL: http://www.cora.nwra.com/~orion/fedora/python-google-apputils.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-google-apputils-0.4.2-2.fc22.src.rpm

* Tue Apr 21 2015 Orion Poplawski <orion.com> - 0.4.2-2
- Use _docdir_fmt macro
- Fix changelog
- Strip shbang from python library files

Looks great. Package is APPROVED.

Thanks for the review.

New Package SCM Request
=======================
Package Name: python-google-apputils
Short Description: Google Application Utilities for Python
Upstream URL: https://github.com/google/google-apputils
Owners: orion group::python-sig
Branches: f22 f21
InitialCC:

Git done (by process-git-requests).

Groups may not be owners, only in InitialCC.

(In reply to Jon Ciesla from comment #11)
> Git done (by process-git-requests).
> 
> Groups may not be owners, only in InitialCC.

Thanks - but you might want to fix https://fedoraproject.org/wiki/Package_SCM_admin_requests#Pseudo-users_and_Groups_for_SIGs then.