Bug 1209446
| Summary: | Review Request: carbonate - Utilities for managing graphite clusters | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | carbonate-0.2.2-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-29 01:38:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Piotr Popieluch
2015-04-07 11:36:59 UTC
Update for new guidelines Spec URL: https://piotrp.fedorapeople.org/carbonate.spec SRPM URL: https://piotrp.fedorapeople.org/carbonate-0.2.2-1.fc22.src.rpm Review: + Package built successfully in mock F23 (x86_64) + rpmlint on all generated rpms gave output carbonate.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure carbonate.noarch: W: no-manual-page-for-binary carbon-sieve carbonate.noarch: W: no-manual-page-for-binary carbon-path carbonate.noarch: W: no-manual-page-for-binary carbon-hosts carbonate.noarch: W: no-manual-page-for-binary carbon-lookup carbonate.noarch: W: no-manual-page-for-binary carbon-sync carbonate.noarch: W: no-manual-page-for-binary carbon-list carbonate.noarch: W: no-manual-page-for-binary whisper-aggregate carbonate.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure 2 packages and 0 specfiles checked; 0 errors, 9 warnings. + Source verified with upstream as (sha256sum) source in srpm:fe9e0c1a1d806edf996fccb6ed5ca387fb0d50bfa14babdffa2bbbeaf003bc6a source upstream:fe9e0c1a1d806edf996fccb6ed5ca387fb0d50bfa14babdffa2bbbeaf003bc6a + License "MIT" is valid and included in its own text file LICENSE. + Follows python packaging guidelines Suggestions: 1) You don't need to package MANIFEST.in 2) As explained in https://fedoraproject.org/wiki/Packaging:Guidelines#Macros , system binaries mkdir should be used actually. so use "mkdir -p" instead %{__mkdir_p} rest looks fine. APPROVED. Thank you, will fix suggestions before importing. New Package SCM Request ======================= Package Name: carbonate Short Description: Utilities for managing graphite clusters Upstream URL: https://github.com/jssjr/carbonate Owners: piotrp Branches: f21 f22 el6 epel7 Git done (by process-git-requests). carbonate-0.2.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/carbonate-0.2.2-1.fc21 carbonate-0.2.2-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/carbonate-0.2.2-1.el7 carbonate-0.2.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/carbonate-0.2.2-1.el6 carbonate-0.2.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/carbonate-0.2.2-1.fc22 carbonate-0.2.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. carbonate-0.2.2-1.fc21 has been pushed to the Fedora 21 stable repository. carbonate-0.2.2-1.fc22 has been pushed to the Fedora 22 stable repository. carbonate-0.2.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. carbonate-0.2.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |