Bug 1209446 - Review Request: carbonate - Utilities for managing graphite clusters
Summary: Review Request: carbonate - Utilities for managing graphite clusters
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-07 11:36 UTC by Piotr Popieluch
Modified: 2015-07-30 05:03 UTC (History)
2 users (show)

Fixed In Version: carbonate-0.2.2-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-29 01:38:46 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2015-04-07 11:36:59 UTC
Spec URL: https://piotrp.fedorapeople.org/carbonate.spec
SRPM URL: https://piotrp.fedorapeople.org/carbonate-0.2.2-1.fc21.src.rpm
Description: Utilities for managing graphite clusters
Fedora Account System Username: piotrp

Comment 1 Piotr Popieluch 2015-06-20 21:08:42 UTC
Update for new guidelines

Spec URL: https://piotrp.fedorapeople.org/carbonate.spec
SRPM URL: https://piotrp.fedorapeople.org/carbonate-0.2.2-1.fc22.src.rpm

Comment 2 Parag AN(पराग) 2015-07-08 06:43:23 UTC
Review:

+ Package built successfully in mock F23 (x86_64)

+ rpmlint on all generated rpms gave output
carbonate.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
carbonate.noarch: W: no-manual-page-for-binary carbon-sieve
carbonate.noarch: W: no-manual-page-for-binary carbon-path
carbonate.noarch: W: no-manual-page-for-binary carbon-hosts
carbonate.noarch: W: no-manual-page-for-binary carbon-lookup
carbonate.noarch: W: no-manual-page-for-binary carbon-sync
carbonate.noarch: W: no-manual-page-for-binary carbon-list
carbonate.noarch: W: no-manual-page-for-binary whisper-aggregate
carbonate.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
2 packages and 0 specfiles checked; 0 errors, 9 warnings.

+ Source verified with upstream as (sha256sum)
source in srpm:fe9e0c1a1d806edf996fccb6ed5ca387fb0d50bfa14babdffa2bbbeaf003bc6a
source upstream:fe9e0c1a1d806edf996fccb6ed5ca387fb0d50bfa14babdffa2bbbeaf003bc6a

+ License "MIT" is valid and included in its own text file LICENSE.

+ Follows python packaging guidelines

Suggestions:
1) You don't need to package MANIFEST.in

2) As explained in https://fedoraproject.org/wiki/Packaging:Guidelines#Macros , system binaries mkdir should be used actually. so use "mkdir -p" instead %{__mkdir_p}

rest looks fine.

APPROVED.

Comment 3 Piotr Popieluch 2015-07-08 11:47:26 UTC
Thank you, will fix suggestions before importing.

New Package SCM Request
=======================
Package Name: carbonate
Short Description: Utilities for managing graphite clusters
Upstream URL: https://github.com/jssjr/carbonate
Owners: piotrp
Branches: f21 f22 el6 epel7

Comment 4 Gwyn Ciesla 2015-07-08 12:22:23 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2015-07-08 17:36:45 UTC
carbonate-0.2.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/carbonate-0.2.2-1.fc21

Comment 6 Fedora Update System 2015-07-08 17:39:17 UTC
carbonate-0.2.2-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/carbonate-0.2.2-1.el7

Comment 7 Fedora Update System 2015-07-08 17:40:08 UTC
carbonate-0.2.2-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/carbonate-0.2.2-1.el6

Comment 8 Fedora Update System 2015-07-08 17:42:35 UTC
carbonate-0.2.2-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/carbonate-0.2.2-1.fc22

Comment 9 Fedora Update System 2015-07-13 18:30:01 UTC
carbonate-0.2.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 10 Fedora Update System 2015-07-29 01:38:46 UTC
carbonate-0.2.2-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2015-07-29 01:55:30 UTC
carbonate-0.2.2-1.fc22 has been pushed to the Fedora 22 stable repository.

Comment 12 Fedora Update System 2015-07-30 04:58:06 UTC
carbonate-0.2.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 13 Fedora Update System 2015-07-30 05:03:16 UTC
carbonate-0.2.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.