Bug 1210572
| Summary: | The usage of manual doc and error message about 'sparse' should be consistent in virt-install | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | tingting zheng <tzheng> |
| Component: | virt-manager | Assignee: | Pavel Hrdina <phrdina> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 7.2 | CC: | cwei, dallan, gscrivan, hyao, jwu, lcui, mjenner, mzhan, tzheng, virt-bugs, virt-mgr-maint |
| Target Milestone: | rc | Keywords: | Upstream |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | virt-manager-1.2.1-1-el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 873582 | Environment: | |
| Last Closed: | 2015-11-19 05:25:22 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 873582 | ||
| Bug Blocks: | |||
|
Comment 2
Giuseppe Scrivano
2015-04-10 11:28:37 UTC
upstream commit:
commit 549c93be5f2d102f61ba4b7276561bb119b5220c
Author: Giuseppe Scrivano <gscrivan>
Date: Fri Apr 10 12:37:09 2015 +0200
doc: make --sparse documentation consistent with error message
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1210572
Signed-off-by: Giuseppe Scrivano <gscrivan>
I can reproduce this bug with package:
virt-manager-1.1.0-12.el7.noarch
Steps are the same as description above.
Then try to verify with new build:
virt-manager-1.2.0-4.el7.noarch
Steps:
1. Check manual doc of virt-install about sparse, check the usage explanation:
#man virt-install
sparse
whether to skip fully allocating newly created storage. Value is
'yes' or 'no'. Default is 'yes' (do not fully allocate)
unless it isn't supported by the underlying storage type.
The initial time taken to fully-allocate the guest virtual disk
(SPARSE=FALSE) will be usually balanced by faster install times
inside the guest. Thus use of this option is recommended to
ensure consistently high performance and to avoid I/O errors in
the guest should the host filesystem fill up.
2. Use "--nonsparse" with "--disk" at the same time:
#virt-install -n demo2 -r 512 -l http://download.englab.nay.redhat.com/pub/rhel/rel-eng/RHEL-6.7-20150519.0/6.7/Server/x86_64/os/ --disk path=/var/lib/libvirt/images/demo2.img,size=5 --nonsparse
Check the error message.
"ERROR Cannot mix --file, --nonsparse, or --file-size with --disk options. Use --disk PATH[,size=SIZE][,sparse=yes|no]"
3. Compare the usage of manual doc and error message about 'sparse'.
Result:
On paragraph 2 of the listed manual doc, '(sparse=false)' still exist and it is not consistent with error message and the rest of manual doc listed above.
According to the result above, move this bug from ON_QA to ASSIGNED.
Upstream patch proposed: https://www.redhat.com/archives/virt-tools-list/2015-June/msg00203.html Upstream commit:
commit 3a3a1d5bd455c600ba3f3b1cd172df10bfeb72de
Author: Pavel Hrdina <phrdina>
Date: Fri Jun 19 16:14:28 2015 +0200
doc: make --sparse documentation in man page consistent
Commit 549c93be fixed a man page to make --sparse documentation
consistent, but it forget to updated also the next paragraph.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1210572
Signed-off-by: Pavel Hrdina <phrdina>
Verify this bug with new build:
virt-manager-1.2.1-2.el7.noarch
Steps:
1. Check manual doc of virt-install about sparse, check the usage explanation:
#man virt-install
sparse
whether to skip fully allocating newly created storage. Value is
'yes' or 'no'. Default is 'yes' (do not fully allocate)
unless it isn't supported by the underlying storage type.
The initial time taken to fully-allocate the guest virtual disk
(SPARSE=no) will be usually balanced by faster install times
inside the guest. Thus use of this option is recommended to
ensure consistently high performance and to avoid I/O errors in
the guest should the host filesystem fill up.
2. Use "--nonsparse" with "--disk" at the same time:
#virt-install -n demo2 -r 512 -l http://download.englab.nay.redhat.com/pub/rhel/rel-eng/RHEL-6.7-20150519.0/6.7/Server/x86_64/os/ --disk path=/var/lib/libvirt/images/demo2.img,size=5 --nonsparse
Check the error message.
"ERROR Cannot mix --file, --nonsparse, or --file-size with --disk options. Use --disk PATH[,size=SIZE][,sparse=yes|no]"
3. Compare the usage of manual doc and error message about 'sparse'.
Result:
It is consistent between error message and the part of manual doc listed above.
According to the result above, move this bug from ON_QA to VERIFIED.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2206.html |