Bug 1210934
| Summary: | qcow2 image creation using qemu-img hits segmentation fault | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Poornima G <pgurusid> |
| Component: | libgfapi | Assignee: | Poornima G <pgurusid> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Sudhir D <sdharane> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | bugs, mzhan, ndevos, sasundar, sbonazzo |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1210137 | Environment: |
virt gluster integration
|
| Last Closed: | 2016-06-16 12:49:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1210137 | ||
| Bug Blocks: | 1175354, 1215787 | ||
|
Description
Poornima G
2015-04-11 05:56:40 UTC
REVIEW: http://review.gluster.org/10205 (libgfapi: Assign corect value to THIS) posted (#1) for review on master by Poornima G (pgurusid) *** Bug 1210137 has been marked as a duplicate of this bug. *** *** This bug has been marked as a duplicate of bug 1210137 *** REVIEW: http://review.gluster.org/10205 (libgfapi: Assign corect value to THIS) posted (#2) for review on master by Vijay Bellur (vbellur) REVIEW: http://review.gluster.org/10205 (libgfapi: Assign corect value to THIS) posted (#3) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/10205 (libgfapi: Assign corect value to THIS) posted (#4) for review on master by Poornima G (pgurusid) *** Bug 1198573 has been marked as a duplicate of this bug. *** REVIEW: http://review.gluster.org/9797 (libgfapi: Store and restore THIS in every API exposed by libgfapi) posted (#7) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/9797 (libgfapi: Store and restore THIS in every API exposed by libgfapi) posted (#8) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/10205 (libgfapi: Assign corect value to THIS) posted (#5) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/10205 (libgfapi: Assign correct value to THIS) posted (#6) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/9797 (libgfapi: Fix the THIS usage in libgfapi) posted (#9) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/9797 (libgfapi: Store and restore THIS in every API exposed by libgfapi) posted (#10) for review on master by Poornima G (pgurusid) COMMIT: http://review.gluster.org/9797 committed in master by Niels de Vos (ndevos) ------ commit 1162bb36108ab8dba8303b86927a99835b791d79 Author: Poornima G <pgurusid> Date: Wed Apr 29 13:03:52 2015 +0530 libgfapi: Store and restore THIS in every API exposed by libgfapi Storing and restoring THIS: When the APIs exposed by libgfapi are called by other xlators like snapview server etc. the THIS value is overwritten to contain the THIS of libgfapi(viz libgfapi master xlator). Hence using 'THIS' in any xlator after calling libgfapi API will lead to issues. One such issue was uncovered in snapview and the patch http://review.gluster.org/#/c/9469/ was sent to workaround this issue. Hence, storing and restoring THIS, at the entry and exit of every API exposed by libgfapi. Change-Id: I6f330dde25e7700fb26339d667a7ccd193ec6ba0 BUG: 1210934 Signed-off-by: Poornima G <pgurusid> Reviewed-on: http://review.gluster.org/9797 Reviewed-by: Raghavendra Talur <rtalur> Reviewed-by: soumya k <skoduri> Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/10414 (libgfapi: Store and restore THIS in every API exposed by libgfapi) posted (#3) for review on release-3.7 by Raghavendra Talur (rtalur) COMMIT: http://review.gluster.org/10414 committed in release-3.7 by Vijay Bellur (vbellur) ------ commit 5fd6b3b7e2881d21a1b19fb22366e905314d71bc Author: Poornima G <pgurusid> Date: Wed Apr 29 13:03:52 2015 +0530 libgfapi: Store and restore THIS in every API exposed by libgfapi Backport of http://review.gluster.org/#/c/9797 Storing and restoring THIS: When the APIs exposed by libgfapi are called by other xlators like snapview server etc. the THIS value is overwritten to contain the THIS of libgfapi(viz libgfapi master xlator). Hence using 'THIS' in any xlator after calling libgfapi API will lead to issues. One such issue was uncovered in snapview and the patch http://review.gluster.org/#/c/9469/ was sent to workaround this issue. Hence, storing and restoring THIS, at the entry and exit of every API exposed by libgfapi. Change-Id: I6f330dde25e7700fb26339d667a7ccd193ec6ba0 BUG: 1210934 Signed-off-by: Poornima G <pgurusid> Reviewed-on: http://review.gluster.org/9797 Reviewed-by: Raghavendra Talur <rtalur> Reviewed-by: soumya k <skoduri> Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> (cherry picked from commit 1162bb36108ab8dba8303b86927a99835b791d79) Reviewed-on: http://review.gluster.org/10414 Reviewed-by: Shyamsundar Ranganathan <srangana> REVIEW: http://review.gluster.org/10728 (gfapi: fix compile warning in pub_glfs_h_access()) posted (#1) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/10728 (gfapi: fix compile warning in pub_glfs_h_access()) posted (#2) for review on master by Niels de Vos (ndevos) *** Bug 1210137 has been marked as a duplicate of this bug. *** COMMIT: http://review.gluster.org/10728 committed in master by Niels de Vos (ndevos) ------ commit 73b61d709712692b48a1c9b18b4547410fb9078c Author: Niels de Vos <ndevos> Date: Sat May 9 19:56:07 2015 +0200 gfapi: fix compile warning in pub_glfs_h_access() While compiling libgfapi, the following warning is reported: Making all in src CC libgfapi_la-glfs-handleops.lo In file included from glfs-handleops.c:12:0: glfs-handleops.c: In function 'pub_glfs_h_access': glfs-internal.h:216:14: warning: 'old_THIS' may be used uninitialized in this function [-Wmaybe-uninitialized] THIS = old_THIS; \ ^ glfs-internal.h:202:36: note: 'old_THIS' was declared here #define DECLARE_OLD_THIS xlator_t *old_THIS = NULL ^ glfs-handleops.c:1159:2: note: in expansion of macro 'DECLARE_OLD_THIS' DECLARE_OLD_THIS; ^ CCLD libgfapi.la CCLD api.la The DECLARE_OLD_THIS macro should be done with the declarations of all the other variables used in this function. Moving the macro further up in the function prevents this warning. Change-Id: I2bedc1aa074893ae3e2c933abc5a167ab5b55f41 BUG: 1210934 Reported-by: Shyamsundar Ranganathan <srangana> Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/10728 Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: NetBSD Build System Tested-by: Gluster Build System <jenkins.com> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |