Bug 1211594
| Summary: | status.brick memory allocation failure. | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Humble Chirammal <hchiramm> | |
| Component: | glusterd | Assignee: | bugs <bugs> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | mainline | CC: | bugs, gluster-bugs, kaushal | |
| Target Milestone: | --- | Keywords: | Reopened, Triaged | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1220020 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-16 12:50:21 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1220020 | |||
REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#5) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#6) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#7) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#8) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#9) for review on master by Humble Devassy Chirammal (humble.devassy) COMMIT: http://review.gluster.org/10144 committed in master by Vijay Bellur (vbellur) ------ commit f6e24fc54453669f3943e50f44cce9bb6070a71a Author: Humble Devassy Chirammal <hchiramm> Date: Tue Apr 7 11:27:19 2015 +0530 cli: Error out when there is not enough memory Change-Id: Ia8d061de5be1343cc10a945f6cf011686a770d33 BUG: 1211594 Signed-off-by: Humble Devassy Chirammal <hchiramm> Reviewed-on: http://review.gluster.org/10144 Tested-by: Gluster Build System <jenkins.com> Tested-by: NetBSD Build System Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/10674 (cli: Error out when there is not enough memory) posted (#2) for review on release-3.7 by Humble Devassy Chirammal (humble.devassy) Fix for this bug is already made in a GlusterFS release. The cloned BZ has details of the fix and the release. Hence closing this mainline BZ. Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well. This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |
Description of problem: At current stage, there is no memory allocation failure check on status.brick which can cause issues later in the error path. status.brick = GF_CALLOC (1, PATH_MAX + 256, gf_common_mt_strdup); switch (cmd & GF_CLI_STATUS_MASK) { switch (cmd & GF_CLI_STATUS_MASK) { .... Version-Release number of selected component (if applicable): GlusterFS 3.6.2 How reproducible: N/A Steps to Reproduce: N/A Actual results: The memory allocation success/failure is not respected in current code. Expected results: The proper error code has to be returned if there is a failure. Additional info: