Bug 1211594 - status.brick memory allocation failure.
Summary: status.brick memory allocation failure.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1220020
TreeView+ depends on / blocked
 
Reported: 2015-04-14 12:07 UTC by Humble Chirammal
Modified: 2016-06-16 12:50 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1220020 (view as bug list)
Environment:
Last Closed: 2016-06-16 12:50:21 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Humble Chirammal 2015-04-14 12:07:54 UTC
Description of problem:

At current stage, there is no memory allocation failure check on status.brick which can cause issues later in the error path. 


status.brick = GF_CALLOC (1, PATH_MAX + 256, gf_common_mt_strdup);
switch (cmd & GF_CLI_STATUS_MASK) 

{	switch (cmd & GF_CLI_STATUS_MASK) {
....

Version-Release number of selected component (if applicable):

GlusterFS 3.6.2

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:

The memory allocation success/failure is not respected in current code.


Expected results:

The proper error code has to be returned if there is a failure.

Additional info:

Comment 1 Anand Avati 2015-04-14 18:38:01 UTC
REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 2 Anand Avati 2015-04-15 07:20:32 UTC
REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#5) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 3 Anand Avati 2015-04-15 16:21:05 UTC
REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#6) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 4 Anand Avati 2015-04-16 03:43:57 UTC
REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#7) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 5 Anand Avati 2015-04-16 16:36:53 UTC
REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#8) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 6 Anand Avati 2015-04-17 04:39:14 UTC
REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#9) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 7 Anand Avati 2015-04-25 14:26:46 UTC
COMMIT: http://review.gluster.org/10144 committed in master by Vijay Bellur (vbellur) 
------
commit f6e24fc54453669f3943e50f44cce9bb6070a71a
Author: Humble Devassy Chirammal <hchiramm>
Date:   Tue Apr 7 11:27:19 2015 +0530

    cli: Error out when there is not enough memory
    
    Change-Id: Ia8d061de5be1343cc10a945f6cf011686a770d33
    BUG: 1211594
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/10144
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>

Comment 8 Anand Avati 2015-05-09 03:30:44 UTC
REVIEW: http://review.gluster.org/10674 (cli: Error out when there is not enough memory) posted (#2) for review on release-3.7 by Humble Devassy Chirammal (humble.devassy)

Comment 9 Nagaprasad Sathyanarayana 2015-10-25 14:54:15 UTC
Fix for this bug is already made in a GlusterFS release. The cloned BZ has details of the fix and the release. Hence closing this mainline BZ.

Comment 10 Nagaprasad Sathyanarayana 2015-10-25 15:05:39 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 11 Niels de Vos 2016-06-16 12:50:21 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.