Bug 1211693

Summary:	Foreman - ems refresh fails with "wrong number of arguments (2 for 1)"
Product:	Red Hat CloudForms Management Engine	Reporter:	Jan Krocil <jkrocil>
Component:	Providers	Assignee:	Keenan Brock <kbrock>
Status:	CLOSED ERRATA	QA Contact:	Aziza Karol <akarol>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	5.4.0	CC:	akarol, jfrey, jhardy, obarenbo
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-16 12:58:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Krocil 2015-04-14 15:41:39 UTC

Description of problem:
Ems refresh of foreman provider fails.

Version-Release number of selected component (if applicable):
5.4.0.0.19 - 5.4.0.0.19.20150410165622_ad23806

How reproducible:
Always

Steps to Reproduce:
1. Setup a foreman provider
2. Check evm.log

Actual results:
Ems refresh failure shows up in evm.log.

Expected results:
No errors.

Additional info:
[----] I, [2015-04-14T10:50:54.108792 #2297:463ea8]  INFO -- : MIQ(MiqQueue.get_via_drb) Message id: [4897], MiqWorker id: [45], Zone: [default], Role: [], Server: [], Ident: [generic], Target id: [], Instance i
d: [], Task id: [], Command: [ConfigurationManagerForeman.refresh_all_ems_timer], Timeout: [600], Priority: [90], State: [dequeue], Deliver On: [], Data: [], Args: [], Dequeued in: [5.254690984] seconds
[----] I, [2015-04-14T10:50:54.108949 #2297:463ea8]  INFO -- : MIQ(MiqQueue.deliver)    Message id: [4897], Delivering...
[----] I, [2015-04-14T10:50:54.111809 #2300:1251eac]  INFO -- : MIQ(MiqQueue.delivered)  Message id: [4895], State: [ok], Delivered in [0.019517967] seconds
[----] E, [2015-04-14T10:50:54.112364 #2297:463ea8] ERROR -- : MIQ(MiqQueue.deliver)    Message id: [4897], Error: [wrong number of arguments (2 for 1)]
[----] E, [2015-04-14T10:50:54.112718 #2297:463ea8] ERROR -- : [ArgumentError]: wrong number of arguments (2 for 1)  Method:[rescue in deliver]
[----] E, [2015-04-14T10:50:54.112861 #2297:463ea8] ERROR -- : /var/www/miq/vmdb/app/models/configuration_manager_foreman.rb:38:in `refresh_ems'
/var/www/miq/vmdb/app/models/ext_management_system.rb:206:in `refresh_all_ems_timer'
/var/www/miq/vmdb/app/models/miq_queue.rb:356:in `block in deliver'
/opt/rh/ruby200/root/usr/share/ruby/timeout.rb:66:in `timeout'
/var/www/miq/vmdb/app/models/miq_queue.rb:352:in `deliver'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:107:in `deliver_queue_message'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:135:in `deliver_message'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:152:in `block in do_work'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:146:in `loop'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:146:in `do_work'
/var/www/miq/vmdb/lib/workers/worker_base.rb:323:in `block in do_work_loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:320:in `loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:320:in `do_work_loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:141:in `run'
/var/www/miq/vmdb/lib/workers/worker_base.rb:122:in `start'
/var/www/miq/vmdb/lib/workers/worker_base.rb:23:in `start_worker'
/var/www/miq/vmdb/lib/workers/bin/worker.rb:3:in `<top (required)>'
/opt/rh/cfme-gemset/bundler/gems/rails-8f014fba21f9/railties/lib/rails/commands/runner.rb:52:in `eval'
/opt/rh/cfme-gemset/bundler/gems/rails-8f014fba21f9/railties/lib/rails/commands/runner.rb:52:in `<top (required)>'
/opt/rh/cfme-gemset/bundler/gems/rails-8f014fba21f9/railties/lib/rails/commands.rb:64:in `require'
/opt/rh/cfme-gemset/bundler/gems/rails-8f014fba21f9/railties/lib/rails/commands.rb:64:in `<top (required)>'
script/rails:6:in `require'
script/rails:6:in `<main>'

Comment 2 Jason Frey 2015-04-14 15:46:20 UTC

Jan pinged me on IRC and I see that the ConfigurationManagerForeman overrides ems_refresh method but with a different signature, and I don't know why.  I think we can just throw away this method and rely on the base class method.

Comment 3 CFME Bot 2015-04-15 16:16:10 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/3ac8e9d415b8f37e90b72e97083835c69e93018b

commit 3ac8e9d415b8f37e90b72e97083835c69e93018b
Author:     Keenan Brock <kbrock>
AuthorDate: Tue Apr 14 21:45:42 2015 -0400
Commit:     Keenan Brock <kbrock>
CommitDate: Tue Apr 14 21:45:42 2015 -0400

    Use underlying refresh_ems impl for foreman
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1211693

 vmdb/app/models/configuration_manager_foreman.rb | 4 ----
 1 file changed, 4 deletions(-)

Comment 4 CFME Bot 2015-04-16 21:43:44 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/73279b21df3dc4cbdb663304a9a8e1aa88b5a512

commit 73279b21df3dc4cbdb663304a9a8e1aa88b5a512
Author:     Aaron Patterson <aaron.patterson>
AuthorDate: Thu Apr 16 17:36:56 2015 -0400
Commit:     Aaron Patterson <aaron.patterson>
CommitDate: Thu Apr 16 17:36:56 2015 -0400

    [ci skip] skip asset compile on update_start
    
    we are compiling assets when packaging the RPM so we don't need to do
    that when doing update_start.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1211693

 vmdb/lib/tasks/evm.rake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 5 Jason Frey 2015-04-16 21:47:19 UTC

The last comment was accidentally on the wrong BZ.  It should have been on BZ 1208258

Comment 7 Aziza Karol 2015-04-30 07:59:59 UTC

No errors in foreman refresh.

Verified:
5.4.0.0.24.20150427192818_1fd9e49

Comment 9 errata-xmlrpc 2015-06-16 12:58:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html