Bug 1208258 - Binaries without Sources in gemset RPM
Summary: Binaries without Sources in gemset RPM
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Build
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: GA
: 5.4.0
Assignee: Joe Vlcek
QA Contact: Milan Falešník
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-01 19:04 UTC by releng-rhel@redhat.com
Modified: 2015-06-16 12:56 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-16 12:56:42 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1100 0 normal SHIPPED_LIVE CFME 5.4.0 bug fixes, and enhancement update 2015-06-16 16:28:42 UTC

Description releng-rhel@redhat.com 2015-04-01 19:04:28 UTC
I decompressed cfme-gemset-5.4.0.0.14.tar.gz in the cfme-gemset
dist-git repository and ran find on the contents of that. In dist-git
the branch I used is cfme-ruby200-5.4-rhel-6.

$ find -name '*.so'
./gems/io-extra-1.2.8/lib/io/extra.so
./gems/io-extra-1.2.8/ext/extra.so
./gems/therubyracer-0.12.1/lib/v8/init.so
./gems/therubyracer-0.12.1/ext/v8/init.so
./gems/thin-1.3.1/lib/thin_parser.so
./gems/thin-1.3.1/ext/thin_parser/thin_parser.so
./gems/json-1.8.2/lib/json/ext/generator.so
./gems/json-1.8.2/lib/json/ext/parser.so
./gems/json-1.8.2/ext/json/ext/generator/generator.so
./gems/json-1.8.2/ext/json/ext/parser/parser.so
./gems/nokogiri-1.5.11/lib/nokogiri/nokogiri.so
./gems/nokogiri-1.5.11/ext/nokogiri/nokogiri.so
./gems/psych-2.0.13/lib/psych.so
./gems/psych-2.0.13/ext/psych/psych.so
./gems/eventmachine-1.0.7/lib/fastfilereaderext.so
./gems/eventmachine-1.0.7/lib/rubyeventmachine.so
./gems/eventmachine-1.0.7/ext/fastfilereader/fastfilereaderext.so
./gems/eventmachine-1.0.7/ext/rubyeventmachine.so
./gems/bcrypt-ruby-3.0.1/lib/bcrypt_ext.so
./gems/bcrypt-ruby-3.0.1/ext/mri/bcrypt_ext.so
./gems/ffi-1.9.8/lib/ffi_c.so
./gems/ffi-1.9.8/ext/ffi_c/libffi-x86_64-linux/.libs/libffi.so
./gems/ffi-1.9.8/ext/ffi_c/ffi_c.so
./gems/pg-0.12.2/lib/pg_ext.so
./gems/pg-0.12.2/ext/pg_ext.so

These need to be compiled either as part of the gemset RPM build, or as separate gems built internally in Brew.

Comment 1 Jay Greguske 2015-04-01 19:05:56 UTC
Whoops, posted with the wrong account. I posted the above.

This is a blocker for GA (not beta)

Comment 2 CFME Bot 2015-04-16 21:43:48 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/fc581e63a9376e1e3ac4b75487a264afda0d3010

commit fc581e63a9376e1e3ac4b75487a264afda0d3010
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Apr 16 17:43:08 2015 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Thu Apr 16 17:43:15 2015 -0400

    Force ExecJS to use node
    
    [skip ci]
    https://bugzilla.redhat.com/show_bug.cgi?id=1208258

 system/LINK/etc/default/evm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comment 3 Jason Frey 2015-04-16 21:47:37 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/73279b21df3dc4cbdb663304a9a8e1aa88b5a512

commit 73279b21df3dc4cbdb663304a9a8e1aa88b5a512
Author:     Aaron Patterson <aaron.patterson>
AuthorDate: Thu Apr 16 17:36:56 2015 -0400
Commit:     Aaron Patterson <aaron.patterson>
CommitDate: Thu Apr 16 17:36:56 2015 -0400

    [ci skip] skip asset compile on update_start
    
    we are compiling assets when packaging the RPM so we don't need to do
    that when doing update_start.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1211693

 vmdb/lib/tasks/evm.rake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 4 CFME Bot 2015-04-16 21:49:12 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/55e11fa73adb24d9ca5a6899591f1f5afd80f9df

commit 55e11fa73adb24d9ca5a6899591f1f5afd80f9df
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Apr 16 17:44:17 2015 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Thu Apr 16 17:44:22 2015 -0400

    Only try to seed classes that define "self.seed" methods
    
    Constantizing all models in alphabetical order without hirearchy can cause
    subclass loading and "include_concern" issues with classes that are not yet
    defined.
    https://bugzilla.redhat.com/show_bug.cgi?id=1208258

 vmdb/lib/evm_database.rb | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comment 5 Joe Vlcek 2015-04-20 22:44:40 UTC
This issue been address in cfme-gemset-5.4.0.0.22.tar.gz

Comment 6 Milan Falešník 2015-04-29 15:02:01 UTC
How to verify this bug?

Is this:

# rpm -ql cfme-gemset | grep '[.]so$'

enough? I tried this on 5.4.0.0.24 build and no such files are present in the RPM by using this filter. Or is it an issue somewhere else?

Comment 7 Joe Vlcek 2015-04-29 15:06:06 UTC
Confirming there are not binaries in the cfme-gemset using the method you described should be sufficient.

Jay Greguske can you please confirm?

Comment 8 Jay Greguske 2015-04-29 17:34:40 UTC
Why am I confirming this? Do you not know how to find binaries in your own build? :)

Comment 9 Jay Greguske 2015-04-29 17:42:54 UTC
Kidding aside though my first comment indicates how to find them. There are obviously other types of binary files, so if we find more in cfme-gemset we'll open additional bugs.

Comment 10 Joe Vlcek 2015-04-30 12:08:56 UTC
(In reply to Jay Greguske from comment #9)
> Kidding aside though my first comment indicates how to find them. There are
> obviously other types of binary files, so if we find more in cfme-gemset
> we'll open additional bugs.

Since Rel Eng opened this bug I just want to confirm they
are OK with shipping the current solution for GA.

Jay/Rel-Eng please confirm acceptance of the current cfme-gemset
for the upcoming GA release of CFME 5.4

Please provide pointers to and available tooling Rel-Eng uses for
validating RPM sources, if any exists.

Comment 11 Jay Greguske 2015-04-30 18:11:19 UTC
Is  5.4.0.0.24  the version I should confirm?

Comment 12 Joe Vlcek 2015-04-30 18:30:22 UTC
(In reply to Jay Greguske from comment #11)
> Is  5.4.0.0.24  the version I should confirm?

Yes please.

Comment 13 Jay Greguske 2015-04-30 18:35:30 UTC
Looks ok to me!

Comment 15 Milan Falešník 2015-05-04 08:11:33 UTC
Verified in 5.4.0.0.24.20150427192818_1fd9e49 then

Comment 17 errata-xmlrpc 2015-06-16 12:56:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html


Note You need to log in before you can comment on or make changes to this bug.