Bug 1212103

Summary: Review Request: perl-Text-Template-Simple - Simple text template engine
Product: [Fedora] Fedora Reporter: Petr Šabata <psabata>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Text-Template-Simple-0.86-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-04-28 14:20:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1211346    

Description Petr Šabata 2015-04-15 14:36:57 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Text-Template-Simple/perl-Text-Template-Simple.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Text-Template-Simple/perl-Text-Template-Simple-0.86-1.fc21.src.rpm
Description:
Simple text template engine.
Fedora Account System Username: psabata

Comment 1 Jitka Plesnikova 2015-04-16 08:24:07 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Text-Template-Simple-0.86-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(Carp)
      1 perl(Data::Dumper) >= 2.101
      1 perl(Devel::Size) >= 0.77
      1 perl(Digest::MD5)
      1 perl(Exporter)
      1 perl(FIle::stat)
      1 perl(Fcntl) >= 1.03
      1 perl(File::Find)
      1 perl(File::Spec)
      1 perl(File::Spec) >= 0.6
      1 perl(IO::File)
      1 perl(IO::Handle)
      1 perl(Perl::Tidy)
      1 perl(Safe) >= 2.06
      1 perl(Symbol)
      1 perl(Text::Table) >= 1.107
      1 perl(Text::Template::Simple::Cache)
      1 perl(Text::Template::Simple::Cache::ID)
      1 perl(Text::Template::Simple::Caller)
      1 perl(Text::Template::Simple::Compiler)
      1 perl(Text::Template::Simple::Compiler::Safe)
      1 perl(Text::Template::Simple::Constants)
      1 perl(Text::Template::Simple::Dummy)
      1 perl(Text::Template::Simple::IO)
      1 perl(Text::Template::Simple::Tokenizer)
      1 perl(Text::Template::Simple::Util)
      1 perl(base)
      1 perl(constant)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are almost ok.

FIX: typo in Requires perl(FIle::stat) should be perl(File::stat)
TODO: Filter unversioned perl(File::Spec)

$ rpm -qp --provides perl-Text-Template-Simple-0.86-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(Text::Template::Simple) = 0.86
      1 perl(Text::Template::Simple::Base::Compiler) = 0.86
      1 perl(Text::Template::Simple::Base::Examine) = 0.86
      1 perl(Text::Template::Simple::Base::Include) = 0.86
      1 perl(Text::Template::Simple::Base::Parser) = 0.86
      1 perl(Text::Template::Simple::Cache) = 0.86
      1 perl(Text::Template::Simple::Cache::ID) = 0.86
      1 perl(Text::Template::Simple::Caller) = 0.86
      1 perl(Text::Template::Simple::Compiler) = 0.86
      1 perl(Text::Template::Simple::Compiler::Safe) = 0.86
      1 perl(Text::Template::Simple::Constants) = 0.86
      1 perl(Text::Template::Simple::Dummy) = 0.86
      1 perl(Text::Template::Simple::IO) = 0.86
      1 perl(Text::Template::Simple::Tokenizer) = 0.86
      1 perl(Text::Template::Simple::Util) = 0.86
      1 perl-Text-Template-Simple = 0.86-1.fc23
Binary provides are Ok.

$ rpmlint ./perl-Text-Template-Simple*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

Please correct all 'FIX' issues and consider fixing 'TODO' item

Otherwise package is good.
APPROVED.

Comment 2 Petr Šabata 2015-04-16 08:56:41 UTC
New Package SCM Request
=======================
Package Name: perl-Text-Template-Simple
Short Description: Simple text template engine
Upstream URL: http://search.cpan.org/dist/Text-Template-Simple/
Owners: psabata jplesnik ppisar
Branches: f21 f22
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-04-16 12:40:28 UTC
Git done (by process-git-requests).

Comment 4 Petr Šabata 2015-04-16 13:23:58 UTC
Thank you.

Comment 5 Fedora Update System 2015-04-16 13:39:57 UTC
perl-Text-Template-Simple-0.86-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/perl-Text-Template-Simple-0.86-1.fc22

Comment 6 Fedora Update System 2015-04-16 13:40:25 UTC
perl-Text-Template-Simple-0.86-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Text-Template-Simple-0.86-1.fc21

Comment 7 Fedora Update System 2015-04-22 22:50:36 UTC
perl-Text-Template-Simple-0.86-1.fc22 has been pushed to the Fedora 22 stable repository.

Comment 8 Fedora Update System 2015-04-28 13:15:25 UTC
perl-Text-Template-Simple-0.86-1.fc21 has been pushed to the Fedora 21 stable repository.