Bug 1211346 - Review Request: perl-Sys-Info-Base - Provides various system information
Summary: Review Request: perl-Sys-Info-Base - Provides various system information
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1212103
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-13 16:57 UTC by Petr Šabata
Modified: 2015-05-14 08:58 UTC (History)
2 users (show)

Fixed In Version: perl-Sys-Info-Base-0.7804-1.fc21
Clone Of:
Environment:
Last Closed: 2015-05-14 08:58:23 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2015-04-13 16:57:26 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Sys-Info-Base/perl-Sys-Info-Base.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Sys-Info-Base/perl-Sys-Info-Base-0.7804-1.fc21.src.rpm
Description:
Provides various system information.
Fedora Account System Username: psabata

Comment 1 Petr Pisar 2015-04-14 15:18:30 UTC
URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 96ca63d624aaf658aa6869df61cac11df93353041958a3821ed0ca34b6d4611c). Ok.
Summary is Ok.
Description is Ok.
License verified from LICENSE and various files. Ok.
No XS code, noarch BuildArch is Ok.
Build-requires are Ok.
All tests pass. Ok.

$ rpmlint perl-Sys-Info-Base.spec ../SRPMS/perl-Sys-Info-Base-0.7804-1.fc23.src.rpm ../RPMS/noarch/perl-Sys-Info-Base-0.7804-1.fc23.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Sys-Info-Base-0.7804-1.fc23.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Apr 14 16:58 /usr/share/doc/perl-Sys-Info-Base
-rw-r--r--    1 root    root                     1246 Jan 21 02:36 /usr/share/doc/perl-Sys-Info-Base/Changes
-rw-r--r--    1 root    root                      607 Jan 21 02:36 /usr/share/doc/perl-Sys-Info-Base/README
drwxr-xr-x    2 root    root                        0 Apr 14 16:58 /usr/share/licenses/perl-Sys-Info-Base
-rw-r--r--    1 root    root                    18398 Jan 21 02:36 /usr/share/licenses/perl-Sys-Info-Base/LICENSE
-rw-r--r--    1 root    root                     2621 Apr 14 16:58 /usr/share/man/man3/Sys::Info::Base.3pm.gz
-rw-r--r--    1 root    root                     2531 Apr 14 16:58 /usr/share/man/man3/Sys::Info::Constants.3pm.gz
-rw-r--r--    1 root    root                     2382 Apr 14 16:58 /usr/share/man/man3/Sys::Info::Device.3pm.gz
-rw-r--r--    1 root    root                     3517 Apr 14 16:58 /usr/share/man/man3/Sys::Info::Device::CPU.3pm.gz
-rw-r--r--    1 root    root                     2062 Apr 14 16:58 /usr/share/man/man3/Sys::Info::Driver.3pm.gz
-rw-r--r--    1 root    root                     2581 Apr 14 16:58 /usr/share/man/man3/Sys::Info::Helper.3pm.gz
-rw-r--r--    1 root    root                     4218 Apr 14 16:58 /usr/share/man/man3/Sys::Info::OS.3pm.gz
drwxr-xr-x    2 root    root                        0 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys
drwxr-xr-x    2 root    root                        0 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info
-rw-r--r--    1 root    root                     5171 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info/Base.pm
-rw-r--r--    1 root    root                     4418 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info/Constants.pm
drwxr-xr-x    2 root    root                        0 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info/Device
-rw-r--r--    1 root    root                     2429 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info/Device.pm
-rw-r--r--    1 root    root                     6012 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info/Device/CPU.pm
-rw-r--r--    1 root    root                      668 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info/Driver.pm
-rw-r--r--    1 root    root                     6375 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info/Helper.pm
-rw-r--r--    1 root    root                     8311 Apr 14 16:58 /usr/share/perl5/vendor_perl/Sys/Info/OS.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Sys-Info-Base-0.7804-1.fc23.noarch.rpm | sort -f | uniq -c
      1 perl >= 0:5.006
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Cwd)
      1 perl(Data::Dumper)
      1 perl(Exporter)
      1 perl(File::Basename)
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(File::Spec::Functions)
      1 perl(IO::File)
      1 perl(POSIX)
      1 perl(Socket)
      1 perl(strict)
      1 perl(subs)
      1 perl(Sys::Hostname)
      1 perl(Sys::Info::Base)
      1 perl(Sys::Info::Constants)
      1 perl(Text::Template::Simple)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Sys-Info-Base-0.7804-1.fc23.noarch.rpm | sort -f | uniq -c
      1 perl(Sys::Info::Base) = 0.7804
      1 perl(Sys::Info::Constants) = 0.7804
      1 perl(Sys::Info::Device) = 0.7804
      1 perl(Sys::Info::Device::CPU) = 0.7804
      1 perl(Sys::Info::Driver) = 0.7804
      1 perl(Sys::Info::Helper) = 0.7804
      1 perl(Sys::Info::OS) = 0.7804
      1 perl-Sys-Info-Base = 0.7804-1.fc23
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Sys-Info-Base-0.7804-1.fc23.noarch.rpm 
Unresolved dependency: perl(Text::Template::Simple)
FIX: Package Text-Template-Simple first.

Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9477456). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items.

Resolution: Package NOT approved.

Comment 2 Petr Šabata 2015-04-16 13:41:27 UTC
Text::Template::Simple is now in Rawhide.

Comment 3 Petr Pisar 2015-04-20 11:37:28 UTC
> FIX: Package Text-Template-Simple first.
$ resolvedeps rawhide ../RPMS/noarch/perl-Sys-Info-Base-0.7804-1.fc23.noarch.rpm 
Binary dependencies resolvable. Ok.

Resolution: Package APPROVED.

Comment 4 Petr Šabata 2015-04-20 12:17:34 UTC
New Package SCM Request
=======================
Package Name: perl-Sys-Info-Base
Short Description: Provides various system information
Upstream URL: http://search.cpan.org/dist/Sys-Info-Base/
Owners: psabata jplesnik ppisar
Branches: f21 f22
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-04-20 12:44:57 UTC
Git done (by process-git-requests).

Comment 6 Petr Šabata 2015-04-20 16:06:08 UTC
Thanks.  Pushed to Rawhide for now.

Comment 7 Fedora Update System 2015-04-28 14:32:41 UTC
perl-Sys-Info-Base-0.7804-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/perl-Sys-Info-Base-0.7804-1.fc22

Comment 8 Fedora Update System 2015-04-28 14:33:00 UTC
perl-Sys-Info-Base-0.7804-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Sys-Info-Base-0.7804-1.fc21

Comment 9 Fedora Update System 2015-05-08 07:29:56 UTC
perl-Sys-Info-Base-0.7804-1.fc22 has been pushed to the Fedora 22 stable repository.

Comment 10 Fedora Update System 2015-05-10 23:46:57 UTC
perl-Sys-Info-Base-0.7804-1.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.